From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.500.1685644455390411265 for ; Thu, 01 Jun 2023 11:34:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=kEnl1UVE; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 351CdMm9018689; Thu, 1 Jun 2023 18:34:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=arYdjSR+7IJAwJ6OErg4xtPRX1yV8gT2yZ50jh5R+bk=; b=kEnl1UVErrCmOpoRCr/LHcaD0uWOJRqnU9oZgMGndYTrMp8VqkMMN0+hId5fb2QKPmNA 7e6lBSaMTSo8vKYrdIhjyWUhvFFQne0jCKaUItdDDSfNvovJmekBr+qQYMppB4cjjvRT JJYB7CRLYMpIpRjixDgN2Uw/iAj5r0ORn/dSs1SGPVifBXhpX01j5QVPzLD49fZzizEL OcNztZf9USrH4TiPyaWyH0GS6eJbSNdzKEN7ZDU8CxiU6blGwmLJfg6DeymCJcO94dT0 RoPBHnVVadJmdZPjEZzBDl2elpkMeq5OpcVAB3PSnq7WTTrNGMmGRRULSRNyBXXO9y08 OA== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qxugr8wg1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Jun 2023 18:34:12 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 351IYBsW011364 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Jun 2023 18:34:11 GMT Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Thu, 1 Jun 2023 11:34:10 -0700 Date: Thu, 1 Jun 2023 19:34:06 +0100 From: "Leif Lindholm" To: Graeme Gregory CC: , Ard Biesheuvel , Radoslaw Biernacki , Marcin Juszkiewicz , Sami Mujawar Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/2] SbsaQemu: make GIC base address Pcds dynamic Message-ID: References: <20230512175753.13318-1-quic_llindhol@quicinc.com> MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 3FKSyWwyvjVjeTvCdT7_jZ5d_PuoYJXB X-Proofpoint-ORIG-GUID: 3FKSyWwyvjVjeTvCdT7_jZ5d_PuoYJXB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-01_08,2023-05-31_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 mlxscore=0 clxscore=1015 impostorscore=0 adultscore=0 malwarescore=0 phishscore=0 bulkscore=0 mlxlogscore=748 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2306010160 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Thanks, Pushed as ce9ea07a8b56..4303f7782c08. On Tue, May 16, 2023 at 11:18:28 +0100, Graeme Gregory wrote: > On Fri, May 12, 2023 at 06:57:51PM +0100, Leif Lindholm wrote: > > Currently, the GIC and redistributors base addresses are defined using > > FixedPcds. > > > > In order to enable the QEMU platform to evolve to provide ITS frames, > > as well as newer versions of the GIC, convert these accesses to Dynamic. > > > > Firtsly, this requires fixing the bug of the addresses being read as 32-bit > > Pcds, and then moving the declarations and calls to the dynamic form. > > > > Messed this up first time, so... > > All patches look good to me. > > Reviewed-by: Graeme Gregory > > > Cc: Ard Biesheuvel > > Cc: Graeme Gregory > > Cc: Radoslaw Biernacki > > Cc: Marcin Juszkiewicz > > > > Leif Lindholm (2): > > Silicon/Qemu: use 64-bit Pcds for SbsaQemu GIC addresses > > Silicon/Qemu: use dynamic Pcds for SbsaQemu GIC addresses > > > > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 12 ++++++------ > > Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 7 ++++--- > > .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 5 +++-- > > .../SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h | 2 +- > > .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 2 +- > > 5 files changed, 15 insertions(+), 13 deletions(-) > > > > -- > > 2.30.2 > > > > > > > > > > > >