From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.8744.1685698491309131879 for ; Fri, 02 Jun 2023 02:34:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=S/t1S0la; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 352704QA003408; Fri, 2 Jun 2023 09:34:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=KPqMdhl7Tez1gIhcDRmH/UVMHxXm2N2lvDyS4p7iTc4=; b=S/t1S0lavUdfZrMXnkUclRa7RgjapHleK624DMDvxAlODxsG7RF5jBABFh9bpLyoWiUp HkIUxZDpz2IwcPbqArsoVydkR3toFFKYGtPYnhpj/JVOzV5cRbRPqm1xuuwJqmh0RC16 IAbxTU3jYIn+1lZNVOtyClrZDGelNE+1Ha7YoLxU6zpcyYLhRdLivwC28mMj7NOzA6by BZ9t/QEtm82oXIoY63W/T7tLIPayrvB03WUzljKqZSiVn4lqR3hppUgBehCUl7mNPLZJ DXqbnijArchHYlF4woKUUIlDHPIcyHc0dR3qTS8OvCKEpCRQBM7GSyeezSmAzKYWM/PE ZA== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qyb5f8auy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 Jun 2023 09:34:50 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3529Ynqw017467 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 2 Jun 2023 09:34:49 GMT Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Fri, 2 Jun 2023 02:34:48 -0700 Date: Fri, 2 Jun 2023 10:34:44 +0100 From: "Leif Lindholm" To: Ard Biesheuvel CC: , "Kinney, Michael D" , Michael Kubacki Subject: Re: [RFC PATCH] ArmPkg: Enable AuditMode for Uncrustify CI checks Message-ID: References: <20230602085136.3552790-1-ardb@kernel.org> MIME-Version: 1.0 In-Reply-To: <20230602085136.3552790-1-ardb@kernel.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: cGtcunNs9dWAi-WFwxFd7HFj6YBbG8gq X-Proofpoint-GUID: cGtcunNs9dWAi-WFwxFd7HFj6YBbG8gq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-02_06,2023-05-31_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 suspectscore=0 spamscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 phishscore=0 lowpriorityscore=0 mlxlogscore=631 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2306020071 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Fri, Jun 02, 2023 at 10:51:36 +0200, Ard Biesheuvel wrote: > Uncrustify checks are too rigid, making them counter-productive: > > - it leads to code that is arguably harder to parse visually (e.g., > the changes to ArmPkg/Include/Chipset/AArch64Mmu.h in commit > 429309e0c6b74792) > - it forces indentation-only changes to code in the vicinity of actual > changes, making the code history more bloated than necessary (see > commit 7f198321eec0f520373 for an example) > - finding out from the web UI what exactly Uncrustify objected to is not > straight-forward. > > So let's enable AuditMode for ArmPkg, so that interested parties can see > the uncrustify recommendations if desired, but without preventing the > changes from being merged. This leaves it at the discretion of the > ArmPkg maintainers to decide which level of conformance is required. > > Cc: Leif Lindholm > Cc: "Kinney, Michael D" > Cc: Michael Kubacki > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm I'm going to merge this - at least for now - since some of the quirks are holding back merging code that is compliant because of existing things it takes an issue with elsewhere in the file. / Leif > --- > ArmPkg/ArmPkg.ci.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml > index 24db7425051388cf..d3124816118944cb 100644 > --- a/ArmPkg/ArmPkg.ci.yaml > +++ b/ArmPkg/ArmPkg.ci.yaml > @@ -239,5 +239,10 @@ > ], > "AdditionalIncludePaths": [] # Additional paths to spell check > # (wildcards supported) > + }, > + > + # options defined in .pytool/Plugin/UncrustifyCheck > + "UncrustifyCheck": { > + "AuditOnly": True > } > } > -- > 2.39.2 >