From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by mx.groups.io with SMTP id smtpd.web11.9795.1686743959446746960 for ; Wed, 14 Jun 2023 04:59:19 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@ventanamicro.com header.s=google header.b=DNaPoycv; spf=pass (domain: ventanamicro.com, ip: 209.85.210.46, mailfrom: sunilvl@ventanamicro.com) Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-6b1576c2f6eso4265610a34.3 for ; Wed, 14 Jun 2023 04:59:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1686743958; x=1689335958; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UvMM2xo/wJv9kYIjp9BzbIJLm6zNKi8NNw2QdNkHkOA=; b=DNaPoycvWHsnfx1BIi8ATlEcwbEO2CGwUnBD5/RzIXtOxZ3uJhUOda1suBX4uMSEzx TpUbzLnzjYjUKpNWJNmv/4wm4v5zeztjOlJQ1X+WtjQKbpixyeaKJ/dgwxoZDpcwcp7N VuyXURGZPJyAPquL78p9cvW0yhrj+GSJPrS5W4IdMyaPIdlF0XNtmrFr34PwwPyZ57Z7 WZJ60600GXUBCGsQa0Y4f1+s3Z6uyM4cAnNZsChoaC5LrH3G6/ciyL5sNQtrnWqSXGyY EGtVgunE59U4pGsT2oaREaA3wVYrgyikNq7JytF/X9HbbDx6IwIC75G9TBZj4J7YkONb qsWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686743958; x=1689335958; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UvMM2xo/wJv9kYIjp9BzbIJLm6zNKi8NNw2QdNkHkOA=; b=Of0iGlgoXfv2rLU2efp2WcU0hcmvzvqTBVvnMp8swXdS0ItaFW+5YcwWr51wc5Gr0f /SaWGL8qzrZWvvemW6FbUOD5NkbsZ6sxkG0IobUipAPpD+rd31NhnZOfTKrhN/bB/vw9 DU1PwCXKKYOYrF47sr78Hm+TP0NCveGd+Idl6IGWRFaaZADHCJNumOThDw6HIbshceWg 9PLaaX+4NBg36YeuhBgGNaiGs8zhnOh5ygRWRJjitgxKAwR98SVM5lrS9zjc6ji56yjN s56feW/CExouHdXLYSoc5Eo0qKyth37nq6KaQEnZNI2qGUBcWzBh++bsMV8P23bsXtfr acvQ== X-Gm-Message-State: AC+VfDxturKX4DI0nc62FKR+GffeKfZJP2PebNCRWQyUmOgbkOeE/Adi kf00Wm6A8hFKTC1ckS0YiNmWQzJtee6B66GGlMs= X-Google-Smtp-Source: ACHHUZ5BprzLXT9Go+O58l0T1iBA4MDOS3ZWiMTU7HjTOgegrZSJ7EqEg1V3aHP794aAhtZ6a2eY2A== X-Received: by 2002:a9d:7452:0:b0:6b0:cde0:d9a with SMTP id p18-20020a9d7452000000b006b0cde00d9amr13973647otk.21.1686743958334; Wed, 14 Jun 2023 04:59:18 -0700 (PDT) Return-Path: Received: from sunil-laptop ([106.51.184.72]) by smtp.gmail.com with ESMTPSA id r17-20020a63ec51000000b0051b8172fa68sm11067014pgj.38.2023.06.14.04.59.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 04:59:17 -0700 (PDT) Date: Wed, 14 Jun 2023 17:29:12 +0530 From: "Sunil V L" To: devel@edk2.groups.io Cc: Rebecca Cran , Liming Gao , Bob Feng , Yuwei Chen , Andrei Warkentin Subject: Re: [PATCH 1/1] BaseTools/tools_def: Add "-fno-unwind-tables" to GCC5_RISCV64_CC_FLAGS Message-ID: References: <20230602170254.394449-1-sunilvl@ventanamicro.com> MIME-Version: 1.0 In-Reply-To: <20230602170254.394449-1-sunilvl@ventanamicro.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Liming, Could you please help with review and merge of this patch? Do I need to raise a BZ ticket? Thanks! Sunil On Fri, Jun 02, 2023 at 10:32:54PM +0530, Sunil V L wrote: > gcc-13 for RISC-V enables unwind tables by default similar to ARM64. > This generates .eh_frame_hdr section which is not handled well by > GenFw causing failures. > > Disable the unwind tables by adding -fno-unwind-tables flag similar > to [1]. > > [1] - https://github.com/tianocore/edk2/commit/cbf00651eda6 > > Signed-off-by: Sunil V L > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Cc: Andrei Warkentin > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > index 92421e3d0118..90f4105506e5 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -858,7 +858,7 @@ DEFINE GCC5_RISCV_OPENSBI_TYPES = -DOPENSBI_EXTERNAL_SBI_TYPES > > DEFINE GCC5_RISCV64_ARCH = rv64gc > DEFINE GCC5_RISCV32_RISCV64_ASLDLINK_FLAGS = DEF(GCC5_RISCV_ALL_DLINK_COMMON) -Wl,--entry,ReferenceAcpiTable -u ReferenceAcpiTable > -DEFINE GCC5_RISCV64_CC_FLAGS = DEF(GCC5_RISCV_ALL_CC_FLAGS) DEF(GCC5_RISCV_ALL_CC_FLAGS_WARNING_DISABLE) DEF(GCC5_RISCV_OPENSBI_TYPES) -march=DEF(GCC5_RISCV64_ARCH) -fno-builtin -fno-builtin-memcpy -fno-stack-protector -Wno-address -fno-asynchronous-unwind-tables -Wno-unused-but-set-variable -fpack-struct=8 -mcmodel=medany -mabi=lp64 -mno-relax > +DEFINE GCC5_RISCV64_CC_FLAGS = DEF(GCC5_RISCV_ALL_CC_FLAGS) DEF(GCC5_RISCV_ALL_CC_FLAGS_WARNING_DISABLE) DEF(GCC5_RISCV_OPENSBI_TYPES) -march=DEF(GCC5_RISCV64_ARCH) -fno-builtin -fno-builtin-memcpy -fno-stack-protector -Wno-address -fno-asynchronous-unwind-tables -fno-unwind-tables -Wno-unused-but-set-variable -fpack-struct=8 -mcmodel=medany -mabi=lp64 -mno-relax > DEFINE GCC5_RISCV64_DLINK_FLAGS = DEF(GCC5_RISCV_ALL_DLINK_FLAGS) -Wl,-melf64lriscv,--oformat=elf64-littleriscv,--no-relax > DEFINE GCC5_RISCV64_DLINK2_FLAGS = DEF(GCC5_RISCV_ALL_DLINK2_FLAGS) > DEFINE GCC5_RISCV64_ASM_FLAGS = DEF(GCC5_RISCV_ALL_ASM_FLAGS) -march=DEF(GCC5_RISCV64_ARCH) -mcmodel=medany -mabi=lp64 > -- > 2.34.1 >