Re: [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

["Sunil V L" <sunilvl@ventanamicro.com>]

On Fri, Jun 16, 2023 at 03:22:57PM +0800, Gavin Xue wrote:
> Different symbol (PROCESSOR_BIND_H__) define in RISCV64 ProcessorBinding.h
> from other CPU Arch. An unexception compilation error generated
> if include __PROCESSOR_BIND_H__ symbol in header file for
> cross-platform compiling.
> 
> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Yimin Wang <yimin.wang@intel.com>
> Cc: Alan Sheng <alan.sheng@intel.com>
> Signed-off-by: Gavin Xue <gavin.xue@intel.com>
> ---
>  MdePkg/Include/RiscV64/ProcessorBind.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/RiscV64/ProcessorBind.h b/MdePkg/Include/RiscV64/ProcessorBind.h
> index 1d42d92de4..7f24e77b8c 100644
> --- a/MdePkg/Include/RiscV64/ProcessorBind.h
> +++ b/MdePkg/Include/RiscV64/ProcessorBind.h
> @@ -2,13 +2,14 @@
>    Processor or Compiler specific defines and types for RISC-V
>  
>    Copyright (c) 2016 - 2020, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
> +  Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
>  
>    SPDX-License-Identifier: BSD-2-Clause-Patent
>  
>  **/
>  
> -#ifndef PROCESSOR_BIND_H__
> -#define PROCESSOR_BIND_H__
> +#ifndef __PROCESSOR_BIND_H__
> +#define __PROCESSOR_BIND_H__
>  
As per EDK2 coding standards, the include guard names should not
start with _. So, I guess you need to fix the header files of other
architectures which are using _ in their include guard.

Thanks,
Sunil