From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mx.groups.io with SMTP id smtpd.web10.5315.1686911763253420996 for ; Fri, 16 Jun 2023 03:36:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=fuasNb8k; spf=pass (domain: ventanamicro.com, ip: 209.85.214.178, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1b51780c1b3so4450565ad.1 for ; Fri, 16 Jun 2023 03:36:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1686911763; x=1689503763; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NUVqCrnM1Hu6csabTJw3aZGjnOIKefRF5DHLeTNu+Jw=; b=fuasNb8keROieVphub16dkT7yNw+ff4HE7yYHiuFsyJxzOB1AV2OwVYd71i/u7gOfX 5dHxOJjEQW8WiY+anBRgaRz+m/BWIi5UMKZw/Ck+QydT5VHaqlu0m7K+rO+Uj3hBOMCB 6JMWR1V2Kmjt4izH4vZK6YFvXocLpKzoM5dZqKKEBqmumdEfkpdPFqaRDTh/LOzlFy13 UQoiC+/w/9XRFabcQw5v+e+7bI6AEoMomHdns8bo4i6pQcNQi4CtnY1QbtbueNLP49O0 gVLb9FK4UJQTQWOgZeb/VcKn6BdFtMqp8TXjDxqBinR5RW/A93PLlJDx64WC/JGl9p7W Kdwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686911763; x=1689503763; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NUVqCrnM1Hu6csabTJw3aZGjnOIKefRF5DHLeTNu+Jw=; b=e94eWylnGn9gfnIAYh6UXOXou/HYOEfgX/D1ciJlCh5a8hFp7bKjVYHA7bldRlzeW9 3CxjORs72EuKsoOk5F47bQFuF1rMd7yPBDsS2IlFTR7Ccxfoevlgbb0BVr1svslTd5x9 tSv50I9/7g7wg7d9yR2wGh47z7SpA/WFPL2Bm0QM3tgvix1bvhXeWfqzYlEaB10+b1r4 NMRI0HpW53csOoufcTfAlQ5t2Mxzp6P8/GY2W6E5igPhUllvfd9iFSox+lif62gNAWQE AIZGROlbSpd3ncHyN/4YHfGTmvjKtKvVpIP8924ZDCD0RV3kbCWKiCbo/hy+zRJItqAw mQZQ== X-Gm-Message-State: AC+VfDwRdVtLLJ9LUCmgHA8D04cOSo7JSo543HEOVndRusJVD5TLdX3S bfNzkgvtSagZa37vAhL+ae/KjA== X-Google-Smtp-Source: ACHHUZ7mXN3pyIAOX/3gc+5Jnn/vI0lLSNRjnBLHoctPsf6XM1TwagGLn9SXlUMSFmQujCIy8T7/Zw== X-Received: by 2002:a17:902:7606:b0:1b2:5ef9:bbe9 with SMTP id k6-20020a170902760600b001b25ef9bbe9mr1255888pll.33.1686911762741; Fri, 16 Jun 2023 03:36:02 -0700 (PDT) Return-Path: Received: from sunil-laptop ([106.51.184.72]) by smtp.gmail.com with ESMTPSA id jo23-20020a170903055700b001b0395c4002sm15484449plb.210.2023.06.16.03.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jun 2023 03:36:02 -0700 (PDT) Date: Fri, 16 Jun 2023 16:05:57 +0530 From: "Sunil V L" To: Gavin Xue Cc: devel@edk2.groups.io, Andrei Warkentin , Yimin Wang , Alan Sheng Subject: Re: [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64 Message-ID: References: <20230616072257.1989-1-gavin.xue@intel.com> MIME-Version: 1.0 In-Reply-To: <20230616072257.1989-1-gavin.xue@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 16, 2023 at 03:22:57PM +0800, Gavin Xue wrote: > Different symbol (PROCESSOR_BIND_H__) define in RISCV64 ProcessorBinding.h > from other CPU Arch. An unexception compilation error generated > if include __PROCESSOR_BIND_H__ symbol in header file for > cross-platform compiling. > > Cc: Andrei Warkentin > Cc: Sunil V L > Cc: Yimin Wang > Cc: Alan Sheng > Signed-off-by: Gavin Xue > --- > MdePkg/Include/RiscV64/ProcessorBind.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/MdePkg/Include/RiscV64/ProcessorBind.h b/MdePkg/Include/RiscV64/ProcessorBind.h > index 1d42d92de4..7f24e77b8c 100644 > --- a/MdePkg/Include/RiscV64/ProcessorBind.h > +++ b/MdePkg/Include/RiscV64/ProcessorBind.h > @@ -2,13 +2,14 @@ > Processor or Compiler specific defines and types for RISC-V > > Copyright (c) 2016 - 2020, Hewlett Packard Enterprise Development LP. All rights reserved.
> + Copyright (c) 2023, Intel Corporation. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > > -#ifndef PROCESSOR_BIND_H__ > -#define PROCESSOR_BIND_H__ > +#ifndef __PROCESSOR_BIND_H__ > +#define __PROCESSOR_BIND_H__ > As per EDK2 coding standards, the include guard names should not start with _. So, I guess you need to fix the header files of other architectures which are using _ in their include guard. Thanks, Sunil