From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mx.groups.io with SMTP id smtpd.web10.4309.1687407791615213936 for ; Wed, 21 Jun 2023 21:23:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=CnqVsxjw; spf=pass (domain: ventanamicro.com, ip: 209.85.215.171, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-54f87d5f1abso3155826a12.0 for ; Wed, 21 Jun 2023 21:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1687407791; x=1689999791; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VRAOxKf2TEqKY6B+JPjcgpsHa2JRrjHlXJRRKmvyUHo=; b=CnqVsxjwXpgm1dh/ykr+1KAUK8cR8UxNCuEwEiUOIu2AVBtqL73EPPcbOyf7CV8ErG AsHk0mKxlYRntSt241GY6JWsjzU/lHPW97DtmpX1ESU9WhM9gq80yniZ001O25eqFzV/ RBcXvCF5r6/LTVPAy36QYUBIRlDcKfTIDR8Hjg/JSL8+QsXkh0gG3JxBNLLMbeHeq3h+ M2RE8DQf3jXCI5FKCrTyChZJzhzQ1XKKUXd1cLrlQY0nsplFBa/QAe5B+93Yn4doA+sq bLiNN+IrtnokVswQ02DhvH6oDKn3wxx/IDBZwGmfOXtXo3u5fCiJXmu+nGU1zJPpchNq Qqlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687407791; x=1689999791; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VRAOxKf2TEqKY6B+JPjcgpsHa2JRrjHlXJRRKmvyUHo=; b=iJzISSfG4dFeQ3MDHjmYOtj1utM4EVroMWWmxpQvixALpYE6IVXPF632jljAiUHVRC LmL4b+6EuvzseDlAM4OVPfR0pKUrxNBuv+iO+TRcTyxb7B41vuT07NqQaMWTqjnj3rh/ u+1n5DJkusFHGxTT4hRoena5NWdKneP3W8NzXbrsSYnUh3xmlLSraa+wcUUjKnSNxyM8 K+/fr0Tk2ApTjEV/iDqIt80kvNkneeeLXi9L77kkz6snoUWEmg4QM7Q7qAB/U9wZFq0u uCEz9DYjmcVj3w1EAPVwXQNZLtnIeak5h+g3F+txLA9knjcMXqKAwceLG2/mfqlcW3yg j2pw== X-Gm-Message-State: AC+VfDwLxC/G1rOUAhTa/6EwbKCNYPJaEshbD7zT5pjOYY3wxG8CQis1 ECYZ9CKco4OFTCD+hegqvNMCjVEZjchBpIq9FwA= X-Google-Smtp-Source: ACHHUZ5wJ8mxyDd+AsIRjoXdpXnq+S7J735vq3QtUyTDQBmFcxkYyHUEAVObYY6Lcb5/3BDQrlttAw== X-Received: by 2002:a05:6a21:339a:b0:10b:b6cf:bbb0 with SMTP id yy26-20020a056a21339a00b0010bb6cfbbb0mr12652343pzb.42.1687407790836; Wed, 21 Jun 2023 21:23:10 -0700 (PDT) Return-Path: Received: from sunil-laptop ([106.51.184.72]) by smtp.gmail.com with ESMTPSA id p9-20020a1709028a8900b001afa7040a70sm4194518plo.276.2023.06.21.21.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jun 2023 21:23:10 -0700 (PDT) Date: Thu, 22 Jun 2023 09:53:04 +0530 From: "Sunil V L" To: devel@edk2.groups.io Cc: Rebecca Cran , Liming Gao , Bob Feng , Yuwei Chen , Andrei Warkentin Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: Add "-fno-unwind-tables" to GCC5_RISCV64_CC_FLAGS Message-ID: References: <20230602170254.394449-1-sunilvl@ventanamicro.com> <176884B1D2310EB7.32355@groups.io> MIME-Version: 1.0 In-Reply-To: <176884B1D2310EB7.32355@groups.io> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Liming, Gentle ping! We need this to support gcc-13. Thanks! Sunil On Wed, Jun 14, 2023 at 05:29:12PM +0530, Sunil V L via groups.io wrote: > Hi Liming, > > Could you please help with review and merge of this patch? Do I need to > raise a BZ ticket? > > Thanks! > Sunil > On Fri, Jun 02, 2023 at 10:32:54PM +0530, Sunil V L wrote: > > gcc-13 for RISC-V enables unwind tables by default similar to ARM64. > > This generates .eh_frame_hdr section which is not handled well by > > GenFw causing failures. > > > > Disable the unwind tables by adding -fno-unwind-tables flag similar > > to [1]. > > > > [1] - https://github.com/tianocore/edk2/commit/cbf00651eda6 > > > > Signed-off-by: Sunil V L > > Cc: Rebecca Cran > > Cc: Liming Gao > > Cc: Bob Feng > > Cc: Yuwei Chen > > Cc: Andrei Warkentin > > --- > > BaseTools/Conf/tools_def.template | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > > index 92421e3d0118..90f4105506e5 100755 > > --- a/BaseTools/Conf/tools_def.template > > +++ b/BaseTools/Conf/tools_def.template > > @@ -858,7 +858,7 @@ DEFINE GCC5_RISCV_OPENSBI_TYPES = -DOPENSBI_EXTERNAL_SBI_TYPES > > > > DEFINE GCC5_RISCV64_ARCH = rv64gc > > DEFINE GCC5_RISCV32_RISCV64_ASLDLINK_FLAGS = DEF(GCC5_RISCV_ALL_DLINK_COMMON) -Wl,--entry,ReferenceAcpiTable -u ReferenceAcpiTable > > -DEFINE GCC5_RISCV64_CC_FLAGS = DEF(GCC5_RISCV_ALL_CC_FLAGS) DEF(GCC5_RISCV_ALL_CC_FLAGS_WARNING_DISABLE) DEF(GCC5_RISCV_OPENSBI_TYPES) -march=DEF(GCC5_RISCV64_ARCH) -fno-builtin -fno-builtin-memcpy -fno-stack-protector -Wno-address -fno-asynchronous-unwind-tables -Wno-unused-but-set-variable -fpack-struct=8 -mcmodel=medany -mabi=lp64 -mno-relax > > +DEFINE GCC5_RISCV64_CC_FLAGS = DEF(GCC5_RISCV_ALL_CC_FLAGS) DEF(GCC5_RISCV_ALL_CC_FLAGS_WARNING_DISABLE) DEF(GCC5_RISCV_OPENSBI_TYPES) -march=DEF(GCC5_RISCV64_ARCH) -fno-builtin -fno-builtin-memcpy -fno-stack-protector -Wno-address -fno-asynchronous-unwind-tables -fno-unwind-tables -Wno-unused-but-set-variable -fpack-struct=8 -mcmodel=medany -mabi=lp64 -mno-relax > > DEFINE GCC5_RISCV64_DLINK_FLAGS = DEF(GCC5_RISCV_ALL_DLINK_FLAGS) -Wl,-melf64lriscv,--oformat=elf64-littleriscv,--no-relax > > DEFINE GCC5_RISCV64_DLINK2_FLAGS = DEF(GCC5_RISCV_ALL_DLINK2_FLAGS) > > DEFINE GCC5_RISCV64_ASM_FLAGS = DEF(GCC5_RISCV_ALL_ASM_FLAGS) -march=DEF(GCC5_RISCV64_ARCH) -mcmodel=medany -mabi=lp64 > > -- > > 2.34.1 > > > > > > >