From: "Sunil V L" <sunilvl@ventanamicro.com>
To: Tuan Phan <tphan@ventanamicro.com>
Cc: devel@edk2.groups.io, andrei.warkentin@intel.com
Subject: Re: [PATCH] UefiCpuPkg: CpuTimerDxeRiscV64: Fix timer event not working correctly
Date: Wed, 28 Jun 2023 20:13:04 +0530 [thread overview]
Message-ID: <ZJxG+KqdxwwO5tr9@sunil-laptop> (raw)
In-Reply-To: <20230628011557.4713-1-tphan@ventanamicro.com>
On Tue, Jun 27, 2023 at 06:15:57PM -0700, Tuan Phan wrote:
> The timer notify function should be called with timer period, not the
> value read from timer register.
>
> Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
> ---
LGTM.
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Thanks!
Sunil
next prev parent reply other threads:[~2023-06-28 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 1:15 [PATCH] UefiCpuPkg: CpuTimerDxeRiscV64: Fix timer event not working correctly Tuan Phan
2023-06-28 14:43 ` Sunil V L [this message]
2023-06-28 21:06 ` Tuan Phan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJxG+KqdxwwO5tr9@sunil-laptop \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox