From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mx.groups.io with SMTP id smtpd.web10.18253.1687963390860493626 for ; Wed, 28 Jun 2023 07:43:11 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@ventanamicro.com header.s=google header.b=c+qY4xaE; spf=pass (domain: ventanamicro.com, ip: 209.85.214.181, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1b7f92b764dso21385715ad.2 for ; Wed, 28 Jun 2023 07:43:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1687963390; x=1690555390; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f5zKpJAEXJR2gV2qWWEokOC5BETe+J8riO1tGCDODN4=; b=c+qY4xaEyLKWCPknUXc1rpZq0wS/5rCwdoCXh8hUDTsUpewvvLa05pe2n/IANrJGYb 1CXGNWUC4OyRfNdrjMXC/wcR1BDOYtjixkLxX37OC3/8k/g/PK9YxsPKKO2sAarxjHg1 j+RerIdCKFGGdtyjjFeUWpd+gGfywJJtKD+j8EajCle4AgyYqpo6q+rLoWEJoltRgj5g NBF4DP/MI2rg1RkMtDNEctn1FbFJxuk4YP+C/QMqKrsGphtDECIYLyi0z8mxid4UTbVI uRQem+lZI9Fdq9niGbF+8DyIP6URUb7iGeOAM+gFJAz+SnyuveSRcOCS+r0I2WMNrfVt kPLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687963390; x=1690555390; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f5zKpJAEXJR2gV2qWWEokOC5BETe+J8riO1tGCDODN4=; b=Gj1oExYhO+pNzOTZY88PPDg11Zc/O+65mDYlREuUGlLATGJlHOkH2S+qE32H/ygUJX O+kiHPN1/94XRpm0B6sAeOni9DqsOBRtF6+4FG1IXaDppJk9DuHWNkIpJcu9+ninXoYl t4fzx/+UVZTtySbv3dTYs72oB2pw9a8oUSarFeBSY3+zPYDG1saBJ8X083D7B2O4jbMS F6jaxUWhr2W9d7tdIUbauwKha6mflEJ1KawYPrCErkb5MMEMvPVOZORe/3kh01OvaSY7 WpgaDd3UAUISSibCmmqBtP2Ol6764aKiHTGpu+S8Ft9c4tmUP04TPaAihxXrhe/kGqWF v7WA== X-Gm-Message-State: AC+VfDyeKD7tqECFE3zgcS/5ekvhnW248/bwKEsbSgddl8bdHgagz7Xg au+lhv6RIr79nNTSh1EQxaPNng== X-Google-Smtp-Source: ACHHUZ4UsLJ+hporiqyfmjFHzXNA0y4qxiRl7hc/3sNFUH2iAN7eb48KR4vToZnk2bb+aeASwkuC0Q== X-Received: by 2002:a17:902:b496:b0:1b6:ba60:77f0 with SMTP id y22-20020a170902b49600b001b6ba6077f0mr7857322plr.10.1687963390312; Wed, 28 Jun 2023 07:43:10 -0700 (PDT) Return-Path: Received: from sunil-laptop ([106.51.184.72]) by smtp.gmail.com with ESMTPSA id v1-20020a1709028d8100b001ac2c3e54adsm7811814plo.118.2023.06.28.07.43.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 07:43:09 -0700 (PDT) Date: Wed, 28 Jun 2023 20:13:04 +0530 From: "Sunil V L" To: Tuan Phan Cc: devel@edk2.groups.io, andrei.warkentin@intel.com Subject: Re: [PATCH] UefiCpuPkg: CpuTimerDxeRiscV64: Fix timer event not working correctly Message-ID: References: <20230628011557.4713-1-tphan@ventanamicro.com> MIME-Version: 1.0 In-Reply-To: <20230628011557.4713-1-tphan@ventanamicro.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 27, 2023 at 06:15:57PM -0700, Tuan Phan wrote: > The timer notify function should be called with timer period, not the > value read from timer register. > > Signed-off-by: Tuan Phan > --- LGTM. Reviewed-by: Sunil V L Thanks! Sunil