From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mx.groups.io with SMTP id smtpd.web10.52112.1688447274449235153 for ; Mon, 03 Jul 2023 22:07:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=ldaRjaBs; spf=pass (domain: ventanamicro.com, ip: 209.85.214.179, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1b89b75dc1cso9444685ad.1 for ; Mon, 03 Jul 2023 22:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1688447274; x=1691039274; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=8Wl++DQ7ZVUdqCAnAIT2/0vWR+AF54C53jXLvzcqaT4=; b=ldaRjaBsH1B3e3Bx7vjW0MIKHK0NjgDsSC3tRRIokk0IJhbXIypR1I/Hb3GyzOwttq uJfhjLg2qfuHKl8CqqQGvb6P6fzvXgo55I1YxMzuxcBp7h1vnOZ8kGfTsSX2JYw8Jtjv EZ6foSaQlzJZ4PYnZxOdeAFamc2ClfGvV+23S6ap2d+fs4PvEpxRdaRrdGR/swsbEQRw lZ7nH5Rp/xA9oeWR3ULMh/DnnvZz2hmgXiymuURACf+ULMFSUpub7TeKFMm7tw9y5gSO 5tW5UtoPT60fZejUbtxc7twyjEuOwI6yUt6B9mmTkcbZHVS1QDJovEvjRiVN7fQriEmo e7Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688447274; x=1691039274; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8Wl++DQ7ZVUdqCAnAIT2/0vWR+AF54C53jXLvzcqaT4=; b=Us/E9TB3SgCnhxSilGXmjjfzWY/dCIH/0qA66OF3sEXrRhVb1HSysVb0eb6dmmy0cE EV6UV7CUCWavJzBAou1jCZozrofFaz9djaFE5xO9Os1a3Xj/prZ/qDmF2OoD6HHCpUEw gsGRrnXzpyeTMyls59HZe+nNyhfdxVMSKWb6FRTfoXBjSI6BfoIPzlHkVV53Qe+AYQ20 l0uxbP9/GbX80BQ0iVPlkeFt9iq8n/hBYTZig3zu2ewn7PPbPi14ESMw7LzKPRYGcRBS uauZXF2P/0PWlf8xk4arDxWALnz3hDIaDyTIC+aJd8/mjdJ2sP4TcyejE7wViIJEw1qM Ed7Q== X-Gm-Message-State: ABy/qLauy4+3/qgglUhe5wJxUUrjQaxjZbgfGlXLBEf8/by95m/gPT++ Yw3305/hRwA4+HSkS2/pRyfV4A== X-Google-Smtp-Source: APBJJlElK8C7ioTjI12bC4j/7FK3F/MWRCjCIDm4CTdSmecpuULYdIveTsNE4hsJ7VAstp4Woi0ubg== X-Received: by 2002:a17:902:e743:b0:1ae:89a:a4 with SMTP id p3-20020a170902e74300b001ae089a00a4mr17634398plf.8.1688447273825; Mon, 03 Jul 2023 22:07:53 -0700 (PDT) Return-Path: Received: from sunil-laptop ([106.51.184.72]) by smtp.gmail.com with ESMTPSA id h11-20020a170902704b00b001b54a88e4a6sm16134334plt.51.2023.07.03.22.07.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 22:07:53 -0700 (PDT) Date: Tue, 4 Jul 2023 10:37:47 +0530 From: "Sunil V L" To: Tuan Phan Cc: devel@edk2.groups.io, michael.d.kinney@intel.com, gaoliming@byosoft.com.cn, zhiguang.liu@intel.com, git@danielschaefer.me, andrei.warkentin@intel.com, ardb+tianocore@kernel.org Subject: Re: [PATCH v4 5/7] OvmfPkg/RiscVVirt: Add VirtNorFlashDxe to APRIORI list Message-ID: References: <20230623183934.23905-1-tphan@ventanamicro.com> <20230623183934.23905-6-tphan@ventanamicro.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, Jun 28, 2023 at 02:27:10PM -0700, Tuan Phan wrote: > On Wed, Jun 28, 2023 at 9:47 AM Sunil V L wrote: > > > On Fri, Jun 23, 2023 at 11:39:32AM -0700, Tuan Phan wrote: > > > Make sure VirtNorFlashDxe loaded before VariableRuntimeDxe as it > > > is the backend flash driver. > > > > > > Signed-off-by: Tuan Phan > > > --- > > > OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf > > b/OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf > > > index 21e4ba67379f..9ab8eb3ba7d8 100644 > > > --- a/OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf > > > +++ b/OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf > > > @@ -53,6 +53,16 @@ READ_STATUS = TRUE > > > READ_LOCK_CAP = TRUE > > > READ_LOCK_STATUS = TRUE > > > > > > +APRIORI DXE { > > > + INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > > > + INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf > > > + INF > > MdeModulePkg/Universal/ReportStatusCodeRouter/RuntimeDxe/ReportStatusCodeRouterRuntimeDxe.inf > > > + INF > > MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerRuntimeDxe.inf > > > + INF EmbeddedPkg/Drivers/FdtClientDxe/FdtClientDxe.inf > > > + INF UefiCpuPkg/CpuDxeRiscV64/CpuDxeRiscV64.inf > > > + INF OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.inf > > > +} > > > + > > Hi Tuan, > > > > Actually, Ard had recommended not to use APRIORI and hence we avoided > > it when we upstreamed RiscVVirt. So, I am wondering whether this can be > > avoided by using depex in CpuDxe on gEfiVariableArchProtocolGuid? > > > > Hi Sunil, > Not sure what the reason behind avoiding APRIORI besides it is a workaround > for broken DEPEX. BTW, what we need is to put VirtNorFlashDxe loaded before > VariableRuntimeDxe which doesn't depend on any modules. I don't see any > other clearer way than modifying VirNorFlashDxe as shown in the first > version of this series. > > The CpuDxeRiscV64 in the aprioriy list as VirNorFlashDxe depends on it. > Hi Tuan, I couldn't locate old mail from Ard recommending to remove APRIORI in RISC-V. But here is the recent mail on different context but those reasons are still valid in any case. https://edk2.groups.io/g/devel/message/104543 IMO, there is no dependency between VirtNorFlashDxe and VariableRuntimeDxe. I think what we need is CpuDxeRiscV64 loaded after VariableRuntimeDxe and before VirtNorFlashDxe. A simple depex like I suggested in previous mail should work. I still prefer this than introducing APRIORI unless there are other issues I am now aware of. What do you think? Thanks! Sunil