public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sunil V L" <sunilvl@ventanamicro.com>
To: Tuan Phan <tphan@ventanamicro.com>
Cc: andrei.warkentin@intel.com, ardb+tianocore@kernel.org,
	devel@edk2.groups.io, gaoliming@byosoft.com.cn,
	git@danielschaefer.me, michael.d.kinney@intel.com,
	zhiguang.liu@intel.com
Subject: Re: [PATCH v4 5/7] OvmfPkg/RiscVVirt: Add VirtNorFlashDxe to APRIORI list
Date: Fri, 14 Jul 2023 09:49:12 +0530	[thread overview]
Message-ID: <ZLDMwEUKEvpWPRQL@sunil-laptop> (raw)
In-Reply-To: <CABYABGRs6WbNB631kFu6nfCDMX7Rh0RzKYQCKm+V5+992do4Dg@mail.gmail.com>

On Thu, Jul 13, 2023 at 12:08:02PM -0700, Tuan Phan wrote:
> On Tue, Jul 4, 2023 at 12:01 AM Sunil V L <sunilvl@ventanamicro.com> wrote:
> 
> > On Mon, Jul 03, 2023 at 11:45:45PM -0700, Tuan Phan wrote:
> > > As i said, VirtNorFlashDxe needed to be loaded before VariableRuntimeDxe
> > so
> > > your suggestion will not work.
> > >
> > Okay, at least for me, by removing APRIORI patch and adding this depex,
> > edk2 boots fine with your series. I am not sure what won't work.
> >
> > Hi Ard, any thoughts? If no better way, may be we have to use APRIORI.
> >
> It doesn't work as your workaround trying to make CpuDxe depends on
> variable protocol which has nothing to do with it. Also, CpuDxe is an
> essential module and should not depend on anything, what happens if the
> variable driver before generating the protocol tries to use CPU protocol?
> It is worse than having APRIORI workaround.
> 
Okay. Thanks!. Let's go with this solution for now.  But let me do some
tests to ensure this builds fine with CLANG and then merge.

Thanks,
Sunil

  reply	other threads:[~2023-07-14  4:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-23 18:39 [PATCH v4 0/7] RISC-V: Add MMU support Tuan Phan
2023-06-23 18:39 ` [PATCH v4 1/7] MdePkg/BaseLib: RISC-V: Support getting satp register value Tuan Phan
2023-06-23 18:39 ` [PATCH v4 2/7] MdePkg/Register: RISC-V: Add satp mode bits shift definition Tuan Phan
2023-06-27 20:10   ` Michael D Kinney
2023-06-23 18:39 ` [PATCH v4 3/7] OvmfPkg/RiscVVirt: VirtNorFlashPlatformLib: Fix wrong flash size Tuan Phan
2023-06-23 18:39 ` [PATCH v4 4/7] OvmfPkg/RiscVVirt: SEC: Add IO memory resource hob for platform devices Tuan Phan
2023-06-23 18:39 ` [PATCH v4 5/7] OvmfPkg/RiscVVirt: Add VirtNorFlashDxe to APRIORI list Tuan Phan
2023-06-28 16:47   ` Sunil V L
2023-06-28 21:27     ` Tuan Phan
2023-07-04  5:07       ` Sunil V L
2023-07-04  6:45         ` Tuan Phan
2023-07-04  7:01           ` Sunil V L
2023-07-13 19:08             ` Tuan Phan
2023-07-14  4:19               ` Sunil V L [this message]
2023-06-23 18:39 ` [PATCH v4 6/7] OvmfPkg: RiscVVirt: Remove satp bare mode setting Tuan Phan
2023-06-23 18:39 ` [PATCH v4 7/7] UefiCpuPkg: RISC-V: Support MMU with SV39/48/57 mode Tuan Phan
2023-07-14 10:24   ` Sunil V L
2023-07-14 19:10     ` Tuan Phan
2023-06-25  8:45 ` [edk2-devel] UsbNetworkPkg not find in UDK 202305 stable version Yoshinoya
2023-07-15  5:21 ` [PATCH v4 0/7] RISC-V: Add MMU support Sunil V L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLDMwEUKEvpWPRQL@sunil-laptop \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox