From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mx.groups.io with SMTP id smtpd.web11.11474.1689308360104562829 for ; Thu, 13 Jul 2023 21:19:20 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@ventanamicro.com header.s=google header.b=D/bsXlps; spf=pass (domain: ventanamicro.com, ip: 209.85.210.171, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-666e6541c98so1442470b3a.2 for ; Thu, 13 Jul 2023 21:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1689308359; x=1691900359; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=I1a8z3kvbPdpC6u7/tLgSe+Iv0ESJ/9UNv/5N4RBGVc=; b=D/bsXlpsGDY3zrrn9o5zb4BCQ9sV8CjemHirfElBqDUl35fzxvxvA+a90AlXXuUTR3 HjqKNN7UkM+tfofzEp4vMyNnHcLMWP6AnBR8eQcmle75OEzXTWlsRII2cCQClT4w5IaO OiF4MHzpRsbOj5Bn/ZKWtvUdfV8njnp3x3HQVfzqdTC0z4E/EjGL5fyQqRfyiP6z1pXy FYQ6sCS3zvqlC69yM30e7ksYV9RES7jKbfu2lw9RO5OUarLdH2fDgd9fuA8Z9f3cPVYR eMfN0+VYdzr+HT9ejFKJ5N1N7863v1JXfDXqmwcxiZTt70pnOENUvENBlMWL4quDSgXO q5+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689308359; x=1691900359; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I1a8z3kvbPdpC6u7/tLgSe+Iv0ESJ/9UNv/5N4RBGVc=; b=b1MxCJ/nfg1Ca7z4WpTDgUGS4VTIbyaPHuoDTXKIY9jO9xvgcQfcpZXtj9lpa9TMI3 a2NWVCxQzjwfbJSJw/Agi95MJzqBBzFHqym0fJEQfWljtX71mk2o2kT3cshhWzL8Iu+O MfPQ7mAz8LFNzl8xWNO6JdQZvfxfdGN2Nrgkd3D1e0pkzs18IcSu1kfny6Nk8ywanBgd /AlmdI7+0GCxjVuDBwXwFhqSBxhGOSrO5mR+JuDneR+xWVi0Hyunom+trWVJdtrQk24n knr1GBewNBILQ/rmKoekkZ+pwMK9ga5Ww8NKNtdR/NlQY4di9EA2eLcmvom+UOD9tWc9 KpFA== X-Gm-Message-State: ABy/qLZ0okLnP+tlj/RDp6K/d3VW8h9pb3FRd+4aQdqJ9LGjWqedS65A 2aZ66gZg4Bjvln2vQxvsbSc1vA== X-Google-Smtp-Source: APBJJlEI9lsSR73oEY9l1x78Rz31O83bB/+FpMbAsB0eJq64hggVtVWNbpPGkXKbo7sw6FA4BHRBkw== X-Received: by 2002:a05:6a20:e685:b0:133:bbe0:312f with SMTP id mz5-20020a056a20e68500b00133bbe0312fmr605553pzb.50.1689308359631; Thu, 13 Jul 2023 21:19:19 -0700 (PDT) Return-Path: Received: from sunil-laptop ([106.51.190.25]) by smtp.gmail.com with ESMTPSA id t19-20020a62ea13000000b006732786b5f1sm6154742pfh.213.2023.07.13.21.19.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jul 2023 21:19:19 -0700 (PDT) Date: Fri, 14 Jul 2023 09:49:12 +0530 From: "Sunil V L" To: Tuan Phan Cc: andrei.warkentin@intel.com, ardb+tianocore@kernel.org, devel@edk2.groups.io, gaoliming@byosoft.com.cn, git@danielschaefer.me, michael.d.kinney@intel.com, zhiguang.liu@intel.com Subject: Re: [PATCH v4 5/7] OvmfPkg/RiscVVirt: Add VirtNorFlashDxe to APRIORI list Message-ID: References: <20230623183934.23905-1-tphan@ventanamicro.com> <20230623183934.23905-6-tphan@ventanamicro.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Jul 13, 2023 at 12:08:02PM -0700, Tuan Phan wrote: > On Tue, Jul 4, 2023 at 12:01 AM Sunil V L wrote: > > > On Mon, Jul 03, 2023 at 11:45:45PM -0700, Tuan Phan wrote: > > > As i said, VirtNorFlashDxe needed to be loaded before VariableRuntimeDxe > > so > > > your suggestion will not work. > > > > > Okay, at least for me, by removing APRIORI patch and adding this depex, > > edk2 boots fine with your series. I am not sure what won't work. > > > > Hi Ard, any thoughts? If no better way, may be we have to use APRIORI. > > > It doesn't work as your workaround trying to make CpuDxe depends on > variable protocol which has nothing to do with it. Also, CpuDxe is an > essential module and should not depend on anything, what happens if the > variable driver before generating the protocol tries to use CPU protocol? > It is worse than having APRIORI workaround. > Okay. Thanks!. Let's go with this solution for now. But let me do some tests to ensure this builds fine with CLANG and then merge. Thanks, Sunil