public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Cc: <devel@edk2.groups.io>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Graeme Gregory <graeme@xora.org.uk>
Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/QemuSbsa: enlarge firmware offsets
Date: Thu, 17 Aug 2023 11:12:00 +0100	[thread overview]
Message-ID: <ZN3ycFUGqbEClEGv@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <20230816163333.76959-2-marcin.juszkiewicz@linaro.org>

On Wed, Aug 16, 2023 at 18:33:33 +0200, Marcin Juszkiewicz wrote:
> GenFv: ERROR 3000: Invalid
>   the required fv image size 0x216510 exceeds the set fv image size 0x200000
> 
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>

Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

Presumably caused by the openssl3 shenanigans. But regardless, this
was an arbitrarily low size to begin with.

Pushed as 0f0cafb5defb. Thanks!

/
    Leif

> ---
>  Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
> index 677cea6344dc..bc432cac6fc8 100644
> --- a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
> +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
> @@ -58,20 +58,20 @@ [FD.SBSA_FLASH0]
>  
>  [FD.SBSA_FLASH1]
>  BaseAddress   = 0x10000000|gArmTokenSpaceGuid.PcdFdBaseAddress
> -Size          = 0x002C0000|gArmTokenSpaceGuid.PcdFdSize
> +Size          = 0x003C0000|gArmTokenSpaceGuid.PcdFdSize
>  ErasePolarity = 1
>  BlockSize     = 0x00001000
> -NumBlocks     = 0x2C0
> +NumBlocks     = 0x3C0
>  
>  ## Place for EFI (BL33)
>  # This offset (if any as it is 0x0 currently) + BaseAddress (0x10000000) must be set in PRELOADED_BL33_BASE at ATF
> -0x00000000|0x00200000
> +0x00000000|0x00300000
>  gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize
>  FV = FVMAIN_COMPACT
>  
>  ## Place for Variables. They share flash1 with EFI
>  # Must be aligned to Flash Block size 0x40000
> -0x00200000|0x00040000
> +0x00300000|0x00040000
>  gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize
>  #NV_VARIABLE_STORE
>  DATA = {
> @@ -109,7 +109,7 @@ [FD.SBSA_FLASH1]
>    0x5A, 0xFE, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
>  }
>  
> -0x00240000|0x00040000
> +0x00340000|0x00040000
>  gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize
>  #NV_FTW_WORKING
>  DATA = {
> @@ -123,7 +123,7 @@ [FD.SBSA_FLASH1]
>    0xE0, 0xFF, 0x03, 0x00, 0x00, 0x00, 0x00, 0x00
>  }
>  
> -0x00280000|0x00040000
> +0x00380000|0x00040000
>  gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize
>  #NV_FTW_SPARE
>  
> -- 
> 2.41.0
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107827): https://edk2.groups.io/g/devel/message/107827
Mute This Topic: https://groups.io/mt/100783095/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      reply	other threads:[~2023-08-17 10:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16 16:33 [edk2-devel] [PATCH edk2-platforms 0/1] Enlarge firmware offsets Marcin Juszkiewicz
2023-08-16 16:33 ` [edk2-devel] [PATCH edk2-platforms 1/1] Platform/QemuSbsa: enlarge " Marcin Juszkiewicz
2023-08-17 10:12   ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZN3ycFUGqbEClEGv@qc-i7.hemma.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox