Re: [edk2-devel] [PATCH 1/1] OvmfPkg:Fix Hii form name mismatch with EFI variable

["Sunil V L" <sunilvl@ventanamicro.com>]

Hi Wang,

Thanks for the patch!

It will be good if you add versions to the patch subject. Even if you
go back to v1, better to send as v3 with the change log.

On Fri, Jul 14, 2023 at 04:59:48PM +0800, Wang, Yin wrote:
> Onemore need change beside fixs:16acacf24c ("OvmfPkg: fix PlatformConfig")
fixs -> Fixes? Why don't we need "Fixes:" tag to either aefcc91805fd or
16acacf24c2c?

I think it is better to have commit message with exact error or
information on what is the issue instead of just pointing to another
commit.

> Find by sct case:ExtractConfigConformance fail.
> 

> Signed-off-by: Yin Wang <yin.wang@intel.com>
> ---
>  OvmfPkg/PlatformDxe/Platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/PlatformDxe/Platform.c b/OvmfPkg/PlatformDxe/Platform.c
> index cd3bfd554c98..c32439683d83 100644
> --- a/OvmfPkg/PlatformDxe/Platform.c
> +++ b/OvmfPkg/PlatformDxe/Platform.c
> @@ -279,7 +279,7 @@ ExtractConfig (
>      //
>      ConfigRequestHdr = HiiConstructConfigHdr (
>                           &gOvmfPlatformConfigGuid,
> -                         mVariableName,
> +                         mHiiFormName,
>                           mImageHandle
The code change LGTM.

Acked-by: Sunil V L <sunilvl@ventanamicro.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107618): https://edk2.groups.io/g/devel/message/107618
Mute This Topic: https://groups.io/mt/100142143/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-