From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BDACC7803CD for ; Mon, 7 Aug 2023 12:02:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=fM8s2nit9c2yU3mDCpbP9uqIU+Fl54D/5qSzX8ZyG2I=; c=relaxed/simple; d=groups.io; h=Date:From:To:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1691409733; v=1; b=FaKZr1/VHSd/sgo3z7WQc5GpXyRKwUu0rDCJRqZKrSEpAlrmmAz/PfL4BuWCqaE05jIRM6jG 0iEpupzqEitNErWVox2LFJS4YidH4mOBiFZ4KN8W5awAC5VZLN+9F7RTFVpfdiorKQZiBJLnr65 z17pzFhQCeOgWBMokzNhVMFc= X-Received: by 127.0.0.2 with SMTP id EKQvYY7687511xZyFEAb2A0t; Mon, 07 Aug 2023 05:02:13 -0700 X-Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mx.groups.io with SMTP id smtpd.web11.32638.1691409732931124758 for ; Mon, 07 Aug 2023 05:02:13 -0700 X-Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1bb775625e2so29453995ad.1 for ; Mon, 07 Aug 2023 05:02:12 -0700 (PDT) X-Gm-Message-State: Ej4K7cyuVEB7MyrQzr6GrsfDx7686176AA= X-Google-Smtp-Source: AGHT+IEhXvjVPxVqoovme0nPKeX82TtxGqKxQAgSNbSYdxUN3BH9bOQ+u9thmrTRk2p6JYo5tuahaA== X-Received: by 2002:a17:902:f693:b0:1b5:674d:2aa5 with SMTP id l19-20020a170902f69300b001b5674d2aa5mr9010582plg.13.1691409732175; Mon, 07 Aug 2023 05:02:12 -0700 (PDT) X-Received: from sunil-laptop ([106.51.190.143]) by smtp.gmail.com with ESMTPSA id q10-20020a17090311ca00b001bbdd44bbb6sm6711076plh.136.2023.08.07.05.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 05:02:11 -0700 (PDT) Date: Mon, 7 Aug 2023 17:32:07 +0530 From: "Sunil V L" To: devel@edk2.groups.io, yin.wang@intel.com Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg:Fix Hii form name mismatch with EFI variable Message-ID: References: MIME-Version: 1.0 In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="FaKZr1/V"; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Wang, Thanks for the patch! It will be good if you add versions to the patch subject. Even if you go back to v1, better to send as v3 with the change log. On Fri, Jul 14, 2023 at 04:59:48PM +0800, Wang, Yin wrote: > Onemore need change beside fixs:16acacf24c ("OvmfPkg: fix PlatformConfig") fixs -> Fixes? Why don't we need "Fixes:" tag to either aefcc91805fd or 16acacf24c2c? I think it is better to have commit message with exact error or information on what is the issue instead of just pointing to another commit. > Find by sct case:ExtractConfigConformance fail. > > Signed-off-by: Yin Wang > --- > OvmfPkg/PlatformDxe/Platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/PlatformDxe/Platform.c b/OvmfPkg/PlatformDxe/Platform.c > index cd3bfd554c98..c32439683d83 100644 > --- a/OvmfPkg/PlatformDxe/Platform.c > +++ b/OvmfPkg/PlatformDxe/Platform.c > @@ -279,7 +279,7 @@ ExtractConfig ( > // > ConfigRequestHdr = HiiConstructConfigHdr ( > &gOvmfPlatformConfigGuid, > - mVariableName, > + mHiiFormName, > mImageHandle The code change LGTM. Acked-by: Sunil V L -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107618): https://edk2.groups.io/g/devel/message/107618 Mute This Topic: https://groups.io/mt/100142143/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-