From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7B955D80CA2 for ; Wed, 16 Aug 2023 09:03:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Hd4PTbucRWJwO0SqLePwVFqw6oI78Q9542aaEyl9y68=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1692176587; v=1; b=VMsqWmOUTd1WqSCs6fZ3Cgx3g3iUDntg9Gnqv0FukImT4OJqkNWNFBQQsOdW+MlOmR03zL0a RKo5RgQ4uOYbCmX9CIil1HHrSLvPF6avDisFex3jERMagC/vAe4BViox0B/yXenm+EfD6MfnvtA HOD7JKip5MVhvWvuacmghfNc= X-Received: by 127.0.0.2 with SMTP id KHqQYY7687511xlZ8U97XsSw; Wed, 16 Aug 2023 02:03:07 -0700 X-Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by mx.groups.io with SMTP id smtpd.web10.156909.1692176587265484873 for ; Wed, 16 Aug 2023 02:03:07 -0700 X-Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-6bd0a96e63dso5431878a34.2 for ; Wed, 16 Aug 2023 02:03:07 -0700 (PDT) X-Gm-Message-State: TaTZOv6C26McWe8TMzcDulRMx7686176AA= X-Google-Smtp-Source: AGHT+IH5u/K7WKu1n/LsppvwPf2DaMY9nsPbWEJPxEgfzSgZfb4bJTc9cy/Hl1tpt5AGDGTTgchceQ== X-Received: by 2002:a05:6830:1bf8:b0:6bd:708:c1f2 with SMTP id k24-20020a0568301bf800b006bd0708c1f2mr1148389otb.14.1692176586423; Wed, 16 Aug 2023 02:03:06 -0700 (PDT) X-Received: from sunil-laptop ([106.51.191.205]) by smtp.gmail.com with ESMTPSA id r5-20020a63b105000000b005652a4bc5f5sm2451209pgf.90.2023.08.16.02.03.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Aug 2023 02:03:06 -0700 (PDT) Date: Wed, 16 Aug 2023 14:33:00 +0530 From: "Sunil V L" To: "Li, Yong" Cc: "devel@edk2.groups.io" , "2931013282@sjtu.edu.cn" <2931013282@sjtu.edu.cn>, "Warkentin, Andrei" Subject: Re: [edk2-devel] [PATCH] OvmfPkg/RiscVVirt: Fix issues in VarStore Blockmap config Message-ID: References: <2c7b82749a9aff01393b230e216c5e5aee675dd1.1691750977.git.2931013282@sjtu.edu.cn> MIME-Version: 1.0 In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=VMsqWmOU; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none On Wed, Aug 16, 2023 at 07:08:58AM +0000, Li, Yong wrote: > Hi Sunil, > > Qingyu is from Penglai team, when we were working together in enabling StandaloneMm variable service, > we found an issue in OvmfPkg/RiscVVirt/VarStore.fdf.inc, in which the blockmap config is not aligned with the value in > OvmfPkg/RiscVVirt/Library/VirtNorFlashPlatformLib/VirtNorFlashStaticLib.c, which is SIZE_256KB > > That mis-alignment won't cause any issue if the variable size is small and less than 0x1000, but if store more data in the flash device then it will cause data loss issue during reboot. > Once reboot if any FV header data is corrupted it will result the whole variable system be re-initialized. > > Please help review the patch and give the comments, thanks > Hi Yong Li, Thank you very much for providing the context. Sorry, I actually had missed this. Hi Quingyu Shang, The patch LGTM. Thanks a lot for finding the issue and fixing it. In future, could you please run BaseTools/Scripts/GetMaintainer.py on the patches and CC all the people it lists using "Cc:" tag? Reviewed-by: Sunil V L Thanks! Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107794): https://edk2.groups.io/g/devel/message/107794 Mute This Topic: https://groups.io/mt/100684601/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-