From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: <devel@edk2.groups.io>, <ardb@kernel.org>
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: Re: [edk2-devel] [PATCH 1/1] ArmPkg/SmbiosMiscDxe: use UINT64 for BiosPhysicalSize
Date: Wed, 30 Aug 2023 22:15:14 +0100 [thread overview]
Message-ID: <ZO+xYpzxpYH4CPVK@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <CAMj1kXEsF0pVA2x9=3TetyGFe_H8cSBzvo8p6gJaaOiW71OG9A@mail.gmail.com>
On Wed, Aug 30, 2023 at 14:50:33 +0200, Ard Biesheuvel wrote:
> On Wed, 30 Aug 2023 at 13:39, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
> >
> > The top two bits of the Extended BIOS ROM Size field indicates the unit
> > used for the remaining 14 bits. If the size is greater than 16GB, the
> > unit is gigabytes.
> > The test for this uses the local BiosPhysicalSize variable, which is a
> > UINTN, meaning that when building for a 32/bit architecture (ARM) with
> > CLANGDWARF we have a tautological constant comparison, which the toolchain
> > flags now we've stopped disabling that warning.
> > So switch the BiosPhysicalSize variable to UINT64.
> >
> > Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Rebecca Cran <rebecca@bsdio.com>
>
> Reviewed-by: Ard BIesheuvel <ardb@kernel.org>
Thanks!
Pushed as c5753c3e38f3.
/
Leif
> > ---
> >
> > Ultimately, the size is still restricted to 32-bit since it is set
> > directly from a PcdGet32 (PcdFvSize). This should ideally be broken
> > out into an OemMiscLib function since PcdFvSize is fundamentally an
> > ArmPkg concept.
> >
> > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c
> > index 38f3864b160e..03f9f07cfa29 100644
> > --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c
> > +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c
> > @@ -185,7 +185,7 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor) {
> > UINTN VendorStrLen;
> > UINTN VerStrLen;
> > UINTN DateStrLen;
> > - UINTN BiosPhysicalSize;
> > + UINT64 BiosPhysicalSize;
> > CHAR16 *Vendor;
> > CHAR16 *Version;
> > CHAR16 *ReleaseDate;
> > --
> > 2.30.2
> >
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108153): https://edk2.groups.io/g/devel/message/108153
Mute This Topic: https://groups.io/mt/101050018/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-08-30 21:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 11:39 [edk2-devel] [PATCH 1/1] ArmPkg/SmbiosMiscDxe: use UINT64 for BiosPhysicalSize Leif Lindholm
2023-08-30 12:50 ` Ard Biesheuvel
2023-08-30 21:15 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO+xYpzxpYH4CPVK@qc-i7.hemma.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox