From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5E4379412EE for ; Tue, 29 Aug 2023 12:25:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=B7U8zHdrGRKVuJG+rQEgUDnRTDVu78FvGzgeSsPliu0=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1693311958; v=1; b=v+XDMsDfHFukNITr6mXXNSJsiwU35qtXDWx5AZMwcN27LhEknOQP9e79zeHVn7oQMNiP4D73 D0pBb2HRhAHPv4Nr8NKcvXA/HGrmyOYKFPCLFwgUuWlJhGgnHKMzq4N2Wyn2+lQ7Staqw9oISw4 wLvpKzN8yKisVXNQY5gKV3zs= X-Received: by 127.0.0.2 with SMTP id uDOOYY7687511xRZ9IyZcoKz; Tue, 29 Aug 2023 05:25:58 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.16056.1693311957223785643 for ; Tue, 29 Aug 2023 05:25:57 -0700 X-Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37TBvEjw008190; Tue, 29 Aug 2023 12:25:45 GMT X-Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ss4wq1d02-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Aug 2023 12:25:45 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 37TCPiVu029818 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Aug 2023 12:25:44 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Tue, 29 Aug 2023 05:25:42 -0700 Date: Tue, 29 Aug 2023 13:25:38 +0100 From: "Leif Lindholm" To: Rebecca Cran CC: , 'Ajay Iyengar ' , gaoliming , 'Bob Feng' , 'Yuwei Chen' , Ard Biesheuvel Subject: Re: [edk2-devel] [RFC PATCH 1/1] BaseTools: drop tautological warning overrides for CLANGDWARF Message-ID: References: <20230823151522.168518-1-quic_llindhol@quicinc.com> <819fcd52-ee34-4a86-88d3-d9a2db69651c@app.fastmail.com> MIME-Version: 1.0 In-Reply-To: <819fcd52-ee34-4a86-88d3-d9a2db69651c@app.fastmail.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: 6NJqH9rsZqM2DuvHeGPSQI1hJN1Gm8Vt X-Proofpoint-ORIG-GUID: 6NJqH9rsZqM2DuvHeGPSQI1hJN1Gm8Vt Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: uAAb1s9iFJUHDDD1KP9ZNfKbx7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=v+XDMsDf; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks all - merged as 14bf2cb411ca. On Wed, Aug 23, 2023 at 11:21:02 -0600, Rebecca Cran wrote: > Reviewed-by: Rebecca Cran > > On Wed, Aug 23, 2023, at 9:15 AM, Leif Lindholm wrote: > > The CLANGDWARF progfile sets both -Wno-tautological-compare and > > -Wno-tautological-constant-out-of-range-compare, but this prevents > > compile-time detection of certain errors. > > Drop these flags. > > > > Signed-off-by: Leif Lindholm > > Cc: Rebecca Cran > > Cc: Liming Gao > > Cc: Bob Feng > > Cc: Yuwei Chen > > Cc: Ard Biesheuvel > > --- > > > > Does anyone remember why these were added? > > I'm not running into any issues across armvirtqemu, qemusbsa, ovmfx64, > > ovmfriscv64. > > > > / > > Leif > > > > BaseTools/Conf/tools_def.template | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/BaseTools/Conf/tools_def.template > > b/BaseTools/Conf/tools_def.template > > index 1bf62362b611..5bd5283655ea 100755 > > --- a/BaseTools/Conf/tools_def.template > > +++ b/BaseTools/Conf/tools_def.template > > @@ -1859,7 +1859,7 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS = > > -Wl,--defsym=PECOFF_HEADER_SIZE=0x22 > > DEFINE CLANGDWARF_IA32_TARGET = -target i686-pc-linux-gnu > > DEFINE CLANGDWARF_X64_TARGET = -target x86_64-pc-linux-gnu > > > > -DEFINE CLANGDWARF_WARNING_OVERRIDES = -Wno-parentheses-equality > > -Wno-tautological-compare > > -Wno-tautological-constant-out-of-range-compare -Wno-empty-body > > -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-option > > -Wno-unused-but-set-variable -Wno-unused-const-variable > > -Wno-unaligned-access -Wno-unneeded-internal-declaration > > +DEFINE CLANGDWARF_WARNING_OVERRIDES = -Wno-parentheses-equality > > -Wno-empty-body -Wno-unused-const-variable -Wno-varargs > > -Wno-unknown-warning-option -Wno-unused-but-set-variable > > -Wno-unused-const-variable -Wno-unaligned-access > > -Wno-unneeded-internal-declaration > > DEFINE CLANGDWARF_ALL_CC_FLAGS = DEF(GCC48_ALL_CC_FLAGS) > > DEF(CLANGDWARF_WARNING_OVERRIDES) -fno-stack-protector -mms-bitfields > > -Wno-address -Wno-shift-negative-value -Wno-unknown-pragmas > > -Wno-incompatible-library-redeclaration -fno-asynchronous-unwind-tables > > -mno-sse -mno-mmx -msoft-float -mno-implicit-float > > -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang > > -funsigned-char -fno-ms-extensions -Wno-null-dereference > > > > ########################### > > -- > > 2.39.2 > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108091): https://edk2.groups.io/g/devel/message/108091 Mute This Topic: https://groups.io/mt/100916818/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-