Re: [edk2-devel] [PATCH edk2-platforms v4 2/3] Platform/QemuSbsa: add dynamic PcdSmmuBase

["Leif Lindholm" <quic_llindhol@quicinc.com>]

On Mon, Aug 21, 2023 at 17:07:56 +0200, Marcin Juszkiewicz wrote:
> Store Smmu base address in variable in case it would be needed

A Pcd is not a variable. s/variable/DynamicPcd/.

And we don't change things "in case we might need them", we change
them for some reason.

Overall, I think this change would be better smashed into a patch that
actually uses it.

/
    Leif

> in more than one place.
> 
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> ---
>  Silicon/Qemu/SbsaQemu/SbsaQemu.dec  | 1 +
>  Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/Silicon/Qemu/SbsaQemu/SbsaQemu.dec b/Silicon/Qemu/SbsaQemu/SbsaQemu.dec
> index ff2a4721a131..aab2894e6455 100644
> --- a/Silicon/Qemu/SbsaQemu/SbsaQemu.dec
> +++ b/Silicon/Qemu/SbsaQemu/SbsaQemu.dec
> @@ -73,3 +73,4 @@ [PcdsDynamic.common]
>  
>    # ARM Generic Interrupt Controller ITS
>    gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdGicItsBase|0|UINT64|0x00000120
> +  gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdSmmuBase|0|UINT64|0x00000121
> diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> index 4ae2479628b6..be406144c242 100644
> --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> @@ -525,6 +525,7 @@ [PcdsDynamicDefault.common]
>  
>    # GIC ITS
>    gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdGicItsBase|0
> +  gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdSmmuBase|0x60050000
>  
>    #
>    # Set video resolution for boot options
> -- 
> 2.41.0
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107932): https://edk2.groups.io/g/devel/message/107932
Mute This Topic: https://groups.io/mt/100874754/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-