From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B81D4D80733 for ; Mon, 21 Aug 2023 18:06:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QDrhItWUUJE78NGV7pkTeFzMvhnzyVdTdNatCHC+dfY=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1692641187; v=1; b=wCpUuSy8FfT8DTEbgzEwzAZAdgfuPY5A6IAa+L/Ce9NPZAoUh78tclP+jPVm7qr2sUbgv57/ a/JbUmegppdfJs37qEewPw52QVqeTNiEKy4E/ru0bRkttQ8DmK4ywYaWO20m1qpWPJj/SIMePCP XClZcDmYnfar+/jr3Rc/C14Y= X-Received: by 127.0.0.2 with SMTP id M6AUYY7687511xql7Apj8Az3; Mon, 21 Aug 2023 11:06:27 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.245.1692641186735269046 for ; Mon, 21 Aug 2023 11:06:26 -0700 X-Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37LHL2EP005100; Mon, 21 Aug 2023 18:06:26 GMT X-Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3sjken4u07-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Aug 2023 18:06:26 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 37LI6P0B022289 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Aug 2023 18:06:25 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Mon, 21 Aug 2023 11:06:23 -0700 Date: Mon, 21 Aug 2023 19:06:20 +0100 From: "Leif Lindholm" To: Marcin Juszkiewicz CC: , Ard Biesheuvel , Graeme Gregory Subject: Re: [edk2-devel] [PATCH edk2-platforms v4 2/3] Platform/QemuSbsa: add dynamic PcdSmmuBase Message-ID: References: <20230821150757.128280-1-marcin.juszkiewicz@linaro.org> <20230821150757.128280-3-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 In-Reply-To: <20230821150757.128280-3-marcin.juszkiewicz@linaro.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: r1Oao79BGjZT8-k7jug_tc4saX9m09vh X-Proofpoint-GUID: r1Oao79BGjZT8-k7jug_tc4saX9m09vh Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OfZ6hgfKh3JaRmzCAADGefbJx7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=wCpUuSy8; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none) On Mon, Aug 21, 2023 at 17:07:56 +0200, Marcin Juszkiewicz wrote: > Store Smmu base address in variable in case it would be needed A Pcd is not a variable. s/variable/DynamicPcd/. And we don't change things "in case we might need them", we change them for some reason. Overall, I think this change would be better smashed into a patch that actually uses it. / Leif > in more than one place. > > Signed-off-by: Marcin Juszkiewicz > --- > Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 1 + > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Silicon/Qemu/SbsaQemu/SbsaQemu.dec b/Silicon/Qemu/SbsaQemu/SbsaQemu.dec > index ff2a4721a131..aab2894e6455 100644 > --- a/Silicon/Qemu/SbsaQemu/SbsaQemu.dec > +++ b/Silicon/Qemu/SbsaQemu/SbsaQemu.dec > @@ -73,3 +73,4 @@ [PcdsDynamic.common] > > # ARM Generic Interrupt Controller ITS > gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdGicItsBase|0|UINT64|0x00000120 > + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdSmmuBase|0|UINT64|0x00000121 > diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc > index 4ae2479628b6..be406144c242 100644 > --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc > +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc > @@ -525,6 +525,7 @@ [PcdsDynamicDefault.common] > > # GIC ITS > gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdGicItsBase|0 > + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdSmmuBase|0x60050000 > > # > # Set video resolution for boot options > -- > 2.41.0 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107932): https://edk2.groups.io/g/devel/message/107932 Mute This Topic: https://groups.io/mt/100874754/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-