From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 17DF1740035 for ; Tue, 22 Aug 2023 06:26:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5TykdwxzLS2epcwKddLYgDxuWix/AG9gRCHeNa2QV8U=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1692685593; v=1; b=ZLm9UcGCdRfmdl3rxOLvEHOOUR5u7alyO1VFqYPcx8pJ4TG1q9oKVDo3c+uiAhqs7090HGq5 XWVMSg3Skkq27kORp3kFmGsJhuKegRnBf2e3pfAPtcLtk4hDLykafNvxUAOc2Zdws8MmtOXoY/R 5ky+TlTHgTt5IeSWoOM+f2D0= X-Received: by 127.0.0.2 with SMTP id rzE5YY7687511xTxr3AOFDAy; Mon, 21 Aug 2023 23:26:33 -0700 X-Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mx.groups.io with SMTP id smtpd.web10.2592.1692685592580886200 for ; Mon, 21 Aug 2023 23:26:32 -0700 X-Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1bdf98a6086so32538325ad.0 for ; Mon, 21 Aug 2023 23:26:32 -0700 (PDT) X-Gm-Message-State: VEhrRixXl8sjOLVDguGjaiXrx7686176AA= X-Google-Smtp-Source: AGHT+IEYzpMdZ4Aoidn7qnZO7k8kg295PS6eh4DE9VL4QTRQ/sKz6O2U3qXXym/fgiOn+qEUK9dNHw== X-Received: by 2002:a17:903:2291:b0:1bc:6c8:cde3 with SMTP id b17-20020a170903229100b001bc06c8cde3mr10984095plh.57.1692685591454; Mon, 21 Aug 2023 23:26:31 -0700 (PDT) X-Received: from sunil-laptop ([106.51.191.205]) by smtp.gmail.com with ESMTPSA id az10-20020a170902a58a00b001bbaf09ce15sm8118827plb.152.2023.08.21.23.26.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Aug 2023 23:26:31 -0700 (PDT) Date: Tue, 22 Aug 2023 11:56:25 +0530 From: "Sunil V L" To: devel@edk2.groups.io, Liming Gao Cc: "Li, Yong" , "2931013282@sjtu.edu.cn" <2931013282@sjtu.edu.cn>, "Warkentin, Andrei" Subject: Re: [edk2-devel] [PATCH] OvmfPkg/RiscVVirt: Fix issues in VarStore Blockmap config Message-ID: References: <2c7b82749a9aff01393b230e216c5e5aee675dd1.1691750977.git.2931013282@sjtu.edu.cn> <177BD1A40E32609C.8497@groups.io> MIME-Version: 1.0 In-Reply-To: <177BD1A40E32609C.8497@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ZLm9UcGC; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Liming, This is a bug fix and can cause data loss if the variable size > 4k. Can it be included for the edk2-stable202308? Let me know if it requires a BZ id. I tried running the CI tests for this patch. But 2 of tests failed and I don't think it has anything to do with this patch. If you are ok to take this patch for the stable release, could you please let me know what needs to be done? PR : https://github.com/tianocore/edk2/pull/4754 Thanks! Sunil On Wed, Aug 16, 2023 at 02:33:00PM +0530, Sunil V L via groups.io wrote: > On Wed, Aug 16, 2023 at 07:08:58AM +0000, Li, Yong wrote: > > Hi Sunil, > > > > Qingyu is from Penglai team, when we were working together in enabling StandaloneMm variable service, > > we found an issue in OvmfPkg/RiscVVirt/VarStore.fdf.inc, in which the blockmap config is not aligned with the value in > > OvmfPkg/RiscVVirt/Library/VirtNorFlashPlatformLib/VirtNorFlashStaticLib.c, which is SIZE_256KB > > > > That mis-alignment won't cause any issue if the variable size is small and less than 0x1000, but if store more data in the flash device then it will cause data loss issue during reboot. > > Once reboot if any FV header data is corrupted it will result the whole variable system be re-initialized. > > > > Please help review the patch and give the comments, thanks > > > Hi Yong Li, > > Thank you very much for providing the context. Sorry, I actually had > missed this. > > Hi Quingyu Shang, > > The patch LGTM. Thanks a lot for finding the issue and fixing it. In > future, could you please run BaseTools/Scripts/GetMaintainer.py on the > patches and CC all the people it lists using "Cc:" tag? > > Reviewed-by: Sunil V L > > Thanks! > Sunil > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107947): https://edk2.groups.io/g/devel/message/107947 Mute This Topic: https://groups.io/mt/100684601/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-