From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7876974003B for ; Mon, 11 Sep 2023 06:22:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/XbE9sY1ssJzvpSM5cwCSU979SIK8kBMmKzSVWq0egc=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1694413328; v=1; b=Cq7SgAw85NK4l52EkOTtHIs4/ulbA+FqneByN8dRed0BTHSiBaCZfYB/ZxMTtFT2HhM8fiYB NB/B9brh/o7RPadPly9/XSS0HQvUrXKb6/QV28dNa+y1EDRGtWwj35zKeE+RSeyE/BR02fKy1hU gzLvWiuo82aMGkRtrxBrAxhQ= X-Received: by 127.0.0.2 with SMTP id qtvZYY7687511xXU1upZT0nl; Sun, 10 Sep 2023 23:22:08 -0700 X-Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mx.groups.io with SMTP id smtpd.web10.52577.1694413327118485494 for ; Sun, 10 Sep 2023 23:22:07 -0700 X-Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-68fb2e9ebcdso669155b3a.2 for ; Sun, 10 Sep 2023 23:22:07 -0700 (PDT) X-Gm-Message-State: 65aa8HFxyzR7O8CKXNfcuFgix7686176AA= X-Google-Smtp-Source: AGHT+IHpGt2b11TdmC692CYkD5T/YGeeymaEwIyyHr59QGQ9IO2lRhLCu61HeZ3kEQ6ejwPOu6XVYQ== X-Received: by 2002:a05:6a20:430c:b0:13c:b1a7:7b1 with SMTP id h12-20020a056a20430c00b0013cb1a707b1mr8287958pzk.25.1694413326384; Sun, 10 Sep 2023 23:22:06 -0700 (PDT) X-Received: from sunil-laptop ([106.51.189.46]) by smtp.gmail.com with ESMTPSA id e4-20020a170902d38400b001b05e96d859sm5586836pld.135.2023.09.10.23.22.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Sep 2023 23:22:06 -0700 (PDT) Date: Mon, 11 Sep 2023 11:52:00 +0530 From: "Sunil V L" To: Laszlo Ersek Cc: edk2-devel-groups-io , Andrei Warkentin , Ard Biesheuvel , Gerd Hoffmann , Jiewen Yao , Jordan Justen Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt/README.md: bring your own OpenSBI Message-ID: References: <20230907145825.87830-1-lersek@redhat.com> MIME-Version: 1.0 In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Cq7SgAw8; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Sep 11, 2023 at 08:15:26AM +0200, Laszlo Ersek wrote: > On 9/11/23 07:32, Laszlo Ersek wrote: > > On 9/8/23 08:13, Sunil V L wrote: > >> Hi Laszlo, > >> > >> On Thu, Sep 07, 2023 at 04:58:25PM +0200, Laszlo Ersek wrote: > >>> Explain how users can compose their pre-OS environment purely from > >>> binaries they've built themselves. > >>> > >>> Cc: Andrei Warkentin > >>> Cc: Ard Biesheuvel > >>> Cc: Gerd Hoffmann > >>> Cc: Jiewen Yao > >>> Cc: Jordan Justen > >>> Cc: Sunil V L > >>> Signed-off-by: Laszlo Ersek > >>> --- > >>> > >>> Notes: > >>> rendered version: > >>> > >>> https://github.com/lersek/edk2/tree/bring-your-own-opensbi/OvmfPkg/RiscVVirt#test-with-your-own-opensbi-binary > >>> > >>> OvmfPkg/RiscVVirt/README.md | 17 +++++++++++++++++ > >>> 1 file changed, 17 insertions(+) > >>> > >>> diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md > >>> index 8c3ac37b802a..dbb40bbe89b0 100644 > >>> --- a/OvmfPkg/RiscVVirt/README.md > >>> +++ b/OvmfPkg/RiscVVirt/README.md > >>> @@ -69,3 +69,20 @@ Below example shows how to boot openSUSE Tumbleweed E20. > >>> -device virtio-net-pci,netdev=net0 \ > >>> -device virtio-blk-device,drive=hd0 \ > >>> -drive file=openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw,format=raw,id=hd0 > >>> + > >>> +## Test with your own OpenSBI binary > >>> +Using the above QEMU command line, **RISCV_VIRT_CODE.fd** is launched by the > >>> +OpenSBI binary that is bundled with QEMU. You can build your own OpenSBI binary > >>> +as well: > >>> + > >>> + OPENSBI_DIR=... > >>> + git clone https://github.com/riscv/opensbi.git $OPENSBI_DIR > >>> + make -C $OPENSBI_DIR \ > >>> + -j $(getconf _NPROCESSORS_ONLN) \ > >>> + CROSS_COMPILE=riscv64-linux-gnu- \ > >>> + PLATFORM=generic > >>> + > >> Do we need to duplicate these OpenSBI build instructions in EDK2? IMO, > >> we should just document how to use -bios to use custom OpenSBI image. > >> The build instructions for other software repos can change at any > >> time. > > > > Can we include the opensbi project URL at least? > > BTW, I disagree with your larger message (as I perceive it). > > While it's true that build instructions may change at any time, that's > just a generic statement about any software and any documentation in > existence. All documentation goes stale at some point. > Agreed. But my point is, this documentation which provides build instructions of opensbi doesn't belong to edk2 but opensbi. If something is missing in the opensbi build instructions like you mentioned, it should be submitted as a patch to opensbi repo rather edk2, right? -Sunil > And in this particular case, I needed to fish out the build commands, > and the resultant "fw_dynamic.bin" filename, from the QEMU tree, not the > OpenSBI tree. I'm not aware of any documentation that makes a dedicated > statement about building OpenSBI *for* running edk2. > > The OpenSBI root "README.md" @ b20bd479eff1 only says "For example, to > compile the platform library and the firmware examples for the QEMU > RISC-V *virt* machine, ** should be *generic*". It does > not mention the build output pathname > "build/platform/generic/firmware/fw_dynamic.bin". > > Laszlo > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108479): https://edk2.groups.io/g/devel/message/108479 Mute This Topic: https://groups.io/mt/101216052/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-