From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1D5A5AC158A for ; Mon, 11 Sep 2023 10:15:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KkMkzwnr/7OgawnOZHmKJ/1XS1qQeDMNWCW8MIG5hL0=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1694427312; v=1; b=CSmFHiXFqkIHos4Nk2i8vvy83Z/cE8bzxWMb7V+0e4yxJm449Vgd/OyqpscBoM5YjIxTIIdt ua9MRbAcvRv9Qm0fK3cc0KMYDLRE8g6oJxBZOXi0vJcPDrrWj8UHRxMi61oOzrmRS8blnL3nY5Y SvJUDfS/OBOiYSUmWrSEJ+ng= X-Received: by 127.0.0.2 with SMTP id XUiSYY7687511xAZEZbyl12Z; Mon, 11 Sep 2023 03:15:12 -0700 X-Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mx.groups.io with SMTP id smtpd.web10.55085.1694427312130606123 for ; Mon, 11 Sep 2023 03:15:12 -0700 X-Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1c0d5b16aacso33749505ad.1 for ; Mon, 11 Sep 2023 03:15:12 -0700 (PDT) X-Gm-Message-State: O6XotlCqrY1zm9epP3qrp089x7686176AA= X-Google-Smtp-Source: AGHT+IHWfMORFZYOqsS3C27e5HpcmcuLZmOo9JmDlna3xIDlNsXSC5+pj5AYM+wR79SDGZlOudlqew== X-Received: by 2002:a17:903:1106:b0:1b8:b3f9:58e5 with SMTP id n6-20020a170903110600b001b8b3f958e5mr9356967plh.38.1694427311612; Mon, 11 Sep 2023 03:15:11 -0700 (PDT) X-Received: from sunil-laptop ([106.51.189.46]) by smtp.gmail.com with ESMTPSA id kb14-20020a170903338e00b001b8a2edab6asm6115555plb.244.2023.09.11.03.15.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 03:15:11 -0700 (PDT) Date: Mon, 11 Sep 2023 15:45:05 +0530 From: "Sunil V L" To: Laszlo Ersek Cc: edk2-devel-groups-io , Andrei Warkentin , Ard Biesheuvel , Gerd Hoffmann , Jiewen Yao , Jordan Justen Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt/README.md: bring your own OpenSBI Message-ID: References: <20230907145825.87830-1-lersek@redhat.com> <32d053f7-5740-6bdb-f34b-ea9a0262783c@redhat.com> MIME-Version: 1.0 In-Reply-To: <32d053f7-5740-6bdb-f34b-ea9a0262783c@redhat.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CSmFHiXF; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Sep 11, 2023 at 09:07:46AM +0200, Laszlo Ersek wrote: > On 9/11/23 08:22, Sunil V L wrote: > > On Mon, Sep 11, 2023 at 08:15:26AM +0200, Laszlo Ersek wrote: > >> On 9/11/23 07:32, Laszlo Ersek wrote: > >>> On 9/8/23 08:13, Sunil V L wrote: > >>>> Hi Laszlo, > >>>> > >>>> On Thu, Sep 07, 2023 at 04:58:25PM +0200, Laszlo Ersek wrote: > >>>>> Explain how users can compose their pre-OS environment purely from > >>>>> binaries they've built themselves. > >>>>> > >>>>> Cc: Andrei Warkentin > >>>>> Cc: Ard Biesheuvel > >>>>> Cc: Gerd Hoffmann > >>>>> Cc: Jiewen Yao > >>>>> Cc: Jordan Justen > >>>>> Cc: Sunil V L > >>>>> Signed-off-by: Laszlo Ersek > >>>>> --- > >>>>> > >>>>> Notes: > >>>>> rendered version: > >>>>> > >>>>> https://github.com/lersek/edk2/tree/bring-your-own-opensbi/OvmfPkg/RiscVVirt#test-with-your-own-opensbi-binary > >>>>> > >>>>> OvmfPkg/RiscVVirt/README.md | 17 +++++++++++++++++ > >>>>> 1 file changed, 17 insertions(+) > >>>>> > >>>>> diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md > >>>>> index 8c3ac37b802a..dbb40bbe89b0 100644 > >>>>> --- a/OvmfPkg/RiscVVirt/README.md > >>>>> +++ b/OvmfPkg/RiscVVirt/README.md > >>>>> @@ -69,3 +69,20 @@ Below example shows how to boot openSUSE Tumbleweed E20. > >>>>> -device virtio-net-pci,netdev=net0 \ > >>>>> -device virtio-blk-device,drive=hd0 \ > >>>>> -drive file=openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw,format=raw,id=hd0 > >>>>> + > >>>>> +## Test with your own OpenSBI binary > >>>>> +Using the above QEMU command line, **RISCV_VIRT_CODE.fd** is launched by the > >>>>> +OpenSBI binary that is bundled with QEMU. You can build your own OpenSBI binary > >>>>> +as well: > >>>>> + > >>>>> + OPENSBI_DIR=... > >>>>> + git clone https://github.com/riscv/opensbi.git $OPENSBI_DIR > >>>>> + make -C $OPENSBI_DIR \ > >>>>> + -j $(getconf _NPROCESSORS_ONLN) \ > >>>>> + CROSS_COMPILE=riscv64-linux-gnu- \ > >>>>> + PLATFORM=generic > >>>>> + > >>>> Do we need to duplicate these OpenSBI build instructions in EDK2? IMO, > >>>> we should just document how to use -bios to use custom OpenSBI image. > >>>> The build instructions for other software repos can change at any > >>>> time. > >>> > >>> Can we include the opensbi project URL at least? > >> > >> BTW, I disagree with your larger message (as I perceive it). > >> > >> While it's true that build instructions may change at any time, that's > >> just a generic statement about any software and any documentation in > >> existence. All documentation goes stale at some point. > >> > > Agreed. But my point is, this documentation which provides build > > instructions of opensbi doesn't belong to edk2 but opensbi. If something > > is missing in the opensbi build instructions like you mentioned, it > > should be submitted as a patch to opensbi repo rather edk2, right? > > I don't know. > > If two projects are used in conjunction, which project's documentation > should cover the combined use? > Okay, fair enough. Let's add it. It appears to be very useful for any one new to RISC-V+edk2 and OpenSBI. Do you want to update the -kernel option also in v2 or will it be separate patch? Thanks, Sunil > Laszlo > > > > > -Sunil > > > >> And in this particular case, I needed to fish out the build commands, > >> and the resultant "fw_dynamic.bin" filename, from the QEMU tree, not the > >> OpenSBI tree. I'm not aware of any documentation that makes a dedicated > >> statement about building OpenSBI *for* running edk2. > >> > >> The OpenSBI root "README.md" @ b20bd479eff1 only says "For example, to > >> compile the platform library and the firmware examples for the QEMU > >> RISC-V *virt* machine, ** should be *generic*". It does > >> not mention the build output pathname > >> "build/platform/generic/firmware/fw_dynamic.bin". > >> > >> Laszlo > >> > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108483): https://edk2.groups.io/g/devel/message/108483 Mute This Topic: https://groups.io/mt/101216052/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-