From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: Yuquan Wang <wangyuquan1236@phytium.com.cn>
Cc: <ardb+tianocore@kernel.org>, <chenbaozi@phytium.com.cn>,
<quic_ggregory@quicinc.com>, <rad@semihalf.com>,
<devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI
Date: Thu, 31 Aug 2023 14:06:32 +0100 [thread overview]
Message-ID: <ZPCQWE8WVsQEGGH3@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <20230531091422.357682-1-wangyuquan1236@phytium.com.cn>
Hi,
Apologies for the long delay reviewing this set.
I have rebased your patches onto:
https://github.com/leiflindholm/edk2-platforms/tree/sbsa-xhci
I had to move one hunk (.dec change) from 2/3 to 1/3 in order to
not break bisect.
If you're happy with the slightly modified version, I think this
is good to go in. Please let me know.
For the set:
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
/
Leif
On Wed, May 31, 2023 at 17:14:20 +0800, Yuquan Wang wrote:
> This patchset implements XHCI on sbsa-ref board to replace EHCI.
> As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI
> that only has 32-bit DMA capablity. Now this board has XHCI as
> an available usb controller with 64-bit DMA capablity.
>
> Yuquan Wang (3):
> Platform/Qemu/SbsaQemu/SbsaQemu.dsc: define XHCI Pcd settings
> SbsaQemu: Drivers: Add initial support for XHCI
> SbsaQemu: AcpiTables: Add XHCI info into DSDT
> Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 6 +-
> .../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 4 +-
> Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 125 ++----------------
> .../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 40 ++++--
> .../SbsaQemuPlatformDxe.inf | 2 +
> Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 4 +-
> 6 files changed, 53 insertions(+), 128 deletions(-)
>
> --
> 2.34.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108189): https://edk2.groups.io/g/devel/message/108189
Mute This Topic: https://groups.io/mt/101073211/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next parent reply other threads:[~2023-08-31 13:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230531091422.357682-1-wangyuquan1236@phytium.com.cn>
2023-08-31 13:06 ` Leif Lindholm [this message]
2023-08-31 14:05 ` [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI Ard Biesheuvel
2023-09-04 6:30 ` Yuquan Wang
2023-09-04 13:51 ` Leif Lindholm
2023-09-05 6:11 ` Yuquan Wang
2023-09-05 6:30 ` Marcin Juszkiewicz
2023-09-05 6:58 ` Yuquan Wang
2023-06-05 10:49 wangyuquan1236
2023-06-05 10:51 ` Ard Biesheuvel
2023-06-05 10:53 ` [edk2-devel] " wangyuquan1236
2023-06-05 10:54 ` Ard Biesheuvel
2023-06-05 10:58 ` wangyuquan1236
2023-06-05 12:18 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPCQWE8WVsQEGGH3@qc-i7.hemma.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox