From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 993CA740038 for ; Thu, 31 Aug 2023 13:06:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6ZOEwB7VKWMVmuLcGG0aYs0ToNiYdavFMO2VJhY+FTw=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1693487217; v=1; b=ca4i3FkVwV1FVzIycBvQVRUCW3deSPL51etgYnCDh41PMFENSMmKls4NTjSWb2lw8RTxoOsH HnBAofNWo7N9Rz1XW+KZ1czD4eMZ+0BE03JxmRQnLhJpDTHyerjtW9y+IIobnfMNRZXtZBH3q9t 1jYzvHQ1sDudvrfylzcmtd94= X-Received: by 127.0.0.2 with SMTP id 4Hn0YY7687511xtCzeiF5xpQ; Thu, 31 Aug 2023 06:06:57 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.16543.1693487216439636147 for ; Thu, 31 Aug 2023 06:06:56 -0700 X-Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37VCgSV8028830; Thu, 31 Aug 2023 13:06:55 GMT X-Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3st6ctaedn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 31 Aug 2023 13:06:55 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 37VD6bXR012047 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 31 Aug 2023 13:06:37 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Thu, 31 Aug 2023 06:06:35 -0700 Date: Thu, 31 Aug 2023 14:06:32 +0100 From: "Leif Lindholm" To: Yuquan Wang CC: , , , , Subject: Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI Message-ID: References: <20230531091422.357682-1-wangyuquan1236@phytium.com.cn> MIME-Version: 1.0 In-Reply-To: <20230531091422.357682-1-wangyuquan1236@phytium.com.cn> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: QD-AOzxwH8b8Wb7id4rn-S5CSy5-RCS- X-Proofpoint-ORIG-GUID: QD-AOzxwH8b8Wb7id4rn-S5CSy5-RCS- Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4JZqXkW8iss5Ph3qKhE6vcW5x7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ca4i3FkV; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, Apologies for the long delay reviewing this set. I have rebased your patches onto: https://github.com/leiflindholm/edk2-platforms/tree/sbsa-xhci I had to move one hunk (.dec change) from 2/3 to 1/3 in order to not break bisect. If you're happy with the slightly modified version, I think this is good to go in. Please let me know. For the set: Reviewed-by: Leif Lindholm / Leif On Wed, May 31, 2023 at 17:14:20 +0800, Yuquan Wang wrote: > This patchset implements XHCI on sbsa-ref board to replace EHCI. > As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI > that only has 32-bit DMA capablity. Now this board has XHCI as > an available usb controller with 64-bit DMA capablity. > > Yuquan Wang (3): > Platform/Qemu/SbsaQemu/SbsaQemu.dsc: define XHCI Pcd settings > SbsaQemu: Drivers: Add initial support for XHCI > SbsaQemu: AcpiTables: Add XHCI info into DSDT > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 6 +- > .../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 4 +- > Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 125 ++---------------- > .../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 40 ++++-- > .../SbsaQemuPlatformDxe.inf | 2 + > Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 4 +- > 6 files changed, 53 insertions(+), 128 deletions(-) > > -- > 2.34.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108189): https://edk2.groups.io/g/devel/message/108189 Mute This Topic: https://groups.io/mt/101073211/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-