From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 894CA7803D7 for ; Mon, 4 Sep 2023 15:17:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=TnpsAiTLnkz1cIkvOr7+yUGLzeQujiXZh3/X2lD/UlA=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1693840621; v=1; b=fUJQO03epU+bRhAXNHjr8S74TBS5e967TJ1AlpLgiForikrvioIvDkZ+HLu8BPRjF33V7KUs c9OZwP2w8X9t3ng4eq6gBwdsfHe4CK2A1taCU48n/RXnJ5V/LYFKoOUwd5dULyWyK/SWinQvfhp X1Sve/jOkfhlaAusAEOG3PSI= X-Received: by 127.0.0.2 with SMTP id wMx1YY7687511xEuyakMjZgK; Mon, 04 Sep 2023 08:17:01 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.50271.1693840620454799896 for ; Mon, 04 Sep 2023 08:17:00 -0700 X-Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 384EMhbu005539; Mon, 4 Sep 2023 15:16:53 GMT X-Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3suw99c6py-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Sep 2023 15:16:53 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 384FGq7F020231 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 4 Sep 2023 15:16:52 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Mon, 4 Sep 2023 08:16:50 -0700 Date: Mon, 4 Sep 2023 16:16:46 +0100 From: "Leif Lindholm" To: , CC: , caiyuqing379 <202235273@mail.sdu.edu.cn>, USER0FISH Subject: Re: [edk2-devel] [PATCH v2 0/8] EDK2 on RISC-V Sophgo SG2042 platform Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: ehCSZ7zxVC3Ec0Og3gWZzWAs3qwalzln X-Proofpoint-ORIG-GUID: ehCSZ7zxVC3Ec0Og3gWZzWAs3qwalzln Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: IA6CfaWXudU12GcRp3zpL0h9x7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=fUJQO03e; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Yuqing (?), Thank you for this contribution. I have a few high-level comments, but I will also look into the individual patches and comment if I find things I feel will make the port easier to maintain. 1) Git If it is possible for you to push these patches to some public git tree, that makes it easier for us to deal with the binary files (the .png files in 8/8). If you do so, you can add a link to the branch in the 0/8 blurb On Thu, Aug 31, 2023 at 21:44:16 +0800, caiyuqing_hz@163.com wrote: > From: caiyuqing379 <202235273@mail.sdu.edu.cn> > > Signed-off-by: caiyuqing379 <202235273@mail.sdu.edu.cn> > Co-authored-by: USER0FISH > Cc: dahogn > Cc: meng-cz > Cc: yli147 > Cc: ChaiEvan > Cc: Sunil V L > > *** BLURB HERE *** 2) Blurb It would be nice if the blurb could be replaced by a small description of what is being contributed, and why. For example, some quick searching on the Internet tells me that the SoC in question is the same as will be in the Milk-V Pioneer board. Is the EVB compatible with the Pioneer board? If not, are you planning to add support for the Pioneer board later? 3) Layout The layout of this port does not follow the usual pattern for edk2 platform ports. We split SoC support (Silicon/) apart from platform port (Platform/). Superficially, it looks like it would make sense to move most of the current port from Platform/Sophgo/SG2042Pkg/ to Silicon/Sophgo/SG2042Pkg/ except for Platform/Sophgo/SG2042Pkg/SG2042_EVB_Board/ which would make sense to keep under Platform/ as Platform/Sophgo/SG2042_EVB_Board/ (Knowing what the plan is for future work would also help us to provide useful giudance.) 4) Clang toolchain support I attempted to build the port using the CLANGDWARF toolchain profile. This leads to the same problem as described by https://www.mail-archive.com/devel@edk2.groups.io/msg61953.html and the same solution makes the build succeed. (I don't know if the resulting build *works*.) Best Regards, Leif > caiyuqing379 (8): > Sophgo/SG2042Pkg: Add SmbiosPlatformDxe module. > Sophgo/SG2042Pkg: Add PlatformUpdateMmuDxe module. > Sophgo/SG2042Pkg: Add Sophgo SDHCI driver. > Sophgo/SG2042Pkg: Add base MMC driver. > Sophgo/SG2042Pkg: Add SEC module. > SG2042Pkg/SG2042_EVB_Board: Add Sophgo SG2042 platform. > Sophgo/SG2042Pkg: Add SG2042Pkg. > Sophgo/SG2042Pkg: Add platform readme and document. > > Platform/Sophgo/SG2042Pkg/SG2042Pkg.dec | 35 + > .../SG2042Pkg/SG2042_EVB_Board/SG2042.dec | 19 + > .../SG2042Pkg/SG2042_EVB_Board/SG2042.dsc | 548 +++++++++++ > .../SG2042Pkg/SG2042_EVB_Board/SG2042.fdf | 247 +++++ > Platform/Sophgo/SG2042Pkg/Sec/SecMain.inf | 68 ++ > .../SG2042Pkg/Universal/Dxe/MmcDxe/MmcDxe.inf | 46 + > .../PlatformUpdateMmuDxe.inf | 34 + > .../Universal/Dxe/SdHostDxe/SdHostDxe.inf | 47 + > .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 39 + > Platform/Sophgo/SG2042Pkg/Include/MmcHost.h | 225 +++++ > Platform/Sophgo/SG2042Pkg/Sec/SecMain.h | 103 ++ > .../SG2042Pkg/Universal/Dxe/MmcDxe/Mmc.h | 513 ++++++++++ > .../SG2042Pkg/Universal/Dxe/SdHostDxe/SdHci.h | 309 ++++++ > Platform/Sophgo/SG2042Pkg/Sec/Cpu.c | 29 + > Platform/Sophgo/SG2042Pkg/Sec/Memory.c | 363 +++++++ > Platform/Sophgo/SG2042Pkg/Sec/Platform.c | 141 +++ > Platform/Sophgo/SG2042Pkg/Sec/SecMain.c | 116 +++ > .../Universal/Dxe/MmcDxe/ComponentName.c | 156 +++ > .../Universal/Dxe/MmcDxe/Diagnostics.c | 323 ++++++ > .../SG2042Pkg/Universal/Dxe/MmcDxe/Mmc.c | 527 ++++++++++ > .../Universal/Dxe/MmcDxe/MmcBlockIo.c | 643 ++++++++++++ > .../SG2042Pkg/Universal/Dxe/MmcDxe/MmcDebug.c | 194 ++++ > .../Universal/Dxe/MmcDxe/MmcIdentification.c | 719 ++++++++++++++ > .../PlatformUpdateMmuDxe.c | 591 +++++++++++ > .../SG2042Pkg/Universal/Dxe/SdHostDxe/SdHci.c | 929 ++++++++++++++++++ > .../Universal/Dxe/SdHostDxe/SdHostDxe.c | 450 +++++++++ > .../Dxe/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 805 +++++++++++++++ > .../Sophgo/SG2042Pkg/About_Sophgo_platform.md | 39 + > .../Documents/Media/EDK2_SDU_Programme.png | Bin 0 -> 59830 bytes > .../SG2042Pkg/Documents/Media/SG2042_CPU.png | Bin 0 -> 806062 bytes > .../Documents/Media/Sophgo_SG2042_EVB.png | Bin 0 -> 1445528 bytes > Platform/Sophgo/SG2042Pkg/Maintainers.md | 107 ++ > Platform/Sophgo/SG2042Pkg/Readme.md | 79 ++ > Platform/Sophgo/SG2042Pkg/SG2042Pkg.uni | 13 + > Platform/Sophgo/SG2042Pkg/SG2042PkgExtra.uni | 12 + > .../SG2042Pkg/SG2042_EVB_Board/SG2042.fdf.inc | 62 ++ > .../SG2042_EVB_Board/VarStore.fdf.inc | 77 ++ > Platform/Sophgo/SG2042Pkg/Sec/SecEntry.S | 18 + > 38 files changed, 8626 insertions(+) > create mode 100644 Platform/Sophgo/SG2042Pkg/SG2042Pkg.dec > create mode 100644 Platform/Sophgo/SG2042Pkg/SG2042_EVB_Board/SG2042.dec > create mode 100644 Platform/Sophgo/SG2042Pkg/SG2042_EVB_Board/SG2042.dsc > create mode 100644 Platform/Sophgo/SG2042Pkg/SG2042_EVB_Board/SG2042.fdf > create mode 100644 Platform/Sophgo/SG2042Pkg/Sec/SecMain.inf > create mode 100644 Platform/Sophgo/SG2042Pkg/Universal/Dxe/MmcDxe/MmcDxe.inf > create mode 100644 Platform/Sophgo/SG2042Pkg/Universal/Dxe/PlatformUpdateMmuDxe/PlatformUpdateMmuDxe.inf > create mode 100644 Platform/Sophgo/SG2042Pkg/Universal/Dxe/SdHostDxe/SdHostDxe.inf > create mode 100644 Platform/Sophgo/SG2042Pkg/Universal/Dxe/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > create mode 100644 Platform/Sophgo/SG2042Pkg/Include/MmcHost.h > create mode 100644 Platform/Sophgo/SG2042Pkg/Sec/SecMain.h > create mode 100644 Platform/Sophgo/SG2042Pkg/Universal/Dxe/MmcDxe/Mmc.h > create mode 100644 Platform/Sophgo/SG2042Pkg/Universal/Dxe/SdHostDxe/SdHci.h > create mode 100644 Platform/Sophgo/SG2042Pkg/Sec/Cpu.c > create mode 100644 Platform/Sophgo/SG2042Pkg/Sec/Memory.c > create mode 100644 Platform/Sophgo/SG2042Pkg/Sec/Platform.c > create mode 100644 Platform/Sophgo/SG2042Pkg/Sec/SecMain.c > create mode 100644 Platform/Sophgo/SG2042Pkg/Universal/Dxe/MmcDxe/ComponentName.c > create mode 100644 Platform/Sophgo/SG2042Pkg/Universal/Dxe/MmcDxe/Diagnostics.c > create mode 100644 Platform/Sophgo/SG2042Pkg/Universal/Dxe/MmcDxe/Mmc.c > create mode 100644 Platform/Sophgo/SG2042Pkg/Universal/Dxe/MmcDxe/MmcBlockIo.c > create mode 100644 Platform/Sophgo/SG2042Pkg/Universal/Dxe/MmcDxe/MmcDebug.c > create mode 100644 Platform/Sophgo/SG2042Pkg/Universal/Dxe/MmcDxe/MmcIdentification.c > create mode 100644 Platform/Sophgo/SG2042Pkg/Universal/Dxe/PlatformUpdateMmuDxe/PlatformUpdateMmuDxe.c > create mode 100755 Platform/Sophgo/SG2042Pkg/Universal/Dxe/SdHostDxe/SdHci.c > create mode 100644 Platform/Sophgo/SG2042Pkg/Universal/Dxe/SdHostDxe/SdHostDxe.c > create mode 100644 Platform/Sophgo/SG2042Pkg/Universal/Dxe/SmbiosPlatformDxe/SmbiosPlatformDxe.c > create mode 100644 Platform/Sophgo/SG2042Pkg/About_Sophgo_platform.md > create mode 100644 Platform/Sophgo/SG2042Pkg/Documents/Media/EDK2_SDU_Programme.png > create mode 100644 Platform/Sophgo/SG2042Pkg/Documents/Media/SG2042_CPU.png > create mode 100644 Platform/Sophgo/SG2042Pkg/Documents/Media/Sophgo_SG2042_EVB.png > create mode 100644 Platform/Sophgo/SG2042Pkg/Maintainers.md > create mode 100644 Platform/Sophgo/SG2042Pkg/Readme.md > create mode 100644 Platform/Sophgo/SG2042Pkg/SG2042Pkg.uni > create mode 100644 Platform/Sophgo/SG2042Pkg/SG2042PkgExtra.uni > create mode 100644 Platform/Sophgo/SG2042Pkg/SG2042_EVB_Board/SG2042.fdf.inc > create mode 100644 Platform/Sophgo/SG2042Pkg/SG2042_EVB_Board/VarStore.fdf.inc > create mode 100644 Platform/Sophgo/SG2042Pkg/Sec/SecEntry.S > > -- > 2.34.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108262): https://edk2.groups.io/g/devel/message/108262 Mute This Topic: https://groups.io/mt/101084028/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-