From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: Yuquan Wang <wangyuquan1236@phytium.com.cn>
Cc: ardb+tianocore <ardb+tianocore@kernel.org>,
chenbaozi <chenbaozi@phytium.com.cn>,
Graeme Gregory <graeme@xora.org.uk>, devel <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI
Date: Mon, 4 Sep 2023 14:51:04 +0100 [thread overview]
Message-ID: <ZPXgyFHg8RLY+luE@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <202309041430568086559@phytium.com.cn>
Hi Yuquan,
On Mon, Sep 04, 2023 at 14:30:57 +0800, Yuquan Wang wrote:
> Hi, Leif
> On 2023-08-31 21:06, Leif wrote:
>
> I had to move one hunk (.dec change) from 2/3 to 1/3 in order to
> not break bisect.
>
> If you're happy with the slightly modified version, I think this
> is good to go in. Please let me know.
>
>
> It' ok.
>
> In the second version of this series patches, in fact, I have moved the .dec change into
> 1/3.
>
> It is my fault that I forgot to add "Cc" to Ard, Leif and Graeme in my latest version
> of "xhci" patches.
> The link is: https://edk2.groups.io/g/devel/message/106729
Understood, thanks.
However, this version still breaks bisect: attempting to build at 1/3
or 2/3 leads to:
---
/work/git/edk2-platforms/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf(72):
error 3000: PCD
[gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPlatformEhciBase] in
[/work/git/edk2-platforms/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf]
is not found in dependent packages:
---
Also, I think Ard's comments on the ACPI changes still apply.
Do you have a comment on that?
Best Regards,
Leif
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108259): https://edk2.groups.io/g/devel/message/108259
Mute This Topic: https://groups.io/mt/101073211/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-09-04 13:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230531091422.357682-1-wangyuquan1236@phytium.com.cn>
2023-08-31 13:06 ` [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI Leif Lindholm
2023-08-31 14:05 ` Ard Biesheuvel
2023-09-04 6:30 ` Yuquan Wang
2023-09-04 13:51 ` Leif Lindholm [this message]
2023-09-05 6:11 ` Yuquan Wang
2023-09-05 6:30 ` Marcin Juszkiewicz
2023-09-05 6:58 ` Yuquan Wang
2023-06-05 10:49 wangyuquan1236
2023-06-05 10:51 ` Ard Biesheuvel
2023-06-05 10:53 ` [edk2-devel] " wangyuquan1236
2023-06-05 10:54 ` Ard Biesheuvel
2023-06-05 10:58 ` wangyuquan1236
2023-06-05 12:18 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPXgyFHg8RLY+luE@qc-i7.hemma.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox