From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 68AA0941A71 for ; Fri, 22 Sep 2023 16:19:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=z2QOVjHD7GshIyAARCm/pnAVL5kDZYg2AgvkUe675Sc=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1695399577; v=1; b=aTbjdijXParWrM7aPkh+P/lxQgcgGklUWI/EaRbOAUF0HYyVcJ6LhifJ9MohV8RNYXFUdXLA e9mhZoZbJEa+717tbC79GKvPl5K7PNNPLtP2D1Fw8NrDr53jeG6N3cjxWGCKUqQJG+k7EpCpOqZ JpK6eKyJHbZq6AIVx91Hr5rE= X-Received: by 127.0.0.2 with SMTP id EMbsYY7687511xyYUL2hZbdz; Fri, 22 Sep 2023 09:19:37 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.1788.1695399576035685880 for ; Fri, 22 Sep 2023 09:19:36 -0700 X-Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38MFJUhn002174; Fri, 22 Sep 2023 16:19:25 GMT X-Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t99arrs4r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Sep 2023 16:19:25 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38MGJOJ4032439 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Sep 2023 16:19:24 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Fri, 22 Sep 2023 09:19:20 -0700 Date: Fri, 22 Sep 2023 17:19:17 +0100 From: "Leif Lindholm" To: Sami Mujawar CC: , , , , , , , , , , , , Subject: Re: [edk2-devel] [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support Message-ID: References: <20230922143516.4764-1-sami.mujawar@arm.com> MIME-Version: 1.0 In-Reply-To: <20230922143516.4764-1-sami.mujawar@arm.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: UIzaBApZ8ha-DEPLiV3zDFM8n382ibG3 X-Proofpoint-ORIG-GUID: UIzaBApZ8ha-DEPLiV3zDFM8n382ibG3 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: wPHMmZrjVKUnTN3DLbAOzFQNx7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=aTbjdijX; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, Sep 22, 2023 at 15:35:03 +0100, Sami Mujawar wrote: > This patch series provides the following updates: > - The patches 1 & 2 add the new fields introduced > in MADT (APIC table) by ACPI 6.5 and the patch > 7/11 updates the Acpiview MADT parser accordingly. > - The patches 3, 4 & 5 adds TRBE support to the MADT > table generator in DynamicTablesPkg. > - Patch 6/11 updates the FADT ACPI revision to 6.5. > - The patches 8, 9 & 10 add support to generate ETE > device nodes. > - The 3rd last last patch series fixes a bug wherein > the CPC token was incorrectly referenced. > - The last 2 patches in the series introduce helper > functions to detect if TRBE and ETE features are > supported. > > Updates from v2 patch series: > - Updated patch 5 to removed superfluous initialisation > of TRBE interrupt field for ACPI 6.4. > - Patch 12/13 introduces a helper function in ArmLib to > detect if TRBE is supported. > - Patch 13/13 introduces a helper function in ArmLib to > detect if ETE is supported. > > Updates from v1 patch series: > - Fixed issue with setting TRBE interrupt in patch 5/11. > > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/2620_ete_dev_fvp_v3 For 1-2,12-13: Reviewed-by: Leif Lindholm > Sami Mujawar (13): > MdePkg: MADT: Add Online capable flag in GICC > MdePkg: MADT: Add TRBE interrupt to GICC > DynamicTablesPkg: Add TRBE interrupt to GICC object > DynamicTablesPkg: Add TRBE interrupt to GICC object parser > DynamicTablesPkg: Update MADT generator for ACPI 6.5 > DynamicTablesPkg: Update FADT generator to ACPI 6.5 > ShellPkg: Acpiview: Update MADT parser for TRBE interrupt > DynamicTablesPkg: Add an ET info object to Arm namespace > DynamicTablesPkg: Add an ET info object parser > DynamicTablesPkg: Add ETE device to CPU node in AML > DynamicTablesPkg: Fix referencing of CPC token > ArmPkg/ArmLib: Add ArmHasTrbe () helper function > ArmPkg/ArmLib: Add ArmHasEte () helper function > > ArmPkg/Include/Chipset/AArch64.h | 4 + > ArmPkg/Include/Library/ArmLib.h | 25 +++ > ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 31 ++++ > DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 32 +++- > DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c | 108 +++++------ > DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c | 79 ++++---- > DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 188 +++++++++++++++++++- > DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.h | 11 +- > DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c | 11 +- > MdePkg/Include/IndustryStandard/Acpi65.h | 4 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c | 48 ++++- > 11 files changed, 442 insertions(+), 99 deletions(-) > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109017): https://edk2.groups.io/g/devel/message/109017 Mute This Topic: https://groups.io/mt/101522262/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-