From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B31607803DE for ; Tue, 12 Sep 2023 10:00:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=zUAB21jGWF3rfUykrLKmCGfDSs/Lln753eF9iYfqkPU=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1694512858; v=1; b=qxOBP/UT4OEQksfTjlORoBpCbplVgs1eRX2CkuLPlwxxiM9ETp5A0IYlDoIJstsNRZidMxx9 JwFUuh9xEgSIdvE6neTlLIvtq9uY377Tq7+p2TpJNCGimqWZtlM+NRDAeyXCJIxvls7M6byy6iv BvnTlXT+6WDGX/kW0Nxq+iqI= X-Received: by 127.0.0.2 with SMTP id uD2fYY7687511xj27eCQb8mf; Tue, 12 Sep 2023 03:00:58 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.21272.1694512857694997228 for ; Tue, 12 Sep 2023 03:00:57 -0700 X-Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38C7ETPF014017; Tue, 12 Sep 2023 09:58:27 GMT X-Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t29b0hhdx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Sep 2023 09:58:26 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38C9wQtt030419 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Sep 2023 09:58:26 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Tue, 12 Sep 2023 02:58:24 -0700 Date: Tue, 12 Sep 2023 10:58:21 +0100 From: "Leif Lindholm" To: Rebecca Cran CC: , Nhi Pham , Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Ampere: Update Readme.md Message-ID: References: <20230911174412.785658-1-rebecca@os.amperecomputing.com> MIME-Version: 1.0 In-Reply-To: <20230911174412.785658-1-rebecca@os.amperecomputing.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: YWQC7nzDC2a2kPxsh8GqmM6_LfUiRKTd X-Proofpoint-ORIG-GUID: YWQC7nzDC2a2kPxsh8GqmM6_LfUiRKTd Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: uMvUBh1efFEXwn80VWieaku2x7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="qxOBP/UT"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Sep 11, 2023 at 11:44:12 -0600, Rebecca Cran wrote: > Improve the Readme.md in Platform/Ampere: > > - At this point eMAG is irrelevant, and most people are likely > using Altra systems. Drop mention of it. > - Instead of mentioning the 'latest' versions of CentOS and Ubuntu > (which will by definition change over time), specify Ubuntu 22.04 > and CentOS 7. > - Fix the link to the acpica download, since content has been moved from > acpica.org to intel.com. > - Assuming the build is being done on Linux, acpica shouldn't be built > with a CYGWIN definition. > - To avoid making people wait ages for acpica to build, add `-j8` as an > example of building in parallel. > > Signed-off-by: Rebecca Cran > --- > Platform/Ampere/Readme.md | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Platform/Ampere/Readme.md b/Platform/Ampere/Readme.md > index 894bad3437b8..066876dab4b5 100644 > --- a/Platform/Ampere/Readme.md > +++ b/Platform/Ampere/Readme.md > @@ -8,8 +8,8 @@ Silicon code is located under Silicon/Ampere/Ampere{SoC Name}Pkg. > > # Build machines > > -- x86 Linux host machines running latest Ubuntu or CentOS releases. > -- Arm64 Linux host machines if native compiling. This has been tested on Ampere's eMAG and Altra hardware platforms with latest AArch64 CentOS or Ubuntu releases. > +- x86 Linux host machines running Ubuntu 22.04 or CentOS 7 releases. > +- Arm64 Linux host machines if native compiling. This has been tested on Ampere's Altra hardware platforms with AArch64 CentOS 7 or Ubuntu 22.04 releases. So, it's really good that you add "known good" versions so that if someone runs into a problem around toolchain version compatibility, they know what to use. But anything in edk2-platform should be kept up to date so that it builds on current operating systems. And I'd prefer for known versions to include toolchain profile and versions of tools (so people don't need to go run lookup tables on what versions are included in what distro). It's fine (even good) to state "as included in distro X release Y", but I want more granularity. Because I may well have a GCC9 lying around in a vm somwehere, and then I can use that instead of hopping off setting up a dedicated thing to build a specific platform. > # How to build (Linux Environment) > > @@ -32,8 +32,8 @@ If you run into any build issue with the Intel ASL+ Optimizing Compiler/Disassem > download and install the IASL compiler from https://acpica.org/. At the time of this write-up, we have tested with version 20200110. > > ```bash > -$ wget https://acpica.org/sites/acpica/files/acpica-unix2-20200110.tar.gz > +$ wget https://downloadmirror.intel.com/774850/acpica-unix2-20200110.tar.gz > $ tar xzf acpica-unix2-20200110.tar.gz > $ cd acpica-unix2-20200110 > -$ make HOST=_CYGWIN && sudo make install > +$ make -j8 && sudo make install > ``` No issue with this part. / Leif > -- > 2.34.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108526): https://edk2.groups.io/g/devel/message/108526 Mute This Topic: https://groups.io/mt/101298216/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-