From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5CDDCD80144 for ; Fri, 15 Sep 2023 10:47:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=umPJsxny3JymR94O4wcCpwBN6N/x+AR+uPv4fkhgv8Y=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1694774873; v=1; b=TM4z7VyZiK1HSaI6pSJY/ztml+0rzexKnNmNGEcUivDmTRAtBD2Az72PkYnGgrHoQn6FaI1+ rHFpnh+tUE5gAPj7tVKB8GXhFkTXCbVDbfF7D4sWKXBefV3Xke1jOYf05bzkkh5Q9vTmco5smbF aTU5lo14EuFk4o9l5iwo5HP8= X-Received: by 127.0.0.2 with SMTP id gYyrYY7687511xtbH1oDdAxz; Fri, 15 Sep 2023 03:47:53 -0700 X-Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mx.groups.io with SMTP id smtpd.web11.17576.1694774872455108762 for ; Fri, 15 Sep 2023 03:47:52 -0700 X-Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1c1e3a4a06fso16494755ad.3 for ; Fri, 15 Sep 2023 03:47:52 -0700 (PDT) X-Gm-Message-State: 2B0arfloQHUSGRPwisd8X3ygx7686176AA= X-Google-Smtp-Source: AGHT+IEgPcSfLLuEqAe7GsaxXB9kbaPkfERK7Xvk6od20hdKfZRZXegmIK5xd41Wn5OXME649lig5Q== X-Received: by 2002:a17:903:124d:b0:1bf:d92e:c5a7 with SMTP id u13-20020a170903124d00b001bfd92ec5a7mr1294498plh.28.1694774871842; Fri, 15 Sep 2023 03:47:51 -0700 (PDT) X-Received: from sunil-laptop ([106.51.189.46]) by smtp.gmail.com with ESMTPSA id b3-20020a170902b60300b001bbb8d5166bsm3195367pls.123.2023.09.15.03.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 03:47:51 -0700 (PDT) Date: Fri, 15 Sep 2023 16:17:45 +0530 From: "Sunil V L" To: caiyuqing_hz@163.com Cc: devel@edk2.groups.io, quic_llindhol@quicinc.com, libing1202@outlook.com, inochiama@outlook.com Subject: Re: [edk2-devel] [PATCH v3 3/8] Sophgo/SG2042Pkg: Add Sophgo SDHCI driver. Message-ID: References: <062132b714c4e151fe0348ba47de8d7c513a243d.1694010673.git.202235273@mail.sdu.edu.cn> MIME-Version: 1.0 In-Reply-To: <062132b714c4e151fe0348ba47de8d7c513a243d.1694010673.git.202235273@mail.sdu.edu.cn> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=TM4z7VyZ; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none On Thu, Sep 07, 2023 at 06:25:46PM +0800, caiyuqing_hz@163.com wrote: > From: caiyuqing379 <202235273@mail.sdu.edu.cn> > > This driver implements Sophgo SDHCI controller, which provides > the necessary interfaces for handling communication and data > transfer with SD cards. > > Signed-off-by: caiyuqing379 <202235273@mail.sdu.edu.cn> > Co-authored-by: USER0FISH > Cc: dahogn > Cc: meng-cz > Cc: yli147 > Cc: ChaiEvan > Cc: Sunil V L > Cc: Leif Lindholm > --- > .../SG2042Pkg/Drivers/SdHostDxe/SdHostDxe.inf | 47 + > .../SG2042Pkg/Drivers/SdHostDxe/SdHci.h | 309 ++++++ > .../SG2042Pkg/Drivers/SdHostDxe/SdHci.c | 929 ++++++++++++++++++ > .../SG2042Pkg/Drivers/SdHostDxe/SdHostDxe.c | 450 +++++++++ > 4 files changed, 1735 insertions(+) > create mode 100644 Silicon/Sophgo/SG2042Pkg/Drivers/SdHostDxe/SdHostDxe.inf > create mode 100644 Silicon/Sophgo/SG2042Pkg/Drivers/SdHostDxe/SdHci.h > create mode 100755 Silicon/Sophgo/SG2042Pkg/Drivers/SdHostDxe/SdHci.c > create mode 100644 Silicon/Sophgo/SG2042Pkg/Drivers/SdHostDxe/SdHostDxe.c > > diff --git a/Silicon/Sophgo/SG2042Pkg/Drivers/SdHostDxe/SdHostDxe.inf b/Silicon/Sophgo/SG2042Pkg/Drivers/SdHostDxe/SdHostDxe.inf > new file mode 100644 > index 000000000000..f4f51d8fde74 > --- /dev/null > +++ b/Silicon/Sophgo/SG2042Pkg/Drivers/SdHostDxe/SdHostDxe.inf > @@ -0,0 +1,47 @@ > +## @file > +# Component description file for the SD Host Controller DXE driver module. > +# > +# Copyright (c) 2019, ARM Limited. All rights reserved. > +# Copyright (c) 2017, Andrei Warkentin > +# Copyright (c) Microsoft Corporation. All rights reserved. > +# Copyright (c) 2023, Academy of Intelligent Innovation, Shandong Universiy, China.P.R. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +# > +## > + > +[Defines] > + INF_VERSION = 0x0001001A Just Curious. Why is INF_VERSION 0x0001001A? As per [1], I think new INF file should have version 1.27. [1] - https://tianocore-docs.github.io/edk2-InfSpecification/draft/2_inf_overview/24_[defines]_section.html#24-defines-section Otherwise, Acked-by: Sunil V L -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108709): https://edk2.groups.io/g/devel/message/108709 Mute This Topic: https://groups.io/mt/101213491/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-