From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D6166AC0F71 for ; Mon, 18 Sep 2023 11:35:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1wStzKF5RKANyUM+Xl2PnOXWpd2kJjHXrODd+HOG7zo=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1695036938; v=1; b=bKPerkn5mHmHs0yZ0s1GsN1j4CSrU0y0CDxvDXf3t0dVAiMeZu5G5vD51QpB8998JiadKTJn RIlIbj73kuZImyZ44uRK6TxaNDMO7g4vO7okbN1o9NZPYF/5MWfazfzOLnhZat+lQzI0flGKZ4k JELcy38XiX0kZmbF2ssI2r4c= X-Received: by 127.0.0.2 with SMTP id I575YY7687511xxGa6b8YgbL; Mon, 18 Sep 2023 04:35:38 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.48865.1695036937958601007 for ; Mon, 18 Sep 2023 04:35:37 -0700 X-Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38IBZb2N001071; Mon, 18 Sep 2023 11:35:37 GMT X-Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t6mts84yp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Sep 2023 11:35:37 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38IBZaU9008978 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Sep 2023 11:35:36 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Mon, 18 Sep 2023 04:35:35 -0700 Date: Mon, 18 Sep 2023 12:35:32 +0100 From: "Leif Lindholm" To: Marcin Juszkiewicz CC: , Ard Biesheuvel , Graeme Gregory Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: enlarge BL1/FIP sizes Message-ID: References: <20230918110312.315671-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 In-Reply-To: <20230918110312.315671-1-marcin.juszkiewicz@linaro.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: W58HO_ds466Bl8rcVFwcXUJcMryHw4o3 X-Proofpoint-ORIG-GUID: W58HO_ds466Bl8rcVFwcXUJcMryHw4o3 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: G5O6pARfJJiFNIEidUzi77Ujx7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=bKPerkn5; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Sep 18, 2023 at 13:03:12 +0200, Marcin Juszkiewicz wrote: > There are some changes in progress which make BL1 bigger than 0x8000 > which EDK2 uses. > > TF-A defines BL1 size to be 0x12000 one. So let follow it. > > Signed-off-by: Marcin Juszkiewicz This fixes a TF-A bug that you uncovered this morning, and I think that's worth pointing out in the commit message. However, Reviewed-by: Leif Lindholm *But* this is a breaking change SoI want to hold off on merging this until the TF-A bugfix has been merged, so we can update the edk2-non-osi binaries at the same time, and minimise the amount of pain. Note for the interested: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/23417 TL;DR: the fip base and bl1 size don't line up. The bl1 size was already set to sufficient size, but after RME support in TF-A, bl1 size grows beyond start of fip. / Leif > --- > Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf > index bc432cac6fc8..6bc55d701120 100644 > --- a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf > +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf > @@ -43,11 +43,11 @@ [FD.SBSA_FLASH0] > ################################################################################ > ## Place for Trusted Firmware > # flash0 is secure so we put here the BL1 > -0x00000000|0x00008000 > +0x00000000|0x00012000 > FILE = Platform/Qemu/Sbsa/bl1.bin > > # and FIP (BL2 + BL31) > -0x00008000|0x00020000 > +0x00012000|0x00020000 > FILE = Platform/Qemu/Sbsa/fip.bin > > ################################################################################ > -- > 2.41.0 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108772): https://edk2.groups.io/g/devel/message/108772 Mute This Topic: https://groups.io/mt/101430708/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-