Re: [edk2-devel] [PATCH 0/2] ArmPkg/ArmVirtPkg: handle FEAT_VHE NS-EL2 virtual timer

["Leif Lindholm" <quic_llindhol@quicinc.com>]

On Tue, Sep 19, 2023 at 14:18:01 +0100, Peter Maydell wrote:
> On Tue, 19 Sept 2023 at 12:20, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
> >
> > An ASSERT trips when we try to add the NS-EL2 virtual timer to qemu
> > mach-virt.
> >
> > Add a new Pcd for the new private peripheral interrupt id,
> > PcdArmArchTimerHypVirtIntrNum.
> >
> > Update ArmVirtTimerFdtClientLib to:
> > - Only assert on receiving less information that required through DT.
> > - Set PcdArmArchTimerHypVirtIntrNum if provided through DT.
> >
> > Reported-by: Peter Maydell <peter.maydell@linaro.org>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Sami Mujawar <sami.mujawar@arm.com>
> 
> Thanks for writing and sending out these patches. I've tested, and
> they are sufficient to get EDK2 to not assert and successfully
> boot a guest OS when using my QEMU RFC patchset that reports the
> new interrupt ID via the dtb:
> https://patchew.org/QEMU/20230919101240.2569334-1-peter.maydell@linaro.org/

CI told me I was a muppet and needed to add the same
[PcdsDynamicDefault.common] stanza to all the other .dscs in
ArmVirtPkg, so given they were all identical I took the liberty not to
ask for re-review.
Pushed as 7275993dc644..eb485b6438f4.

Thanks all!

/
    Leif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108859): https://edk2.groups.io/g/devel/message/108859
Mute This Topic: https://groups.io/mt/101453745/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-