From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 633B6AC197C for ; Tue, 19 Sep 2023 20:43:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=tWPuHGn4hBbGu99ix0tbmba80I07QMNJZ9AZRr8MIw0=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1695156234; v=1; b=geSByV/pJu577/SCNQNL8Q9AkhfSSQ36x7ADXpyZXaiK6+fkb0S3I2FhP8nElAzNl2q7M6L7 N0nq2VtiBG0MnzFwEvR0uDTI4U3rmrivCPLH1zfcV+JtAeqBVGNFuluHxluVLYfxX9XsUoYKpud K03ted7GV2oDA6nyQnRPzSYs= X-Received: by 127.0.0.2 with SMTP id HThzYY7687511xzdj4W1JZj2; Tue, 19 Sep 2023 13:43:54 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.21083.1695156233375174728 for ; Tue, 19 Sep 2023 13:43:53 -0700 X-Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38JKad7q004913; Tue, 19 Sep 2023 20:43:50 GMT X-Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t6trqjwam-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Sep 2023 20:43:49 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38JKhmrL021565 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Sep 2023 20:43:48 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Tue, 19 Sep 2023 13:43:47 -0700 Date: Tue, 19 Sep 2023 21:43:43 +0100 From: "Leif Lindholm" To: Peter Maydell CC: , Ard Biesheuvel , Sami Mujawar Subject: Re: [edk2-devel] [PATCH 0/2] ArmPkg/ArmVirtPkg: handle FEAT_VHE NS-EL2 virtual timer Message-ID: References: <20230919112015.229479-1-quic_llindhol@quicinc.com> MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: xpq5h9ZBIAZvYTC_InBfdsEqTM5IuPvl X-Proofpoint-ORIG-GUID: xpq5h9ZBIAZvYTC_InBfdsEqTM5IuPvl Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: lSk0JnR52GojIAHRpU1mIi5ex7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="geSByV/p"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, Sep 19, 2023 at 14:18:01 +0100, Peter Maydell wrote: > On Tue, 19 Sept 2023 at 12:20, Leif Lindholm wrote: > > > > An ASSERT trips when we try to add the NS-EL2 virtual timer to qemu > > mach-virt. > > > > Add a new Pcd for the new private peripheral interrupt id, > > PcdArmArchTimerHypVirtIntrNum. > > > > Update ArmVirtTimerFdtClientLib to: > > - Only assert on receiving less information that required through DT. > > - Set PcdArmArchTimerHypVirtIntrNum if provided through DT. > > > > Reported-by: Peter Maydell > > Cc: Ard Biesheuvel > > Cc: Sami Mujawar > > Thanks for writing and sending out these patches. I've tested, and > they are sufficient to get EDK2 to not assert and successfully > boot a guest OS when using my QEMU RFC patchset that reports the > new interrupt ID via the dtb: > https://patchew.org/QEMU/20230919101240.2569334-1-peter.maydell@linaro.org/ CI told me I was a muppet and needed to add the same [PcdsDynamicDefault.common] stanza to all the other .dscs in ArmVirtPkg, so given they were all identical I took the liberty not to ask for re-review. Pushed as 7275993dc644..eb485b6438f4. Thanks all! / Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108859): https://edk2.groups.io/g/devel/message/108859 Mute This Topic: https://groups.io/mt/101453745/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-