From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: <devel@edk2.groups.io>, <ardb@kernel.org>
Cc: <sami.mujawar@arm.com>, Pierre Gondois <Pierre.Gondois@arm.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Michael D Kinney <michael.d.kinney@intel.com>, nd <nd@arm.com>,
Zhiguang Liu <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/DxeRngLib: Add missing GUID declaration in inf
Date: Wed, 4 Oct 2023 16:30:44 +0100 [thread overview]
Message-ID: <ZR2FJNESTib4WhRd@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <CAMj1kXHsXMfCwaSzDHaEi3nBoUh4Sca9QJXVhz7PXpMfq+1Gmw@mail.gmail.com>
On Wed, Oct 04, 2023 at 14:56:55 +0000, Ard Biesheuvel wrote:
> On Tue, 3 Oct 2023 at 17:22, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
> >
> > +Zhiguang
> >
> > Tested-by: Leif Lindholm <quic_llindhol@quicinc.com>
> >
> > MdePkg maintainers - this is currently breaking several platforms in
> > edk2-platforms.
> >
>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>
> Please just merge this - it is an obvious and trivial bugfix, and it
> is affecting multiple platforms.
Yeah, good call.
I've submitted it as https://github.com/tianocore/edk2/pull/4887
/
Leif
> > On Fri, Sep 29, 2023 at 13:08:50 +0000, Sami Mujawar wrote:
> > > Hi Pierre,
> > >
> > > Thank you for this fix.
> > >
> > > Unfortunately, this did not get trapped by the edk2 CI as well.
> > >
> > > Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> > >
> > > Regards,
> > >
> > > Sami Mujawar
> > >
> > > On 29/09/2023, 13:30, "pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>" <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>> wrote:
> > >
> > >
> > > From: Pierre Gondois <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>>
> > >
> > >
> > > Add missing GUID declaration in DxeRngLib.inf.
> > >
> > >
> > > Fixes: bd1f0eecc1df ("MdePkg/DxeRngLib: Request raw algorithm
> > > instead of default")
> > >
> > >
> > > Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com <mailto:Pierre.Gondois@arm.com>>
> > > ---
> > > MdePkg/Library/DxeRngLib/DxeRngLib.inf | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > >
> > > diff --git a/MdePkg/Library/DxeRngLib/DxeRngLib.inf b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > > index 9c11959f8aeb..281fec46502f 100644
> > > --- a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > > +++ b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > > @@ -36,3 +36,4 @@ [Guids]
> > > gEfiRngAlgorithmSp80090Ctr256Guid
> > > gEfiRngAlgorithmSp80090Hash256Guid
> > > gEfiRngAlgorithmSp80090Hmac256Guid
> > > + gEfiRngAlgorithmRaw
> > > --
> > > 2.25.1
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109324): https://edk2.groups.io/g/devel/message/109324
Mute This Topic: https://groups.io/mt/101656295/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-10-04 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 12:29 [edk2-devel] [PATCH 1/1] MdePkg/DxeRngLib: Add missing GUID declaration in inf PierreGondois
2023-09-29 13:08 ` Sami Mujawar
2023-10-03 17:21 ` Leif Lindholm
2023-10-04 14:56 ` Ard Biesheuvel
2023-10-04 15:30 ` Leif Lindholm [this message]
[not found] ` <178AF13EF9A477DA.4010@groups.io>
2023-10-04 16:09 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZR2FJNESTib4WhRd@qc-i7.hemma.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox