* [edk2-devel] [PATCH 1/1] MdePkg/DxeRngLib: Add missing GUID declaration in inf
@ 2023-09-29 12:29 PierreGondois
2023-09-29 13:08 ` Sami Mujawar
0 siblings, 1 reply; 6+ messages in thread
From: PierreGondois @ 2023-09-29 12:29 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Liming Gao, Sami Mujawar
From: Pierre Gondois <pierre.gondois@arm.com>
Add missing GUID declaration in DxeRngLib.inf.
Fixes: bd1f0eecc1df ("MdePkg/DxeRngLib: Request raw algorithm
instead of default")
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
MdePkg/Library/DxeRngLib/DxeRngLib.inf | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdePkg/Library/DxeRngLib/DxeRngLib.inf b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
index 9c11959f8aeb..281fec46502f 100644
--- a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
+++ b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
@@ -36,3 +36,4 @@ [Guids]
gEfiRngAlgorithmSp80090Ctr256Guid
gEfiRngAlgorithmSp80090Hash256Guid
gEfiRngAlgorithmSp80090Hmac256Guid
+ gEfiRngAlgorithmRaw
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109196): https://edk2.groups.io/g/devel/message/109196
Mute This Topic: https://groups.io/mt/101656295/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg/DxeRngLib: Add missing GUID declaration in inf
2023-09-29 12:29 [edk2-devel] [PATCH 1/1] MdePkg/DxeRngLib: Add missing GUID declaration in inf PierreGondois
@ 2023-09-29 13:08 ` Sami Mujawar
2023-10-03 17:21 ` Leif Lindholm
0 siblings, 1 reply; 6+ messages in thread
From: Sami Mujawar @ 2023-09-29 13:08 UTC (permalink / raw)
To: Pierre Gondois, devel@edk2.groups.io, Liming Gao,
Michael D Kinney; +Cc: nd
Hi Pierre,
Thank you for this fix.
Unfortunately, this did not get trapped by the edk2 CI as well.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 29/09/2023, 13:30, "pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>" <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>> wrote:
From: Pierre Gondois <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>>
Add missing GUID declaration in DxeRngLib.inf.
Fixes: bd1f0eecc1df ("MdePkg/DxeRngLib: Request raw algorithm
instead of default")
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com <mailto:Pierre.Gondois@arm.com>>
---
MdePkg/Library/DxeRngLib/DxeRngLib.inf | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdePkg/Library/DxeRngLib/DxeRngLib.inf b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
index 9c11959f8aeb..281fec46502f 100644
--- a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
+++ b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
@@ -36,3 +36,4 @@ [Guids]
gEfiRngAlgorithmSp80090Ctr256Guid
gEfiRngAlgorithmSp80090Hash256Guid
gEfiRngAlgorithmSp80090Hmac256Guid
+ gEfiRngAlgorithmRaw
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109197): https://edk2.groups.io/g/devel/message/109197
Mute This Topic: https://groups.io/mt/101656295/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg/DxeRngLib: Add missing GUID declaration in inf
2023-09-29 13:08 ` Sami Mujawar
@ 2023-10-03 17:21 ` Leif Lindholm
2023-10-04 14:56 ` Ard Biesheuvel
0 siblings, 1 reply; 6+ messages in thread
From: Leif Lindholm @ 2023-10-03 17:21 UTC (permalink / raw)
To: devel, sami.mujawar
Cc: Pierre Gondois, Liming Gao, Michael D Kinney, nd, Zhiguang Liu
+Zhiguang
Tested-by: Leif Lindholm <quic_llindhol@quicinc.com>
MdePkg maintainers - this is currently breaking several platforms in
edk2-platforms.
Regards,
Leif
On Fri, Sep 29, 2023 at 13:08:50 +0000, Sami Mujawar wrote:
> Hi Pierre,
>
> Thank you for this fix.
>
> Unfortunately, this did not get trapped by the edk2 CI as well.
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
>
> On 29/09/2023, 13:30, "pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>" <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>> wrote:
>
>
> From: Pierre Gondois <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>>
>
>
> Add missing GUID declaration in DxeRngLib.inf.
>
>
> Fixes: bd1f0eecc1df ("MdePkg/DxeRngLib: Request raw algorithm
> instead of default")
>
>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com <mailto:Pierre.Gondois@arm.com>>
> ---
> MdePkg/Library/DxeRngLib/DxeRngLib.inf | 1 +
> 1 file changed, 1 insertion(+)
>
>
> diff --git a/MdePkg/Library/DxeRngLib/DxeRngLib.inf b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> index 9c11959f8aeb..281fec46502f 100644
> --- a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> +++ b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> @@ -36,3 +36,4 @@ [Guids]
> gEfiRngAlgorithmSp80090Ctr256Guid
> gEfiRngAlgorithmSp80090Hash256Guid
> gEfiRngAlgorithmSp80090Hmac256Guid
> + gEfiRngAlgorithmRaw
> --
> 2.25.1
>
>
>
>
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109297): https://edk2.groups.io/g/devel/message/109297
Mute This Topic: https://groups.io/mt/101656295/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg/DxeRngLib: Add missing GUID declaration in inf
2023-10-03 17:21 ` Leif Lindholm
@ 2023-10-04 14:56 ` Ard Biesheuvel
2023-10-04 15:30 ` Leif Lindholm
[not found] ` <178AF13EF9A477DA.4010@groups.io>
0 siblings, 2 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2023-10-04 14:56 UTC (permalink / raw)
To: devel, quic_llindhol
Cc: sami.mujawar, Pierre Gondois, Liming Gao, Michael D Kinney, nd,
Zhiguang Liu
On Tue, 3 Oct 2023 at 17:22, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
>
> +Zhiguang
>
> Tested-by: Leif Lindholm <quic_llindhol@quicinc.com>
>
> MdePkg maintainers - this is currently breaking several platforms in
> edk2-platforms.
>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Please just merge this - it is an obvious and trivial bugfix, and it
is affecting multiple platforms.
> On Fri, Sep 29, 2023 at 13:08:50 +0000, Sami Mujawar wrote:
> > Hi Pierre,
> >
> > Thank you for this fix.
> >
> > Unfortunately, this did not get trapped by the edk2 CI as well.
> >
> > Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> >
> > Regards,
> >
> > Sami Mujawar
> >
> > On 29/09/2023, 13:30, "pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>" <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>> wrote:
> >
> >
> > From: Pierre Gondois <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>>
> >
> >
> > Add missing GUID declaration in DxeRngLib.inf.
> >
> >
> > Fixes: bd1f0eecc1df ("MdePkg/DxeRngLib: Request raw algorithm
> > instead of default")
> >
> >
> > Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com <mailto:Pierre.Gondois@arm.com>>
> > ---
> > MdePkg/Library/DxeRngLib/DxeRngLib.inf | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >
> > diff --git a/MdePkg/Library/DxeRngLib/DxeRngLib.inf b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > index 9c11959f8aeb..281fec46502f 100644
> > --- a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > +++ b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > @@ -36,3 +36,4 @@ [Guids]
> > gEfiRngAlgorithmSp80090Ctr256Guid
> > gEfiRngAlgorithmSp80090Hash256Guid
> > gEfiRngAlgorithmSp80090Hmac256Guid
> > + gEfiRngAlgorithmRaw
> > --
> > 2.25.1
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109322): https://edk2.groups.io/g/devel/message/109322
Mute This Topic: https://groups.io/mt/101656295/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg/DxeRngLib: Add missing GUID declaration in inf
2023-10-04 14:56 ` Ard Biesheuvel
@ 2023-10-04 15:30 ` Leif Lindholm
[not found] ` <178AF13EF9A477DA.4010@groups.io>
1 sibling, 0 replies; 6+ messages in thread
From: Leif Lindholm @ 2023-10-04 15:30 UTC (permalink / raw)
To: devel, ardb
Cc: sami.mujawar, Pierre Gondois, Liming Gao, Michael D Kinney, nd,
Zhiguang Liu
On Wed, Oct 04, 2023 at 14:56:55 +0000, Ard Biesheuvel wrote:
> On Tue, 3 Oct 2023 at 17:22, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
> >
> > +Zhiguang
> >
> > Tested-by: Leif Lindholm <quic_llindhol@quicinc.com>
> >
> > MdePkg maintainers - this is currently breaking several platforms in
> > edk2-platforms.
> >
>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>
> Please just merge this - it is an obvious and trivial bugfix, and it
> is affecting multiple platforms.
Yeah, good call.
I've submitted it as https://github.com/tianocore/edk2/pull/4887
/
Leif
> > On Fri, Sep 29, 2023 at 13:08:50 +0000, Sami Mujawar wrote:
> > > Hi Pierre,
> > >
> > > Thank you for this fix.
> > >
> > > Unfortunately, this did not get trapped by the edk2 CI as well.
> > >
> > > Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> > >
> > > Regards,
> > >
> > > Sami Mujawar
> > >
> > > On 29/09/2023, 13:30, "pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>" <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>> wrote:
> > >
> > >
> > > From: Pierre Gondois <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>>
> > >
> > >
> > > Add missing GUID declaration in DxeRngLib.inf.
> > >
> > >
> > > Fixes: bd1f0eecc1df ("MdePkg/DxeRngLib: Request raw algorithm
> > > instead of default")
> > >
> > >
> > > Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com <mailto:Pierre.Gondois@arm.com>>
> > > ---
> > > MdePkg/Library/DxeRngLib/DxeRngLib.inf | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > >
> > > diff --git a/MdePkg/Library/DxeRngLib/DxeRngLib.inf b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > > index 9c11959f8aeb..281fec46502f 100644
> > > --- a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > > +++ b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > > @@ -36,3 +36,4 @@ [Guids]
> > > gEfiRngAlgorithmSp80090Ctr256Guid
> > > gEfiRngAlgorithmSp80090Hash256Guid
> > > gEfiRngAlgorithmSp80090Hmac256Guid
> > > + gEfiRngAlgorithmRaw
> > > --
> > > 2.25.1
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109324): https://edk2.groups.io/g/devel/message/109324
Mute This Topic: https://groups.io/mt/101656295/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg/DxeRngLib: Add missing GUID declaration in inf
[not found] ` <178AF13EF9A477DA.4010@groups.io>
@ 2023-10-04 16:09 ` Leif Lindholm
0 siblings, 0 replies; 6+ messages in thread
From: Leif Lindholm @ 2023-10-04 16:09 UTC (permalink / raw)
To: devel
Cc: ardb, sami.mujawar, Pierre Gondois, Liming Gao, Michael D Kinney,
nd, Zhiguang Liu
On Wed, Oct 04, 2023 at 16:30:44 +0100, Leif Lindholm wrote:
> On Wed, Oct 04, 2023 at 14:56:55 +0000, Ard Biesheuvel wrote:
> > On Tue, 3 Oct 2023 at 17:22, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
> > >
> > > +Zhiguang
> > >
> > > Tested-by: Leif Lindholm <quic_llindhol@quicinc.com>
> > >
> > > MdePkg maintainers - this is currently breaking several platforms in
> > > edk2-platforms.
> > >
> >
> > Acked-by: Ard Biesheuvel <ardb@kernel.org>
> >
> > Please just merge this - it is an obvious and trivial bugfix, and it
> > is affecting multiple platforms.
>
> Yeah, good call.
> I've submitted it as https://github.com/tianocore/edk2/pull/4887
Merged as d073a5451191.
/
Leif
> > > On Fri, Sep 29, 2023 at 13:08:50 +0000, Sami Mujawar wrote:
> > > > Hi Pierre,
> > > >
> > > > Thank you for this fix.
> > > >
> > > > Unfortunately, this did not get trapped by the edk2 CI as well.
> > > >
> > > > Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> > > >
> > > > Regards,
> > > >
> > > > Sami Mujawar
> > > >
> > > > On 29/09/2023, 13:30, "pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>" <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>> wrote:
> > > >
> > > >
> > > > From: Pierre Gondois <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>>
> > > >
> > > >
> > > > Add missing GUID declaration in DxeRngLib.inf.
> > > >
> > > >
> > > > Fixes: bd1f0eecc1df ("MdePkg/DxeRngLib: Request raw algorithm
> > > > instead of default")
> > > >
> > > >
> > > > Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com <mailto:Pierre.Gondois@arm.com>>
> > > > ---
> > > > MdePkg/Library/DxeRngLib/DxeRngLib.inf | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > >
> > > > diff --git a/MdePkg/Library/DxeRngLib/DxeRngLib.inf b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > > > index 9c11959f8aeb..281fec46502f 100644
> > > > --- a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > > > +++ b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > > > @@ -36,3 +36,4 @@ [Guids]
> > > > gEfiRngAlgorithmSp80090Ctr256Guid
> > > > gEfiRngAlgorithmSp80090Hash256Guid
> > > > gEfiRngAlgorithmSp80090Hmac256Guid
> > > > + gEfiRngAlgorithmRaw
> > > > --
> > > > 2.25.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109326): https://edk2.groups.io/g/devel/message/109326
Mute This Topic: https://groups.io/mt/101656295/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-10-04 16:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-29 12:29 [edk2-devel] [PATCH 1/1] MdePkg/DxeRngLib: Add missing GUID declaration in inf PierreGondois
2023-09-29 13:08 ` Sami Mujawar
2023-10-03 17:21 ` Leif Lindholm
2023-10-04 14:56 ` Ard Biesheuvel
2023-10-04 15:30 ` Leif Lindholm
[not found] ` <178AF13EF9A477DA.4010@groups.io>
2023-10-04 16:09 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox