From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: "Xing, Eric" <Eric.Xing@amd.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Michael D Kinney <michael.d.kinney@intel.com>,
"Attar, AbdulLateef (Abdul Lateef)" <AbdulLateef.Attar@amd.com>,
"Chang, Abner" <Abner.Chang@amd.com>
Subject: Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh
Date: Thu, 28 Sep 2023 18:39:07 +0100 [thread overview]
Message-ID: <ZRW6O5nQH047O6cM@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <PH0PR12MB563110D2430C87856BC855DFF6C1A@PH0PR12MB5631.namprd12.prod.outlook.com>
Hi Eric,
Thanks.
You didn't really need to rework the patch, but I do want to see the
Reviewed-by's from the other added people before merging.
Best Regards,
Leif
On Thu, Sep 28, 2023 at 17:13:36 +0000, Xing, Eric wrote:
> [AMD Official Use Only - General]
>
> Thanks Leif for your quick response and reminder. I added Abner as CC in PATCH v2.
> Sorry troubling you, would you help review it again so I can get your approved with v2 patch? Thanks again.
>
> Eric
>
> -----Original Message-----
> From: Leif Lindholm <quic_llindhol@quicinc.com>
> Sent: Friday, September 29, 2023 12:15 AM
> To: Xing, Eric <Eric.Xing@amd.com>
> Cc: devel@edk2.groups.io; Michael D Kinney <michael.d.kinney@intel.com>; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> Subject: Re: [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh
>
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> +Abner
>
> Looks fine to me, but I'd like to have a Reviewed-by from Abner, Abdul, Duke.
>
> Best Regards,
>
> Leif
>
> On Thu, Sep 28, 2023 at 22:30:53 +0800, eric.xing@amd.com wrote:
> > From: Eric Xing <Eric.Xing@amd.com>
> >
> > Signed-off-by: Eric Xing <eric.xing@amd.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Abdul Lateef Attar <abdattar@amd.com>
> > Signed-off-by: Eric Xing <Eric.Xing@amd.com>
> > ---
> > Maintainers.txt | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt index c42d135..1d5dacb
> > 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -58,6 +58,15 @@ Platform/Intel/CometlakeSiliconBinPkg
> > M: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> > M: Sai Chaganty <rangasai.v.chaganty@intel.com>
> >
> > +Silicon/AMD
> > +M: Abner Chang <abner.chang@amd.com>
> > +M: Abdul Lateef Attar <abdattar@amd.com>
> > +M: Eric Xing <eric.xing@amd.com>
> > +
> > +Silicon/AMD/Vangogh
> > +M: Duke Zhai <duke.zhai@amd.com>
> > +M: Eric Xing <eric.xing@amd.com>
> > +
> > Silicon/Ampere/AmpereAltraBinPkg
> > M: Nhi Pham <nhi@os.amperecomputing.com>
> > M: Vu Nguyen <vunguyen@os.amperecomputing.com>
> > --
> > 2.17.1
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109172): https://edk2.groups.io/g/devel/message/109172
Mute This Topic: https://groups.io/mt/101638924/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-09-28 17:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 14:30 [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh eric.xing via groups.io
2023-09-28 14:30 ` [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 2/2] Silicon/AMD: Add VanGogh Silicon initialization firmware binaries eric.xing via groups.io
2023-09-28 15:22 ` Chang, Abner via groups.io
2023-09-28 16:18 ` Xing, Eric via groups.io
2023-09-28 15:18 ` [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh Chang, Abner via groups.io
2023-09-28 16:20 ` Xing, Eric via groups.io
2023-09-28 16:15 ` Leif Lindholm
2023-09-28 17:13 ` Xing, Eric via groups.io
2023-09-28 17:39 ` Leif Lindholm [this message]
2023-09-29 9:09 ` Chang, Abner via groups.io
2023-09-29 10:48 ` Leif Lindholm
2023-09-29 14:52 ` Chang, Abner via groups.io
2023-09-29 15:30 ` Leif Lindholm
2023-09-29 16:17 ` Chang, Abner via groups.io
2023-09-30 17:35 ` Zhai, MingXin (Duke) via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRW6O5nQH047O6cM@qc-i7.hemma.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox