From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D3AA1941424 for ; Fri, 29 Sep 2023 10:48:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=yU4XyNRryIyEh+heBEH8u/2ZntCWnBV/cVxMb5T6CQs=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1695984524; v=1; b=VzqK9MmQrnjDZgJhMSZEsjQGIF52jBmXeo6l3bY8bjuOhWNdLhYYENNUy9MnJZugMygPuKL4 0POCWL3o3kGqRKZpNqkeN/u0aHQKqD2shpVBrOvttUTKCXyd4yF25106+lawpYv4RWFWeWmR7pV Am8fqJ1rOkYc4Hm2Pj/7ERCM= X-Received: by 127.0.0.2 with SMTP id GR3OYY7687511xyplIY2RmwA; Fri, 29 Sep 2023 03:48:44 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.14484.1695984524075783662 for ; Fri, 29 Sep 2023 03:48:44 -0700 X-Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38T9fteU023563; Fri, 29 Sep 2023 10:48:42 GMT X-Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3td3ggb8k0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Sep 2023 10:48:41 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38TAmfQ7019707 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Sep 2023 10:48:41 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Fri, 29 Sep 2023 03:48:39 -0700 Date: Fri, 29 Sep 2023 11:48:36 +0100 From: "Leif Lindholm" To: "Chang, Abner" CC: "Xing, Eric" , "devel@edk2.groups.io" , Michael D Kinney , "Attar, AbdulLateef (Abdul Lateef)" Subject: Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh Message-ID: References: <20230928143054.4039-1-eric.xing@amd.com> MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: 31_Z53VdEgVFWl07rdcP0Q2lQ8GZhm1Q X-Proofpoint-ORIG-GUID: 31_Z53VdEgVFWl07rdcP0Q2lQ8GZhm1Q Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kOS8T5MBL1ANU63PtZwgmnMsx7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=VzqK9MmQ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Abner, On Fri, Sep 29, 2023 at 09:09:25 +0000, Chang, Abner wrote: > We have done the review on these patches. Still waiting for an R-b from Duke. Hmm, who doesn't seem to have been cc:d. > Are you the steward of this repo and able to grant AMD folks the > merge privilege? To Eric, Abdul and me. I'm not a github admin - Mike? But that reminds me, we should start adding github IDs in [] brackets after email, like we do for edk2/edk2-platforms. > Btw, do we have to create a PR against non OSI repo for merging or > we can just push it? Just push. But send out for review first. Are any of you attending the plugfest? If more maintainers are joining edk2-non-osi, maybe we should have a proper chat about it. Regards, Leif > Get Outlook for Android > ________________________________ > From: Leif Lindholm > Sent: Friday, September 29, 2023 1:39:07 AM > To: Xing, Eric > Cc: devel@edk2.groups.io ; Michael D Kinney ; Attar, AbdulLateef (Abdul Lateef) ; Chang, Abner > Subject: Re: [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh > > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > Hi Eric, > > Thanks. > You didn't really need to rework the patch, but I do want to see the > Reviewed-by's from the other added people before merging. > > Best Regards, > > Leif > > On Thu, Sep 28, 2023 at 17:13:36 +0000, Xing, Eric wrote: > > [AMD Official Use Only - General] > > > > Thanks Leif for your quick response and reminder. I added Abner as CC in PATCH v2. > > Sorry troubling you, would you help review it again so I can get your approved with v2 patch? Thanks again. > > > > Eric > > > > -----Original Message----- > > From: Leif Lindholm > > Sent: Friday, September 29, 2023 12:15 AM > > To: Xing, Eric > > Cc: devel@edk2.groups.io; Michael D Kinney ; Attar, AbdulLateef (Abdul Lateef) > > Subject: Re: [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh > > > > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > > > > +Abner > > > > Looks fine to me, but I'd like to have a Reviewed-by from Abner, Abdul, Duke. > > > > Best Regards, > > > > Leif > > > > On Thu, Sep 28, 2023 at 22:30:53 +0800, eric.xing@amd.com wrote: > > > From: Eric Xing > > > > > > Signed-off-by: Eric Xing > > > Cc: Michael D Kinney > > > Cc: Leif Lindholm > > > Cc: Abdul Lateef Attar > > > Signed-off-by: Eric Xing > > > --- > > > Maintainers.txt | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/Maintainers.txt b/Maintainers.txt index c42d135..1d5dacb > > > 100644 > > > --- a/Maintainers.txt > > > +++ b/Maintainers.txt > > > @@ -58,6 +58,15 @@ Platform/Intel/CometlakeSiliconBinPkg > > > M: Kathappan Esakkithevar > > > M: Sai Chaganty > > > > > > +Silicon/AMD > > > +M: Abner Chang > > > +M: Abdul Lateef Attar > > > +M: Eric Xing > > > + > > > +Silicon/AMD/Vangogh > > > +M: Duke Zhai > > > +M: Eric Xing > > > + > > > Silicon/Ampere/AmpereAltraBinPkg > > > M: Nhi Pham > > > M: Vu Nguyen > > > -- > > > 2.17.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109192): https://edk2.groups.io/g/devel/message/109192 Mute This Topic: https://groups.io/mt/101638924/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-