From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A1C147803D0 for ; Tue, 3 Oct 2023 10:43:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=aikZ64ihkSqcyIo4tM0EMH8dqQe5oyXW3KexZ/pIklg=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20140610; t=1696329796; v=1; b=Ib0bLMcqqLKxN8SYcRkBeq6vAw02cZ3AhuTspmGTz5fsH1Kddms5Y7HW7farG5D8l3N4/bFg 9k7MqJELlwTNZIfUm6Oc/uOiQ13crWbybJiqdWiD2F1cPssXlJ1pprjzgqueGaANGYM/keCRIgD LHPJfYD9gLv/nE9dvkW9r0II= X-Received: by 127.0.0.2 with SMTP id O2rGYY7687511x1yzfBMbgTh; Tue, 03 Oct 2023 03:43:16 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.104982.1696329795658667259 for ; Tue, 03 Oct 2023 03:43:15 -0700 X-Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3936dExB008201; Tue, 3 Oct 2023 10:43:12 GMT X-Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3teb0sdr8g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Oct 2023 10:43:12 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 393AhBBs021410 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 Oct 2023 10:43:11 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Tue, 3 Oct 2023 03:43:09 -0700 Date: Tue, 3 Oct 2023 11:43:06 +0100 From: "Leif Lindholm" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= CC: , Ard Biesheuvel , Sami Mujawar Subject: Re: [edk2-devel] [PATCH v2 3/5] MdePkg/BaseLib: use normal register init in ARM SetJump implementations Message-ID: References: <20230926171523.368706-1-quic_llindhol@quicinc.com> <20230926171523.368706-4-quic_llindhol@quicinc.com> MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: O1_a1nSuCltQZab0l3xKkILP4F_7nY01 X-Proofpoint-ORIG-GUID: O1_a1nSuCltQZab0l3xKkILP4F_7nY01 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 3936dExB008201 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 6PbZlz128JAlcxCqV6Q9CVgux7686176AA= Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Ib0bLMcq; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Oct 02, 2023 at 20:00:21 +0200, Philippe Mathieu-Daud=E9 wrote: > Hi Leif, >=20 > On 26/9/23 19:15, Leif Lindholm wrote: > > There may be architectures on which there are benefits to > > eor r0, r0(, r0) > > but ARM was never one of them. Change to more readable > > mov r0, #0 > > instead. > >=20 > > Signed-off-by: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Sami Mujawar > > --- > > MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S | 2 +- > > MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 >=20 > > diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm b/MdePkg/Li= brary/BaseLib/Arm/SetJumpLongJump.asm > > index e1eff758f7ab..ef02d85e0e66 100644 > > --- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm > > +++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm > > @@ -33,7 +33,7 @@ > > SetJump > > MOV R3, R13 > > STM R0, {R3-R12,R14} > > - EOR R0, R0 > > + MOV RO, #0 >=20 > Hmm. s/RO/R0/ ? Hmm, what? I know for a fact I spotted that while importing the v1, and fixed it. No idea how I managed to unfix it. Too late, already got merged. Sent a fix out. Hmm ... I think this says something about non-gcc/clang support for (32-bit) Arm. Are we getting to the point where we might want to retire it? Thanks! / Leif > > BX LR > > ;/** >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109277): https://edk2.groups.io/g/devel/message/109277 Mute This Topic: https://groups.io/mt/101600809/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-