From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: <devel@edk2.groups.io>, <marcin.juszkiewicz@linaro.org>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Graeme Gregory <graeme@xora.org.uk>
Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/SbsaQemu: add NVME support
Date: Tue, 3 Oct 2023 18:36:59 +0100 [thread overview]
Message-ID: <ZRxRO+8uPPy8Zv5Z@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <20231003162144.510852-1-marcin.juszkiewicz@linaro.org>
On Tue, Oct 03, 2023 at 18:21:44 +0200, Marcin Juszkiewicz wrote:
> It is weird that I can have NVME, can install OS on it but cannot boot
> from it.
>
> This change adds NVME support so it can be mapped and used.
Oops, that's a silly thing to have left out.
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
Pushed as d6e36a151ff8.
Thanks!
/
Leif
> ---
> Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 6 ++++++
> Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 5 +++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> index 948e42326c33..36723e21d7b5 100644
> --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> @@ -738,6 +738,12 @@ [Components.common]
> MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
> MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
>
> + #
> + # NVME support
> + #
> +
> + MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
> +
> #
> # Video support (VGA)
> #
> diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
> index 6bc55d701120..6fcfd25faaeb 100644
> --- a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
> +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
> @@ -251,6 +251,11 @@ [FV.FvMain]
> INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
> INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
>
> + #
> + # NVME support
> + #
> + INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
> +
> #
> # USB Support
> #
> --
> 2.41.0
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109298): https://edk2.groups.io/g/devel/message/109298
Mute This Topic: https://groups.io/mt/101737251/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-10-03 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 16:21 [edk2-devel] [PATCH edk2-platforms 1/1] Platform/SbsaQemu: add NVME support Marcin Juszkiewicz
2023-10-03 17:36 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRxRO+8uPPy8Zv5Z@qc-i7.hemma.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox