[edk2-devel] [PATCH edk2-platforms 1/1] Platform/SbsaQemu: add NVME support

[edk2-devel] [PATCH edk2-platforms 1/1] Platform/SbsaQemu: add NVME support

[Marcin Juszkiewicz]

It is weird that I can have NVME, can install OS on it but cannot boot
from it.

This change adds NVME support so it can be mapped and used.

Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 6 ++++++
 Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 5 +++++
 2 files changed, 11 insertions(+)

diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index 948e42326c33..36723e21d7b5 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
@@ -738,6 +738,12 @@ [Components.common]
   MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
   MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
 
+  #
+  # NVME support
+  #
+
+  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
+
   #
   # Video support (VGA)
   #
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
index 6bc55d701120..6fcfd25faaeb 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
@@ -251,6 +251,11 @@ [FV.FvMain]
   INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
   INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
 
+  #
+  # NVME support
+  #
+  INF  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
+
   #
   # USB Support
   #
-- 
2.41.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109295): https://edk2.groups.io/g/devel/message/109295
Mute This Topic: https://groups.io/mt/101737251/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/SbsaQemu: add NVME support

[Leif Lindholm]

On Tue, Oct 03, 2023 at 18:21:44 +0200, Marcin Juszkiewicz wrote:
> It is weird that I can have NVME, can install OS on it but cannot boot
> from it.
> 
> This change adds NVME support so it can be mapped and used.

Oops, that's a silly thing to have left out.

> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>

Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
Pushed as d6e36a151ff8.

Thanks!

/
    Leif

> ---
>  Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 6 ++++++
>  Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 5 +++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> index 948e42326c33..36723e21d7b5 100644
> --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> @@ -738,6 +738,12 @@ [Components.common]
>    MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
>    MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
>  
> +  #
> +  # NVME support
> +  #
> +
> +  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
> +
>    #
>    # Video support (VGA)
>    #
> diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
> index 6bc55d701120..6fcfd25faaeb 100644
> --- a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
> +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
> @@ -251,6 +251,11 @@ [FV.FvMain]
>    INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
>    INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
>  
> +  #
> +  # NVME support
> +  #
> +  INF  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
> +
>    #
>    # USB Support
>    #
> -- 
> 2.41.0
> 
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109298): https://edk2.groups.io/g/devel/message/109298
Mute This Topic: https://groups.io/mt/101737251/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-