From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 169BAD806DA for ; Tue, 3 Oct 2023 17:37:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ImkQzxNz+She4a5r1Gno++Gen54hV/PVdEs9G88vV/I=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1696354625; v=1; b=iVsye1qSZW29VePWopf7iWpx9bOJ6XT2D0h/t58OlaV7+vT4NJK3FVKsIlzdKfIaNhvGjRGr M0h4gEMtJdSaVycarmjF45L9BbXhvsqhPl1/ACGv7TXoiFIeaHh8XZkJNcp4FIE1giusmsb81nW s52hAKN5Da8zVQueTBRU9+40= X-Received: by 127.0.0.2 with SMTP id wDg0YY7687511xbOWFnF5Gig; Tue, 03 Oct 2023 10:37:05 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.114966.1696354625245623754 for ; Tue, 03 Oct 2023 10:37:05 -0700 X-Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 393H7nvZ004062; Tue, 3 Oct 2023 17:37:05 GMT X-Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tgbjkssh6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Oct 2023 17:37:04 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 393Hb4JG017212 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 Oct 2023 17:37:04 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Tue, 3 Oct 2023 10:37:02 -0700 Date: Tue, 3 Oct 2023 18:36:59 +0100 From: "Leif Lindholm" To: , CC: Ard Biesheuvel , Graeme Gregory Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/SbsaQemu: add NVME support Message-ID: References: <20231003162144.510852-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 In-Reply-To: <20231003162144.510852-1-marcin.juszkiewicz@linaro.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: NsvdrGda6qyDUCIs4sTpNoFB4LA9WVXY X-Proofpoint-ORIG-GUID: NsvdrGda6qyDUCIs4sTpNoFB4LA9WVXY Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: WAoD9KYU7oWgiC6JA4kcOFRCx7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=iVsye1qS; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none) On Tue, Oct 03, 2023 at 18:21:44 +0200, Marcin Juszkiewicz wrote: > It is weird that I can have NVME, can install OS on it but cannot boot > from it. > > This change adds NVME support so it can be mapped and used. Oops, that's a silly thing to have left out. > Signed-off-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm Pushed as d6e36a151ff8. Thanks! / Leif > --- > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 6 ++++++ > Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 5 +++++ > 2 files changed, 11 insertions(+) > > diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc > index 948e42326c33..36723e21d7b5 100644 > --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc > +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc > @@ -738,6 +738,12 @@ [Components.common] > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > > + # > + # NVME support > + # > + > + MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > + > # > # Video support (VGA) > # > diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf > index 6bc55d701120..6fcfd25faaeb 100644 > --- a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf > +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf > @@ -251,6 +251,11 @@ [FV.FvMain] > INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > > + # > + # NVME support > + # > + INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > + > # > # USB Support > # > -- > 2.41.0 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109298): https://edk2.groups.io/g/devel/message/109298 Mute This Topic: https://groups.io/mt/101737251/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-