From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1EDCFD80A38 for ; Wed, 18 Oct 2023 12:21:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=W/FwDQk9/SzBvY2D/cJGq+XfurZKbYL4MZu9TkGr/VQ=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20140610; t=1697631681; v=1; b=jh3B1//sexlZQLZYvQ4M3v7JsdTpWSNez9Dq2mmMiHnbLZ0/SJcJ6rScAj/ej8p/WsE5MLqx ZFxYATSEyb2ChIuAGYzO00ZYF9leqaQPHPiMa8ydOlEMyecz7SW2peUnxOkPKmyAbp1K94j2V88 9KgsSuSnRDnVqvXcH4QzYK+A= X-Received: by 127.0.0.2 with SMTP id c8lNYY7687511xwgEMJdrJE8; Wed, 18 Oct 2023 05:21:21 -0700 X-Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mx.groups.io with SMTP id smtpd.web10.280281.1697631681110158416 for ; Wed, 18 Oct 2023 05:21:21 -0700 X-Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-27d23f1e3b8so5102268a91.1 for ; Wed, 18 Oct 2023 05:21:21 -0700 (PDT) X-Gm-Message-State: mSx8rAGpHxFkrjK8EalYxVpwx7686176AA= X-Google-Smtp-Source: AGHT+IEO8k5qg5iKQ2UeN+K1XAjqE5Xc4i6fsuJTsp02a/akd66CSPnADzViC3/oQr26XKuehbxw4g== X-Received: by 2002:a17:90a:1a51:b0:27d:1f9f:a57f with SMTP id 17-20020a17090a1a5100b0027d1f9fa57fmr5208529pjl.32.1697631680078; Wed, 18 Oct 2023 05:21:20 -0700 (PDT) X-Received: from sunil-laptop ([106.51.188.78]) by smtp.gmail.com with ESMTPSA id cx3-20020a17090afd8300b0026d4100e0e8sm1206051pjb.10.2023.10.18.05.21.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 05:21:19 -0700 (PDT) Date: Wed, 18 Oct 2023 17:51:13 +0530 From: "Sunil V L" To: devel@edk2.groups.io, lersek@redhat.com Cc: =?utf-8?B?6JSh6Zuo5pm0?= , USER0FISH , Leif Lindholm , Michael D Kinney , Inochi Amaoto , Ard Biesheuvel Subject: Re: [edk2-devel] [PATCH edk2-platforms v5 7/7] Sophgo/SG2042Pkg: Add platform readme and document. Message-ID: References: <022a1dd866233cd1d2ae518f91720487f7569b34.1697120122.git.caiyuqing_hz@outlook.com> <67438e36.2d9.18b428542db.Coremail.caiyuqing_hz@163.com> <093ea77b-ae2a-8ffb-5646-9c1ddea87575@redhat.com> MIME-Version: 1.0 In-Reply-To: <093ea77b-ae2a-8ffb-5646-9c1ddea87575@redhat.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="jh3B1//s"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none On Wed, Oct 18, 2023 at 02:11:17PM +0200, Laszlo Ersek wrote: > On 10/18/23 13:21, 蔡雨晴 wrote: > > Hi Laszlo, > > > > Thank you for your comments. I will commit a new patch to add the > > maintainers to the "Maintainers.txt" file in the root directory of the > > edk2-platforms project. > > > > Please let us know if you have more suggestions. > > I do have one, but it's not specifically for this patch set, but for all > future edk2(-platforms) patches you may post -- please add "--stat=1000 > --stat-graph-width=20" to your git-format-patch command line. > Edk2(-platforms) use(s) long pathnames, and so the cumulative diffstat > tends to be truncated, and on the left side at that. That fact makes it > hard to see the extent of a patchset. If you add these options, then the > cumulative diffstat is going to be just as wide as it needs to be -- no > truncation, and no needless padding. > > The "BaseTools/Scripts/SetupGit.py" utility creates a git-format-patch > alias called "fp" that includes these options. > > BTW I could help Ard out by pushing this patch set (well, v4, with the > Maintainers.txt fix), I'm just not clear when a patch set counts as > "sufficiently reviewed" for edk2-platforms. > > Laszlo > Hi Laszlo, I have pushed the v5 series since they looked decent. Leif had given some feedback which are taken care and they looked decent. Maintainer entry needs to be added as separate patch. I know there are further improvements planned. BTW, I have recommended many people to read your guide [1] which I also refer every time. Though few things like Setup.py can be added, I found your document is really good for any one working on EDK2 patches. Thanks! [1] - https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers > > > > Thanks, > > Yuqing Cai > > > > > > > > > > > > At 2023-10-18 17:47:04, "Laszlo Ersek" wrote: > >>On 10/13/23 05:03, caiyuqing_hz@163.com wrote: > >>> diff --git a/Platform/Sophgo/Maintainers.md b/Platform/Sophgo/Maintainers.md > >>> new file mode 100644 > >>> index 000000000000..4cb32c359a31 > >>> --- /dev/null > >>> +++ b/Platform/Sophgo/Maintainers.md > >>> @@ -0,0 +1,105 @@ > >>> +##Project Name: EDK2 Sophgo SG2042 > >>> + > >>> +##Maintainers: > >>> +1. dahogn - dahogn@hotmail.com > >>> +2. caiyuqing379 - > >>> +3. meng-cz - mengcz1126@gmail.com > >>> +4. USER0FISH - > >>> + > >> > >>This "Platform/Sophgo/Maintainers.md" file / format is useless with > >>edk2's "BaseTools/Scripts/GetMaintainer.py" utility. For that utility to > >>work, you need to add the maintainers to the "Maintainers.txt" file in > >>the edk2-platforms project root dir (... as well). > >> > >>Laszlo > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109742): https://edk2.groups.io/g/devel/message/109742 Mute This Topic: https://groups.io/mt/101944473/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-