From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id ABCF6941076 for ; Fri, 13 Oct 2023 03:51:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=RxRJ0ikBDzIBkgk9S35aopE+5UFa+gU6uxMPhshby7Y=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20140610; t=1697169066; v=1; b=iQYulmRoI2dhZhLLDvgfOe+VgeVU8BIYylZH6WOThE599izeGCQD+fSy6vN1r60CGzEDiJ7M nW4dxxdLPk+dobltAmhq/QQlfpcKxJP30Nq/6rut3Epu1adtn6SWWczYrYMhDApkGKrRWTDMtrC /hR4X4QeqnJmj4mf816mHOMo= X-Received: by 127.0.0.2 with SMTP id kXBaYY7687511x7MIRycemw1; Thu, 12 Oct 2023 20:51:06 -0700 X-Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mx.groups.io with SMTP id smtpd.web10.31466.1697169065633174535 for ; Thu, 12 Oct 2023 20:51:05 -0700 X-Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6b36e1fcee9so95586b3a.3 for ; Thu, 12 Oct 2023 20:51:05 -0700 (PDT) X-Gm-Message-State: OsOosl6QTFgaiGDmvOUACRTcx7686176AA= X-Google-Smtp-Source: AGHT+IHA68jK7rz7uVmuGHOUeVmf3rAvKCmiiaYvMMgzlDuARkgZFK0+gRVLF5Xa7aGvNWTZ3nzjpQ== X-Received: by 2002:a05:6a00:cd6:b0:68e:380c:6b13 with SMTP id b22-20020a056a000cd600b0068e380c6b13mr27801438pfv.15.1697169065060; Thu, 12 Oct 2023 20:51:05 -0700 (PDT) X-Received: from sunil-laptop ([106.51.188.78]) by smtp.gmail.com with ESMTPSA id k14-20020aa792ce000000b006933f85bc29sm12537683pfa.111.2023.10.12.20.50.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 20:51:04 -0700 (PDT) Date: Fri, 13 Oct 2023 09:20:55 +0530 From: "Sunil V L" To: Pedro Falcato Cc: devel@edk2.groups.io, Tuan Phan , ray.ni@intel.com, michael.d.kinney@intel.com, gaoliming@byosoft.com.cn, zhiguang.liu@intel.com, git@danielschaefer.me, andrei.warkentin@intel.com, ardb+tianocore@kernel.org, eric.dong@intel.com, kraxel@redhat.com, rahul1.kumar@intel.com, Dhaval Sharma Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg: RISC-V: MMU: Introduce a PCD for SATP mode Message-ID: References: <20231004183426.5803-1-tphan@ventanamicro.com> MIME-Version: 1.0 In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=iQYulmRo; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, Oct 12, 2023 at 07:29:59PM +0100, Pedro Falcato wrote: > On Thu, Oct 12, 2023 at 1:12 PM Sunil V L wrote: > > > > Hi Ray, > > > > On Wed, Oct 04, 2023 at 11:34:26AM -0700, Tuan Phan wrote: > > > Introduce a PCD to control the maximum SATP mode that MMU allowed > > > to use. This PCD helps RISC-V platform set bare or minimum SATP mode > > > during bring up to debug memory map issue. > > > > > Could you help with review of this? > > It seems glaring to me that Maintainers.txt needs some sort of > > RISCV > F: */*RiscV*/ > > pattern for riscv architectural changes across all packages - I'm not > sure how much value the x86 Intel folks can add to RISCV or ARM code > review and merging, apart from the traditional UEFI/tianocore > feedback. > I agree. For RISC-V only changes, I don't bother the PKG maintainers. But like in this case, UefiCpuPkg.dec is modified, I think it is my duty to make sure PKG maintainers are notified and sufficient time given for them to ACK. I consider "no response" after few days as "no objection" and merge the changes. Thanks, Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109582): https://edk2.groups.io/g/devel/message/109582 Mute This Topic: https://groups.io/mt/101761642/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-