From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8007CAC0F03 for ; Thu, 19 Oct 2023 12:34:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=y2B5ilr37/dTdU498kLOuaIf3vLvLNiiY5qL7g6uLs0=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1697718886; v=1; b=CLlacLOr8pl1HeWs5/oXvQuBTP4YEnllqnjEldZXtPP+E4AqtIiSy1jTWrXJUEY+/r8o6zew hMVbt/wq/OprcOR8B6HPfoICkM0te37BhaT4kqGGTfgzLupblGOU7E8j5rp0BOTfDjpmaYZxqYM qEOqQOak8OlYwSh9WZuY1bR4= X-Received: by 127.0.0.2 with SMTP id xFLVYY7687511xMx9jeZTKau; Thu, 19 Oct 2023 05:34:46 -0700 X-Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mx.groups.io with SMTP id smtpd.web11.26187.1697718885563532955 for ; Thu, 19 Oct 2023 05:34:45 -0700 X-Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1bdf4752c3cso52414475ad.2 for ; Thu, 19 Oct 2023 05:34:45 -0700 (PDT) X-Gm-Message-State: AbviuLW2CLLM7rUAWXwXuJdyx7686176AA= X-Google-Smtp-Source: AGHT+IGXOWXrIUXDgLdoTBhdVOnmREvT9Y52jCWo0gcJ9PT8zOh6NR8pmkpCKHCOOIPk1EhwBOwaGA== X-Received: by 2002:a17:902:778d:b0:1c9:d0a0:ee88 with SMTP id o13-20020a170902778d00b001c9d0a0ee88mr2112195pll.62.1697718884934; Thu, 19 Oct 2023 05:34:44 -0700 (PDT) X-Received: from sunil-laptop ([2409:4071:6e8b:3a98:dd76:4e82:7da6:44ab]) by smtp.gmail.com with ESMTPSA id u2-20020a170902b28200b001b8baa83639sm1826335plr.200.2023.10.19.05.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 05:34:44 -0700 (PDT) Date: Thu, 19 Oct 2023 18:04:38 +0530 From: "Sunil V L" To: John Chew Cc: devel@edk2.groups.io, mindachen1987 Subject: Re: [edk2-devel] [PATCH v1 6/6] StarFive/JH7110Pkg: Add JH7110 Silicon Package Message-ID: References: <20231019025921.1593-1-yuinyee.chew@starfivetech.com> <20231019025921.1593-6-yuinyee.chew@starfivetech.com> MIME-Version: 1.0 In-Reply-To: <20231019025921.1593-6-yuinyee.chew@starfivetech.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CLlacLOr; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi John, On Thu, Oct 19, 2023 at 10:59:21AM +0800, John Chew wrote: > From: mindachen1987 > The patch should have commit message more than one liner. Same comment for PATCH 1/6 and 2/6. Also, there should be a patch in the series to add maintainer entry for your platform. > Cc: Sunil V L > Co-authored-by: John Chew > Signed-off-by: mindachen1987 > --- > Silicon/StarFive/JH7110Pkg/Include/IndustryStandard/JH7110.h | 24 +++++++++++ > Silicon/StarFive/JH7110Pkg/JH7110Pkg.dec | 45 ++++++++++++++++++++ > 2 files changed, 69 insertions(+) > > diff --git a/Silicon/StarFive/JH7110Pkg/Include/IndustryStandard/JH7110.h b/Silicon/StarFive/JH7110Pkg/Include/IndustryStandard/JH7110.h > new file mode 100644 > index 000000000000..b6875f6aa82b > --- /dev/null > +++ b/Silicon/StarFive/JH7110Pkg/Include/IndustryStandard/JH7110.h > @@ -0,0 +1,24 @@ > +/** @file > + * > + * Copyright (c) 2023, StarFive Technology Co., Ltd. All rights reserved.
> + * > + * SPDX-License-Identifier: BSD-2-Clause-Patent > + * > + **/ > + > +#ifndef JH7110_H__ > +#define JH7110_H__ > + > +// #define JH7110_SOC_REGISTERS (FixedPcdGet64 (PcdJH7110RegistersAddress)) > +// #define JH7110_SOC_REGISTER_LENGTH 0x02000000 > + Could you remove these commented code? Thanks, Sunil > +/* Generic PCI addresses */ > +#define PCIE_TOP_OF_MEM_WIN (FixedPcdGet64 (PcdJH7110PciBusMmioAdr)) > +#define PCIE_CPU_MMIO_WINDOW (FixedPcdGet64 (PcdJH7110PciCpuMmioAdr)) > +#define PCIE_BRIDGE_MMIO_LEN (FixedPcdGet32 (PcdJH7110PciBusMmioLen)) > + > +/* PCI root bridge control registers location */ > +#define PCIE_REG_BASE (FixedPcdGet64 (PcdJH7110PciRegBase)) > +#define PCIE_CONFIG_BASE (FixedPcdGet64 (PcdJH7110PciConfigRegBase)) > + > +#endif /* JH7110_H__ */ > diff --git a/Silicon/StarFive/JH7110Pkg/JH7110Pkg.dec b/Silicon/StarFive/JH7110Pkg/JH7110Pkg.dec > new file mode 100644 > index 000000000000..438557a15500 > --- /dev/null > +++ b/Silicon/StarFive/JH7110Pkg/JH7110Pkg.dec > @@ -0,0 +1,45 @@ > +## @file > +# > +# Copyright (c) 2023, StarFive Technology Co., Ltd. All rights reserved.
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + DEC_SPECIFICATION = 0x0001001A > + PACKAGE_NAME = JH7110Pkg > + PACKAGE_GUID = D4B585C5-EBCA-4779-B974-05A3CF2F10C4 > + PACKAGE_VERSION = 1.0 > + > +[Includes] > + Include > + > +[Guids] > + gJH7110TokenSpaceGuid = {0x44045e56, 0x7056, 0x4be6, {0x88, 0xc0, 0x49, 0x0c, 0x67, 0x90, 0x2f, 0xba}} > + > +[PcdsFixedAtBuild.common] > +# Memory map > + gJH7110TokenSpaceGuid.PcdJH7110FlashVarOffset|0x0|UINT32|0x00000001 > + > +# PCIe > + gJH7110TokenSpaceGuid.PcdJH7110RegistersAddress|0|UINT32|0x00000002 > + gJH7110TokenSpaceGuid.PcdJH7110PciRegBase|0x2b000000|UINT64|0x00000003 > + gJH7110TokenSpaceGuid.PcdJH7110PciBusMmioAdr|0x0|UINT64|0x00000004 > + gJH7110TokenSpaceGuid.PcdJH7110PciBusMmioLen|0x0|UINT32|0x00000005 > + gJH7110TokenSpaceGuid.PcdJH7110PciCpuMmioAdr|0x0|UINT64|0x00000006 > + gJH7110TokenSpaceGuid.PcdJH7110PciConfigRegBase|0x940000000|UINT64|0x00000007 > + > +# SPI > + gJH7110TokenSpaceGuid.PcdSpiFlashRegBase|0|UINT32|0x10000008 > + gJH7110TokenSpaceGuid.PcdSpiFlashAhbBase|0|UINT64|0x10000009 > + gJH7110TokenSpaceGuid.PcdSpiFlashFifoWidth|0|UINT8|0x10000010 > + gJH7110TokenSpaceGuid.PcdSpiFlashRefClkHz|0|UINT32|0x10000011 > + gJH7110TokenSpaceGuid.PcdSpiFlashTshslNs|0|UINT32|0x10000012 > + gJH7110TokenSpaceGuid.PcdSpiFlashTsd2dNs|0|UINT32|0x1000013 > + gJH7110TokenSpaceGuid.PcdSpiFlashTchshNs|0|UINT32|0x1000014 > + gJH7110TokenSpaceGuid.PcdSpiFlashTslchNs|0|UINT32|0x1000015 > + > +[Protocols] > + gJH7110SpiMasterProtocolGuid = { 0xA33C46E0, 0x4FB6, 0x4AA3, { 0x8E, 0x66, 0x00, 0x06, 0x9F, 0x3A, 0x11, 0x81 }} > + gJH7110SpiFlashProtocolGuid = { 0x5ECECDF6, 0x81DA, 0x4E10, { 0x9D, 0x4B, 0x26, 0x65, 0x8C, 0x03, 0xAB, 0xBC }} > -- > 2.34.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109803): https://edk2.groups.io/g/devel/message/109803 Mute This Topic: https://groups.io/mt/102053687/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-