From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6195CD806C6 for ; Thu, 26 Oct 2023 10:05:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QeumVGb8jjDiaLbntOJnFmJPfIRf0C4lVXCozhfKeng=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1698314756; v=1; b=XLxCwcJlR5Bs9b03VosJ1/MujTMcmkcdux0zAA/aj9rKycfd9F2VfvQg3jhwf2QLG4le5j7K 3yydkpVsrpi/mf/JHw57akHv4jNTxPMInFt5Cx7mncnZ8buRRg9AWBwAoDLoF+b09MDJzE/ttMF VFRgw42mTRSVdK5nKzft9aXg= X-Received: by 127.0.0.2 with SMTP id KYNXYY7687511xzYLAJEac7g; Thu, 26 Oct 2023 03:05:56 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.196669.1698314756177088957 for ; Thu, 26 Oct 2023 03:05:56 -0700 X-Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39Q9K9WH017013; Thu, 26 Oct 2023 10:05:46 GMT X-Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tykw28a93-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Oct 2023 10:05:45 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 39QA5iTI022582 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Oct 2023 10:05:44 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Thu, 26 Oct 2023 03:05:42 -0700 Date: Thu, 26 Oct 2023 11:05:39 +0100 From: "Leif Lindholm" To: CC: , Sami Mujawar , Ard Biesheuvel , Michael D Kinney , Liming Gao Subject: Re: [edk2-devel] [PATCH v2 01/11] ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION Message-ID: References: <20231025112540.1654844-1-pierre.gondois@arm.com> <20231025112540.1654844-2-pierre.gondois@arm.com> MIME-Version: 1.0 In-Reply-To: <20231025112540.1654844-2-pierre.gondois@arm.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: JFbi_q62vVbRkjNx3tIX0-W4yG3AOTFb X-Proofpoint-GUID: JFbi_q62vVbRkjNx3tIX0-W4yG3AOTFb Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Xt6W4JOpP44gyLCYxMdtHRSGx7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=XLxCwcJl; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none) On Wed, Oct 25, 2023 at 13:25:30 +0200, pierre.gondois@arm.com wrote: > From: Pierre Gondois > > Rename PERFORMANCE_PROTOCOL_VERSION to reflect the different > versions of the protocol. The macro is neither used in edk2 nor > in edk2-platforms. OK, so slight nitpick, but mainly because it parses a bit weirdly... *Will* it be used after this series is merged, or is this an update for completeness? > Signed-off-by: Pierre Gondois > --- > ArmPkg/Include/Library/ArmLib.h | 1 + > .../Include/Protocol/ArmScmiPerformanceProtocol.h | 13 ++++++++----- > 2 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/ArmPkg/Include/Library/ArmLib.h b/ArmPkg/Include/Library/ArmLib.h > index 0169dbc1092c..7b2b2238fed9 100644 > --- a/ArmPkg/Include/Library/ArmLib.h > +++ b/ArmPkg/Include/Library/ArmLib.h > @@ -780,6 +780,7 @@ EFIAPI > ArmHasVhe ( > VOID > ); > + > #endif // MDE_CPU_AARCH64 > > #ifdef MDE_CPU_ARM > diff --git a/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h b/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h > index 7e548e4765c2..8e8e05d5a5f6 100644 > --- a/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h > +++ b/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h > @@ -1,12 +1,12 @@ > /** @file > > - Copyright (c) 2017-2021, Arm Limited. All rights reserved. > + Copyright (c) 2017-2023, Arm Limited. All rights reserved. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > - System Control and Management Interface V1.0 > - http://infocenter.arm.com/help/topic/com.arm.doc.den0056a/ > - DEN0056A_System_Control_and_Management_Interface.pdf > + System Control and Management Interface, latest version: I see this as a pattern throughout the series. But this statement will at some point become untrue; this implementation is written against a specific version. I think this version shold be reflected in the comment. (And that applies throughout the series.) > + - https://developer.arm.com/documentation/den0056/latest/ But I think the above is the most useful link. / Leif > + > **/ > > #ifndef ARM_SCMI_PERFORMANCE_PROTOCOL_H_ > @@ -14,7 +14,10 @@ > > #include > > -#define PERFORMANCE_PROTOCOL_VERSION 0x10000 > +/// Arm Scmi performance protocol versions. > +#define PERFORMANCE_PROTOCOL_VERSION_V1 0x10000 > +#define PERFORMANCE_PROTOCOL_VERSION_V2 0x20000 > +#define PERFORMANCE_PROTOCOL_VERSION_V3 0x30000 > > #define ARM_SCMI_PERFORMANCE_PROTOCOL_GUID { \ > 0x9b8ba84, 0x3dd3, 0x49a6, {0xa0, 0x5a, 0x31, 0x34, 0xa5, 0xf0, 0x7b, 0xad} \ > -- > 2.25.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110088): https://edk2.groups.io/g/devel/message/110088 Mute This Topic: https://groups.io/mt/102175810/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-