From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0FD259414CE for ; Thu, 26 Oct 2023 10:45:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5HjpSNiazz/Me+XfCZdNuDy7RmILfL0D/N9Go+OT7CU=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1698317139; v=1; b=NEgicEBPznSnD7VSg/QFfeaC8z+ydlH+ScN7jNmTsDq3kW9/Fyw2h95g0P2LqG4AZ/1VpZ4w QFAibJl+e4vtqnvNOa7K5uZnUVN/Uk8JeePJ00u1HZhDNCOj8jhSAPM1JNQ/V2OssvZMLIONegq PGmTRGViaHNMKYIFSWhaUSmQ= X-Received: by 127.0.0.2 with SMTP id PIBlYY7687511xXO4QbEGhJ8; Thu, 26 Oct 2023 03:45:39 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.197214.1698317139264838498 for ; Thu, 26 Oct 2023 03:45:39 -0700 X-Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39QAGHvY020904; Thu, 26 Oct 2023 10:45:28 GMT X-Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ty0tu2ttr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Oct 2023 10:45:28 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 39QAjRNC014400 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Oct 2023 10:45:27 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Thu, 26 Oct 2023 03:45:25 -0700 Date: Thu, 26 Oct 2023 11:45:22 +0100 From: "Leif Lindholm" To: CC: , Sami Mujawar , Ard Biesheuvel , Michael D Kinney , Liming Gao Subject: Re: [edk2-devel] [PATCH v2 07/11] DynamicTablesPkg: Add PsdToken field to CM_ARM_GICC_INFO object Message-ID: References: <20231025112540.1654844-1-pierre.gondois@arm.com> <20231025112540.1654844-8-pierre.gondois@arm.com> MIME-Version: 1.0 In-Reply-To: <20231025112540.1654844-8-pierre.gondois@arm.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: 9g4neh9TPuf88G2JIvVWRSFzZD4Bi3rX X-Proofpoint-GUID: 9g4neh9TPuf88G2JIvVWRSFzZD4Bi3rX Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: SRKZABFTDOTShRcLvEnefGAMx7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=NEgicEBP; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Oct 25, 2023 at 13:25:36 +0200, pierre.gondois@arm.com wrote: > From: Pierre Gondois > > The _PSD object (cf. ACPI 6.4, s8.4.5.5 _PSD (P-State Dependency) > allows to describe CPU's power state dependencies. Add a PsdToken > field to the CM_ARM_GICC_INFO object so that interdependent CPUs > can reference the same CM_ARM_PSD_INFO object. > > Signed-off-by: Pierre Gondois > --- > DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 5 +++++ > .../Common/TableHelperLib/ConfigurationManagerObjectParser.c | 5 +++-- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h > index ddd17fa45b1e..2a0ebe24bd04 100644 > --- a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h > +++ b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h > @@ -204,6 +204,11 @@ typedef struct CmArmGicCInfo { > i.e. a token referencing a CM_ARM_CPC_INFO object. > */ > CM_OBJECT_TOKEN CpcToken; > + > + /** Optional field: Reference Token for the Psd info of this processor. > + i.e. a token referencing a CM_ARM_PSD_INFO object. > + */ > + CM_OBJECT_TOKEN PsdToken; > } CM_ARM_GICC_INFO; > > /** A structure that describes the > diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > index b3ee12da8c4f..a9f5c95c1039 100644 > --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > @@ -83,7 +83,8 @@ STATIC CONST CM_OBJ_PARSER CmArmGicCInfoParser[] = { > { "ProximityDomain", 4, "0x%x", NULL }, > { "ClockDomain", 4, "0x%x", NULL }, > { "AffinityFlags", 4, "0x%x", NULL }, > - { "CpcToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL } > + { "CpcToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, > + { "PsdToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, > }; > > /** A parser for EArmObjGicDInfo. > @@ -766,7 +767,7 @@ STATIC CONST CM_OBJ_PARSER_ARRAY ArmNamespaceObjectParser[] = { > ARRAY_SIZE (CmArmPccSubspaceType34InfoParser) }, > { "EArmObjPccSubspaceType5Info", CmArmPccSubspaceType5InfoParser, > ARRAY_SIZE (CmArmPccSubspaceType5InfoParser) }, > - { "EArmObjCpcInfo", CmArmPsdInfoParser, > + { "EArmObjPsdInfo", CmArmPsdInfoParser, Can you add something to the commit message about this bit? / Leif > ARRAY_SIZE (CmArmPsdInfoParser) }, > { "EArmObjMax", NULL, 0 }, > }; > -- > 2.25.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110090): https://edk2.groups.io/g/devel/message/110090 Mute This Topic: https://groups.io/mt/102175817/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-