From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Cc: <devel@edk2.groups.io>, Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: PCI node in DSDT does not need _ADR
Date: Thu, 26 Oct 2023 18:18:27 +0100 [thread overview]
Message-ID: <ZTqfY/4UcUgBfNqz@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <20231018123826.1052741-1-marcin.juszkiewicz@linaro.org>
On Wed, Oct 18, 2023 at 14:38:26 +0200, Marcin Juszkiewicz wrote:
> 190: Device (PCI0) Warning 3073 -
> Multiple types ^ (Device object requires either a _HID or _ADR, but not both)
>
> PCI Firmware specification does not require _ADR for Host bridges.
>
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
Pushed as 74b9eacfd453.
Thanks!
> ---
> Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
> index ba3eefc975a5..b55ad6c5cc07 100644
> --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
> +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
> @@ -191,7 +191,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
> Name (_CID, EISAID ("PNP0A03")) // Compatible PCI Root Bridge
> Name (_SEG, Zero) // PCI Segment Group number
> Name (_BBN, Zero) // PCI Base Bus Number
> - Name (_ADR, Zero)
> Name (_UID, "PCI0")
> Name (_CCA, One) // Initially mark the PCI coherent (for JunoR1)
>
> --
> 2.41.0
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110131): https://edk2.groups.io/g/devel/message/110131
Mute This Topic: https://groups.io/mt/102037894/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-10-26 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 12:38 [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: PCI node in DSDT does not need _ADR Marcin Juszkiewicz
2023-10-26 17:18 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTqfY/4UcUgBfNqz@qc-i7.hemma.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox