From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1DB9AD802E7 for ; Thu, 26 Oct 2023 17:18:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3lWdhHhuphongw+XV5vy2yHiaQjDJz0VHBqy394I1HQ=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1698340713; v=1; b=p4rR9fJiglwoz0YXoJMUU8sNfVrtZsS6TK7B/T+r/VDBYMMwCSe2hsIShBggxaecNfjLciRl TgU+7QSUpTZOeOPP0TFzSMnxiznNv0z+feXhmaYsOQfpoYXYpK5lg0pNFS/yzUPbVhYZ6aisugN AZuhDj6Rltd99AnkJ4NNZbLk= X-Received: by 127.0.0.2 with SMTP id z09hYY7687511xmMrCFR3ZL7; Thu, 26 Oct 2023 10:18:33 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.206374.1698340713363766693 for ; Thu, 26 Oct 2023 10:18:33 -0700 X-Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39QCuBTx016707; Thu, 26 Oct 2023 17:18:33 GMT X-Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tyfwfsv5h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Oct 2023 17:18:32 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 39QHIW3d021042 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Oct 2023 17:18:32 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Thu, 26 Oct 2023 10:18:30 -0700 Date: Thu, 26 Oct 2023 18:18:27 +0100 From: "Leif Lindholm" To: Marcin Juszkiewicz CC: , Ard Biesheuvel Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: PCI node in DSDT does not need _ADR Message-ID: References: <20231018123826.1052741-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 In-Reply-To: <20231018123826.1052741-1-marcin.juszkiewicz@linaro.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: 3AoUplkMhQ2WncTCaboXqiAaw25TrTX7 X-Proofpoint-GUID: 3AoUplkMhQ2WncTCaboXqiAaw25TrTX7 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: KoKLVvYQJ6YYwTDcXmjqPloMx7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=p4rR9fJi; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none) On Wed, Oct 18, 2023 at 14:38:26 +0200, Marcin Juszkiewicz wrote: > 190: Device (PCI0) Warning 3073 - > Multiple types ^ (Device object requires either a _HID or _ADR, but not both) > > PCI Firmware specification does not require _ADR for Host bridges. > > Signed-off-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm Pushed as 74b9eacfd453. Thanks! > --- > Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl > index ba3eefc975a5..b55ad6c5cc07 100644 > --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl > +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl > @@ -191,7 +191,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", > Name (_CID, EISAID ("PNP0A03")) // Compatible PCI Root Bridge > Name (_SEG, Zero) // PCI Segment Group number > Name (_BBN, Zero) // PCI Base Bus Number > - Name (_ADR, Zero) > Name (_UID, "PCI0") > Name (_CCA, One) // Initially mark the PCI coherent (for JunoR1) > > -- > 2.41.0 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110131): https://edk2.groups.io/g/devel/message/110131 Mute This Topic: https://groups.io/mt/102037894/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-