[edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: PCI node in DSDT does not need _ADR

[edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: PCI node in DSDT does not need _ADR

[Marcin Juszkiewicz]

190:     Device (PCI0) Warning  3073 -
Multiple types ^  (Device object requires either a _HID or _ADR, but not both)

PCI Firmware specification does not require _ADR for Host bridges.

Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
 Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
index ba3eefc975a5..b55ad6c5cc07 100644
--- a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
+++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
@@ -191,7 +191,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
       Name (_CID, EISAID ("PNP0A03")) // Compatible PCI Root Bridge
       Name (_SEG, Zero) // PCI Segment Group number
       Name (_BBN, Zero) // PCI Base Bus Number
-      Name (_ADR, Zero)
       Name (_UID, "PCI0")
       Name (_CCA, One)    // Initially mark the PCI coherent (for JunoR1)
 
-- 
2.41.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109743): https://edk2.groups.io/g/devel/message/109743
Mute This Topic: https://groups.io/mt/102037894/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: PCI node in DSDT does not need _ADR

[Leif Lindholm]

On Wed, Oct 18, 2023 at 14:38:26 +0200, Marcin Juszkiewicz wrote:
> 190:     Device (PCI0) Warning  3073 -
> Multiple types ^  (Device object requires either a _HID or _ADR, but not both)
> 
> PCI Firmware specification does not require _ADR for Host bridges.
> 
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>

Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
Pushed as 74b9eacfd453.

Thanks!

> ---
>  Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
> index ba3eefc975a5..b55ad6c5cc07 100644
> --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
> +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
> @@ -191,7 +191,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
>        Name (_CID, EISAID ("PNP0A03")) // Compatible PCI Root Bridge
>        Name (_SEG, Zero) // PCI Segment Group number
>        Name (_BBN, Zero) // PCI Base Bus Number
> -      Name (_ADR, Zero)
>        Name (_UID, "PCI0")
>        Name (_CCA, One)    // Initially mark the PCI coherent (for JunoR1)
>  
> -- 
> 2.41.0
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110131): https://edk2.groups.io/g/devel/message/110131
Mute This Topic: https://groups.io/mt/102037894/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-