From: "Sunil V L" <sunilvl@ventanamicro.com>
To: John Chew <yuinyee.chew@starfivetech.com>
Cc: devel@edk2.groups.io, Leif Lindholm <quic_llindhol@quicinc.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Li Yong <yong.li@intel.com>,
mindachen1987 <minda.chen@starfivetech.com>
Subject: Re: [edk2-devel] [PATCH v3 0/5] StarFive/VisionFive2: Add VisionFive 2 platform
Date: Tue, 31 Oct 2023 14:56:03 +0530 [thread overview]
Message-ID: <ZUDIK+6Mn2FxU8xQ@sunil-laptop> (raw)
In-Reply-To: <20231027031906.1814-1-yuinyee.chew@starfivetech.com>
Hi John,
I forgot to mention that you need one more patch to add the maintainer
entry for the platform.
Otherwise, for the series,
Acked-by: Sunil V L <sunilvl@ventanamicro.com>
Thanks,
Sunil
On Fri, Oct 27, 2023 at 11:19:01AM +0800, John Chew wrote:
> v3:
> - Combine "Add VisionFive 2 platform" patch series with
> "Patches for JH7110 SoC platform" patch series [Sunil]
> - Change commit message for [1/5], [4/5], [5/5] in this patch series
> [Sunil]
>
> v2:
> - Change PlatformBootManagerLib to:
> Platform/RISC-V/PlatformPkg/.../PlatformBootManagerLib.inf
> [Sunil]
> - Added PCIE PCDs
> PcdPciBusMin, PcdPciBusMax, PcdPciIoBase, PcdPciIoSize
> PcdPciIoOffset, PcdPci0Mmio32Base, PcdPci0Mmio32Size
> PcdPci0Mmio64Base, PcdPci0Mmio64Size, PcdPci1Mmio32Base
> PcdPci1Mmio32Size, PcdPci1Mmio64Base, PcdPci1Mmio64Size
> [John Chew]
> - Include all maintainer in all patches in this series [Sunil]
> - Added missing commit message to patches 1/6, 2/6, 6/6 [Sunil]
> - Remove commented code in JH7110.h [Sunil]
> - Remove BootServicesDxe/BootServicesDxe.inf, as it is not required
> anymore because memory allocation is handle by MMC driver [Sunil]
> - Remove PlatformBootManagerLib.inf and change PlatformBootManagerLib to
> "Platform/RISC-V/PlatformPkg/.../PlatformBootManagerLib.inf" [Sunil]
> - Added PCDs for PCIE (Please refer to patch 0001 for details) [John Chew]
>
> v1:
> - Added new platform support for VisionFive2 SBC.
> - Boot flow in VF2 using EDK2 as bootloader:
> BootROM -> U-Boot SPL -> OpenSBI -> EDK2 -> Linux -> OS
> - Supported boot source for Linux from EDK2:
> - SD Card
> - eMMC
> - NVMe
> - USB
> - In this patches it include all the platform specific drivers/protocol
> that is being use for JH7110 SoC platform. All the drivers includes:
> 1. PCIE driver for NVME and USB (GT710 graphic in progress)
> 2. QSPI Flash driver for efi variable
> 3. FVB driver for efi variable
> 4. Boot service memory allocation driver
> 5. Platform boot manager for graphical console display
>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Li Yong <yong.li@intel.com>
> Cc: mindachen1987 <minda.chen@starfivetech.com>
>
> John Chew (2):
> StarFive/JH7110Pkg: Add SPI protocol and driver support
> StarFive/JH7110Pkg: Add firmware volume block protocol
>
> mindachen1987 (3):
> StarFive/JH7110Pkg: Add Pci controller driver
> StarFive/JH7110Pkg: Add JH7110 Silicon Package
> StarFive/VisionFive2: Add VisionFive 2 platform
>
> Platform/StarFive/VisionFive2/DeviceTree/Gpio.h | 42 +
> Platform/StarFive/VisionFive2/DeviceTree/Irq.h | 20 +
> Platform/StarFive/VisionFive2/DeviceTree/JH7110ClkGen.h | 398 +++++
> Platform/StarFive/VisionFive2/DeviceTree/JH7110ClkIsp.h | 57 +
> Platform/StarFive/VisionFive2/DeviceTree/JH7110ClkVout.h | 68 +
> Platform/StarFive/VisionFive2/DeviceTree/JH7110PinCtrl.h | 1573 +++++++++++++++++
> Platform/StarFive/VisionFive2/DeviceTree/JH7110Power.h | 22 +
> Platform/StarFive/VisionFive2/DeviceTree/JH7110Rst.h | 228 +++
> Platform/StarFive/VisionFive2/DeviceTree/Led.h | 90 +
> Platform/StarFive/VisionFive2/DeviceTree/StarFiveClk.dtsi | 130 ++
> Platform/StarFive/VisionFive2/DeviceTree/StarFiveHdmi.dtsi | 28 +
> Platform/StarFive/VisionFive2/DeviceTree/StarFiveJH7110.dtsi | 1812 ++++++++++++++++++++
> Platform/StarFive/VisionFive2/DeviceTree/StarFivePwmDac.dtsi | 26 +
> Platform/StarFive/VisionFive2/DeviceTree/StarFiveVisionFive2.dts | 211 +++
> Platform/StarFive/VisionFive2/DeviceTree/StarFiveVisionFive2.dtsi | 838 +++++++++
> Platform/StarFive/VisionFive2/DeviceTree/Thermal.h | 16 +
> Platform/StarFive/VisionFive2/DeviceTree/VisionFive2DeviceTree.inf | 36 +
> Platform/StarFive/VisionFive2/VarStore.fdf.inc | 77 +
> Platform/StarFive/VisionFive2/VisionFive2.dsc | 596 +++++++
> Platform/StarFive/VisionFive2/VisionFive2.fdf | 284 +++
> Platform/StarFive/VisionFive2/VisionFive2.fdf.inc | 48 +
> Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/FvbDxe/FvbDxe.c | 909 ++++++++++
> Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/FvbDxe/FvbDxe.h | 138 ++
> Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/FvbDxe/FvbDxe.inf | 70 +
> Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/SpiDxe/SpiDxe.c | 893 ++++++++++
> Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/SpiDxe/SpiDxe.h | 188 ++
> Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/SpiDxe/SpiDxe.inf | 52 +
> Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/SpiFlashDxe/SpiFlashDxe.c | 571 ++++++
> Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/SpiFlashDxe/SpiFlashDxe.h | 35 +
> Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/SpiFlashDxe/SpiFlashDxe.inf | 44 +
> Silicon/StarFive/JH7110Pkg/Include/IndustryStandard/JH7110.h | 21 +
> Silicon/StarFive/JH7110Pkg/Include/Protocol/Spi.h | 163 ++
> Silicon/StarFive/JH7110Pkg/Include/Protocol/SpiFlash.h | 88 +
> Silicon/StarFive/JH7110Pkg/JH7110Pkg.dec | 57 +
> Silicon/StarFive/JH7110Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 263 +++
> Silicon/StarFive/JH7110Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 61 +
> Silicon/StarFive/JH7110Pkg/Library/PciHostBridgeLib/PciHostBridgeLibConstructor.c | 406 +++++
> Silicon/StarFive/JH7110Pkg/Library/PciSegmentLib/PciSegmentLib.c | 1460 ++++++++++++++++
> Silicon/StarFive/JH7110Pkg/Library/PciSegmentLib/PciSegmentLib.inf | 33 +
> 39 files changed, 12052 insertions(+)
> create mode 100644 Platform/StarFive/VisionFive2/DeviceTree/Gpio.h
> create mode 100644 Platform/StarFive/VisionFive2/DeviceTree/Irq.h
> create mode 100644 Platform/StarFive/VisionFive2/DeviceTree/JH7110ClkGen.h
> create mode 100644 Platform/StarFive/VisionFive2/DeviceTree/JH7110ClkIsp.h
> create mode 100644 Platform/StarFive/VisionFive2/DeviceTree/JH7110ClkVout.h
> create mode 100755 Platform/StarFive/VisionFive2/DeviceTree/JH7110PinCtrl.h
> create mode 100755 Platform/StarFive/VisionFive2/DeviceTree/JH7110Power.h
> create mode 100644 Platform/StarFive/VisionFive2/DeviceTree/JH7110Rst.h
> create mode 100644 Platform/StarFive/VisionFive2/DeviceTree/Led.h
> create mode 100755 Platform/StarFive/VisionFive2/DeviceTree/StarFiveClk.dtsi
> create mode 100644 Platform/StarFive/VisionFive2/DeviceTree/StarFiveHdmi.dtsi
> create mode 100644 Platform/StarFive/VisionFive2/DeviceTree/StarFiveJH7110.dtsi
> create mode 100644 Platform/StarFive/VisionFive2/DeviceTree/StarFivePwmDac.dtsi
> create mode 100644 Platform/StarFive/VisionFive2/DeviceTree/StarFiveVisionFive2.dts
> create mode 100755 Platform/StarFive/VisionFive2/DeviceTree/StarFiveVisionFive2.dtsi
> create mode 100644 Platform/StarFive/VisionFive2/DeviceTree/Thermal.h
> create mode 100644 Platform/StarFive/VisionFive2/DeviceTree/VisionFive2DeviceTree.inf
> create mode 100644 Platform/StarFive/VisionFive2/VarStore.fdf.inc
> create mode 100644 Platform/StarFive/VisionFive2/VisionFive2.dsc
> create mode 100644 Platform/StarFive/VisionFive2/VisionFive2.fdf
> create mode 100644 Platform/StarFive/VisionFive2/VisionFive2.fdf.inc
> create mode 100644 Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/FvbDxe/FvbDxe.c
> create mode 100644 Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/FvbDxe/FvbDxe.h
> create mode 100644 Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/FvbDxe/FvbDxe.inf
> create mode 100755 Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/SpiDxe/SpiDxe.c
> create mode 100644 Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/SpiDxe/SpiDxe.h
> create mode 100644 Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/SpiDxe/SpiDxe.inf
> create mode 100755 Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/SpiFlashDxe/SpiFlashDxe.c
> create mode 100755 Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/SpiFlashDxe/SpiFlashDxe.h
> create mode 100644 Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/SpiFlashDxe/SpiFlashDxe.inf
> create mode 100644 Silicon/StarFive/JH7110Pkg/Include/IndustryStandard/JH7110.h
> create mode 100644 Silicon/StarFive/JH7110Pkg/Include/Protocol/Spi.h
> create mode 100644 Silicon/StarFive/JH7110Pkg/Include/Protocol/SpiFlash.h
> create mode 100644 Silicon/StarFive/JH7110Pkg/JH7110Pkg.dec
> create mode 100644 Silicon/StarFive/JH7110Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.c
> create mode 100644 Silicon/StarFive/JH7110Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
> create mode 100644 Silicon/StarFive/JH7110Pkg/Library/PciHostBridgeLib/PciHostBridgeLibConstructor.c
> create mode 100644 Silicon/StarFive/JH7110Pkg/Library/PciSegmentLib/PciSegmentLib.c
> create mode 100644 Silicon/StarFive/JH7110Pkg/Library/PciSegmentLib/PciSegmentLib.inf
>
> --
> 2.34.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110391): https://edk2.groups.io/g/devel/message/110391
Mute This Topic: https://groups.io/mt/102214516/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-10-31 9:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 3:19 [edk2-devel] [PATCH v3 0/5] StarFive/VisionFive2: Add VisionFive 2 platform John Chew
2023-10-27 3:19 ` [edk2-devel] [PATCH v3 1/5] StarFive/JH7110Pkg: Add Pci controller driver John Chew
2023-10-27 3:19 ` [edk2-devel] [PATCH v3 2/5] StarFive/JH7110Pkg: Add SPI protocol and driver support John Chew
2023-10-27 3:19 ` [edk2-devel] [PATCH v3 3/5] StarFive/JH7110Pkg: Add firmware volume block protocol John Chew
2023-10-27 3:19 ` [edk2-devel] [PATCH v3 4/5] StarFive/JH7110Pkg: Add JH7110 Silicon Package John Chew
2023-10-27 3:19 ` [edk2-devel] [PATCH v3 5/5] StarFive/VisionFive2: Add VisionFive 2 platform John Chew
2023-10-31 9:26 ` Sunil V L [this message]
2023-11-01 1:17 ` [edk2-devel] [PATCH v3 0/5] " John Chew
2023-11-02 4:00 ` Sunil V L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUDIK+6Mn2FxU8xQ@sunil-laptop \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox