From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 561AB941F0D for ; Wed, 8 Nov 2023 23:11:16 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Bpz+Lrtl5y09SryY4YTMAaVtpVWYKdn31LqaTa2G+tY=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20140610; t=1699485075; v=1; b=TDOKkMtlJ/qyAOrlH5OQMFYmGOvB1/DoS71/wVewpa4y0P3mV0Jd9KjUoJf1zHbwhBC7VtP0 OZuk+mLDeC9wkINRA98KPH7hXYo8GwRRUM+Ijl1CnNwGJXJlIbhQ/ldFyfZJriOFR/Lo41WCVtU c64K2qavvsPQnfpaHiYH0XJY= X-Received: by 127.0.0.2 with SMTP id fUHvYY7687511x4uL5Lps48s; Wed, 08 Nov 2023 15:11:15 -0800 X-Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mx.groups.io with SMTP id smtpd.web10.107680.1699485074406362151 for ; Wed, 08 Nov 2023 15:11:14 -0800 X-Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1cc37fb1310so1618745ad.1 for ; Wed, 08 Nov 2023 15:11:14 -0800 (PST) X-Gm-Message-State: 0JyCQjfur4h6SzsYwKn9AvUIx7686176AA= X-Google-Smtp-Source: AGHT+IEjvIG+kJXzAcW+avbeyD4NG8RnCXaRxb0V0Sx7aAXnouc1qJ/YUb8Z7SJjQwVGOeddCPSFPA== X-Received: by 2002:a17:902:9b95:b0:1cc:138a:287b with SMTP id y21-20020a1709029b9500b001cc138a287bmr2957207plp.3.1699485073076; Wed, 08 Nov 2023 15:11:13 -0800 (PST) X-Received: from sunil-laptop ([106.51.188.78]) by smtp.gmail.com with ESMTPSA id c8-20020a170902aa4800b001ca4c20003dsm2205596plr.69.2023.11.08.15.11.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 15:11:12 -0800 (PST) Date: Thu, 9 Nov 2023 04:41:06 +0530 From: "Sunil V L" To: devel@edk2.groups.io, lichao@loongson.cn Cc: kraxel@redhat.com, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Xianglai Li , Bibo Mao Subject: Re: [edk2-devel] [PATCH v2 17/30] OvmfPkg/LoongArchVirt: Add PciCpuIo2Dxe module Message-ID: References: <20231106032521.2251143-1-lichao@loongson.cn> <20231106032920.2285574-1-lichao@loongson.cn> MIME-Version: 1.0 In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=TDOKkMtl; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, Nov 07, 2023 at 06:03:43PM +0800, Chao Li wrote: > Hi Gerd, > > Yes, you are right, this driver could probably be located somewhere else > where other ARCH can easily use it, but I can not find the right place, > maybe MdeModulePkg or MdePkg? I also feel that something is not quite right > about these two places... > Hi Chao, It was in my TODO list and somehow never got time, is to migrate some of these drivers and libraries to common place and use them instead of copy. For ex: Move ArmPciCpuIo2Dxe to UefiCpuPkg/CpuIo2Dxe. Either merge with CpuIo2Dxe or add something like MmioCpuIo2Dxe. I think you can take this approach. The recommendation I got from Mike earlier was: MdePkg for libraries, UefiCpuPkg for drivers and OvmfPkg for purely Qemu specific. Adding new things in MdeModulePkg was not recommended. Thanks, Sunil > > Thanks, > Chao > 在 2023/11/7 17:42, Gerd Hoffmann 写道: > > On Mon, Nov 06, 2023 at 11:29:20AM +0800, Chao Li wrote: > > > Add PciCpuIo2Dxe for LoongArch, this module is similar to > > > ArmPciCpuIo2Dxe drvier. > > What are the differences to ArmPciCpuIo2Dxe? > > On a quick glance I can't see anything arch-specific here. > > > > Maybe we should find a better place for ArmPciCpuIo2Dxe so loongarch > > can use it without copying the code? > > > > take care, > > Gerd > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110934): https://edk2.groups.io/g/devel/message/110934 Mute This Topic: https://groups.io/mt/102413880/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-